diff options
author | Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> | 2014-02-21 10:54:53 -0500 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> | 2014-04-17 06:16:12 -0400 |
commit | b11762f8431b3a5cf1c156876e79efab7d7f80c4 (patch) | |
tree | db4bef1e44df452faa94b03baedd5b6247a304f0 | |
parent | ac1ef1fed3d2c1cd4902ecb92876cb239c97a870 (diff) |
iommu/shmobile: Use devm_ioremap_resource()
Replace the devm_ioremap_nocache() call with devm_ioremap_resource().
This simplifies error checking.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
-rw-r--r-- | drivers/iommu/shmobile-ipmmu.c | 17 |
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/iommu/shmobile-ipmmu.c b/drivers/iommu/shmobile-ipmmu.c index 6ba611002c6f..bd97adecb1fd 100644 --- a/drivers/iommu/shmobile-ipmmu.c +++ b/drivers/iommu/shmobile-ipmmu.c | |||
@@ -94,11 +94,6 @@ static int ipmmu_probe(struct platform_device *pdev) | |||
94 | struct resource *res; | 94 | struct resource *res; |
95 | struct shmobile_ipmmu_platform_data *pdata = pdev->dev.platform_data; | 95 | struct shmobile_ipmmu_platform_data *pdata = pdev->dev.platform_data; |
96 | 96 | ||
97 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
98 | if (!res) { | ||
99 | dev_err(&pdev->dev, "cannot get platform resources\n"); | ||
100 | return -ENOENT; | ||
101 | } | ||
102 | ipmmu = devm_kzalloc(&pdev->dev, sizeof(*ipmmu), GFP_KERNEL); | 97 | ipmmu = devm_kzalloc(&pdev->dev, sizeof(*ipmmu), GFP_KERNEL); |
103 | if (!ipmmu) { | 98 | if (!ipmmu) { |
104 | dev_err(&pdev->dev, "cannot allocate device data\n"); | 99 | dev_err(&pdev->dev, "cannot allocate device data\n"); |
@@ -106,12 +101,12 @@ static int ipmmu_probe(struct platform_device *pdev) | |||
106 | } | 101 | } |
107 | spin_lock_init(&ipmmu->flush_lock); | 102 | spin_lock_init(&ipmmu->flush_lock); |
108 | ipmmu->dev = &pdev->dev; | 103 | ipmmu->dev = &pdev->dev; |
109 | ipmmu->ipmmu_base = devm_ioremap_nocache(&pdev->dev, res->start, | 104 | |
110 | resource_size(res)); | 105 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
111 | if (!ipmmu->ipmmu_base) { | 106 | ipmmu->ipmmu_base = devm_ioremap_resource(&pdev->dev, res); |
112 | dev_err(&pdev->dev, "ioremap_nocache failed\n"); | 107 | if (IS_ERR(ipmmu->ipmmu_base)) |
113 | return -ENOMEM; | 108 | return PTR_ERR(ipmmu->ipmmu_base); |
114 | } | 109 | |
115 | ipmmu->dev_names = pdata->dev_names; | 110 | ipmmu->dev_names = pdata->dev_names; |
116 | ipmmu->num_dev_names = pdata->num_dev_names; | 111 | ipmmu->num_dev_names = pdata->num_dev_names; |
117 | platform_set_drvdata(pdev, ipmmu); | 112 | platform_set_drvdata(pdev, ipmmu); |