diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-13 19:19:00 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-13 19:19:00 -0500 |
commit | aa3bee0daa38570b174ef6b8a77261b4473d5614 (patch) | |
tree | 0c016f33b4d4c96f2c4d27c5ae4dd39528c9fb46 | |
parent | 187df6921c5e9d356a7522946655e11cc01c7f12 (diff) |
lustre: delete linux/lustre_debug.h
There was only one macro in here, LL_CDEBUG_PAGE(). So open code it in
the 2 places it was used so that the developer seeing it can see just
how horrid it really is, and they can remove it as I doubt it really is
ever needed anymore. But for now, keep the same functionality and
remove a whole file (with a duplicate name of other files in the lustre
repo, another confusion...)
Cc: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
4 files changed, 11 insertions, 53 deletions
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_debug.h b/drivers/staging/lustre/lustre/include/linux/lustre_debug.h deleted file mode 100644 index 11deac7248ae..000000000000 --- a/drivers/staging/lustre/lustre/include/linux/lustre_debug.h +++ /dev/null | |||
@@ -1,47 +0,0 @@ | |||
1 | /* | ||
2 | * GPL HEADER START | ||
3 | * | ||
4 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
5 | * | ||
6 | * This program is free software; you can redistribute it and/or modify | ||
7 | * it under the terms of the GNU General Public License version 2 only, | ||
8 | * as published by the Free Software Foundation. | ||
9 | * | ||
10 | * This program is distributed in the hope that it will be useful, but | ||
11 | * WITHOUT ANY WARRANTY; without even the implied warranty of | ||
12 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
13 | * General Public License version 2 for more details (a copy is included | ||
14 | * in the LICENSE file that accompanied this code). | ||
15 | * | ||
16 | * You should have received a copy of the GNU General Public License | ||
17 | * version 2 along with this program; If not, see | ||
18 | * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf | ||
19 | * | ||
20 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, | ||
21 | * CA 95054 USA or visit www.sun.com if you need additional information or | ||
22 | * have any questions. | ||
23 | * | ||
24 | * GPL HEADER END | ||
25 | */ | ||
26 | /* | ||
27 | * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved. | ||
28 | * Use is subject to license terms. | ||
29 | */ | ||
30 | /* | ||
31 | * This file is part of Lustre, http://www.lustre.org/ | ||
32 | * Lustre is a trademark of Sun Microsystems, Inc. | ||
33 | */ | ||
34 | |||
35 | #ifndef _LINUX_LUSTRE_DEBUG_H | ||
36 | #define _LINUX_LUSTRE_DEBUG_H | ||
37 | |||
38 | #ifndef _LUSTRE_DEBUG_H | ||
39 | #error Do not #include this file directly. #include <lprocfs_status.h> instead | ||
40 | #endif | ||
41 | |||
42 | #define LL_CDEBUG_PAGE(mask, page, fmt, arg...) \ | ||
43 | CDEBUG(mask, "page %p map %p index %lu flags %lx count %u priv %0lx: "\ | ||
44 | fmt, page, page->mapping, page->index, (long)page->flags, \ | ||
45 | page_count(page), page_private(page), ## arg) | ||
46 | |||
47 | #endif | ||
diff --git a/drivers/staging/lustre/lustre/include/lustre_debug.h b/drivers/staging/lustre/lustre/include/lustre_debug.h index e789b68a1b3d..7ec91edd6800 100644 --- a/drivers/staging/lustre/lustre/include/lustre_debug.h +++ b/drivers/staging/lustre/lustre/include/lustre_debug.h | |||
@@ -45,8 +45,6 @@ | |||
45 | #include <lustre_net.h> | 45 | #include <lustre_net.h> |
46 | #include <obd.h> | 46 | #include <obd.h> |
47 | 47 | ||
48 | #include <linux/lustre_debug.h> | ||
49 | |||
50 | /* lib/debug.c */ | 48 | /* lib/debug.c */ |
51 | void dump_lniobuf(struct niobuf_local *lnb); | 49 | void dump_lniobuf(struct niobuf_local *lnb); |
52 | int dump_req(struct ptlrpc_request *req); | 50 | int dump_req(struct ptlrpc_request *req); |
diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c b/drivers/staging/lustre/lustre/llite/vvp_io.c index f69e3aa98022..93cbfbb7e7f7 100644 --- a/drivers/staging/lustre/lustre/llite/vvp_io.c +++ b/drivers/staging/lustre/lustre/llite/vvp_io.c | |||
@@ -628,8 +628,11 @@ static int vvp_io_kernel_fault(struct vvp_fault_io *cfio) | |||
628 | cfio->fault.ft_flags = filemap_fault(cfio->ft_vma, vmf); | 628 | cfio->fault.ft_flags = filemap_fault(cfio->ft_vma, vmf); |
629 | 629 | ||
630 | if (vmf->page) { | 630 | if (vmf->page) { |
631 | LL_CDEBUG_PAGE(D_PAGE, vmf->page, "got addr %p type NOPAGE\n", | 631 | CDEBUG(D_PAGE, |
632 | vmf->virtual_address); | 632 | "page %p map %p index %lu flags %lx count %u priv %0lx: got addr %p type NOPAGE\n", |
633 | vmf->page, vmf->page->mapping, vmf->page->index, | ||
634 | (long)vmf->page->flags, page_count(vmf->page), | ||
635 | page_private(vmf->page), vmf->virtual_address); | ||
633 | if (unlikely(!(cfio->fault.ft_flags & VM_FAULT_LOCKED))) { | 636 | if (unlikely(!(cfio->fault.ft_flags & VM_FAULT_LOCKED))) { |
634 | lock_page(vmf->page); | 637 | lock_page(vmf->page); |
635 | cfio->fault.ft_flags &= VM_FAULT_LOCKED; | 638 | cfio->fault.ft_flags &= VM_FAULT_LOCKED; |
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c index c0d9ac6b1bb6..ee6953ac7353 100644 --- a/drivers/staging/lustre/lustre/osc/osc_request.c +++ b/drivers/staging/lustre/lustre/osc/osc_request.c | |||
@@ -1193,8 +1193,12 @@ static obd_count osc_checksum_bulk(int nob, obd_count pg_count, | |||
1193 | cfs_crypto_hash_update_page(hdesc, pga[i]->pg, | 1193 | cfs_crypto_hash_update_page(hdesc, pga[i]->pg, |
1194 | pga[i]->off & ~CFS_PAGE_MASK, | 1194 | pga[i]->off & ~CFS_PAGE_MASK, |
1195 | count); | 1195 | count); |
1196 | LL_CDEBUG_PAGE(D_PAGE, pga[i]->pg, "off %d\n", | 1196 | CDEBUG(D_PAGE, |
1197 | (int)(pga[i]->off & ~CFS_PAGE_MASK)); | 1197 | "page %p map %p index %lu flags %lx count %u priv %0lx: off %d\n", |
1198 | pga[i]->pg, pga[i]->pg->mapping, pga[i]->pg->index, | ||
1199 | (long)pga[i]->pg->flags, page_count(pga[i]->pg), | ||
1200 | page_private(pga[i]->pg), | ||
1201 | (int)(pga[i]->off & ~CFS_PAGE_MASK)); | ||
1198 | 1202 | ||
1199 | nob -= pga[i]->count; | 1203 | nob -= pga[i]->count; |
1200 | pg_count--; | 1204 | pg_count--; |