diff options
author | Felipe Balbi <balbi@ti.com> | 2012-08-07 07:00:50 -0400 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2012-08-07 07:00:50 -0400 |
commit | a156544bc90e82d61bd7c25e6258e4da32256bea (patch) | |
tree | 2fd9a82f1b1b7c2ad9c74f2d17b48affc8ed90c4 | |
parent | f039df580a518df49abff35fec970268bc3c51e3 (diff) |
usb: musb: fix sparse warnings
The following warnings are fixed:
drivers/usb/musb/musb_core.c:357:6: warning: symbol 'musb_otg_timer_func' was not declared. Should it be static?
drivers/usb/musb/musb_core.c:1339:27: warning: incorrect type in initializer (different address spaces)
drivers/usb/musb/musb_core.c:1339:27: expected void *mbase
drivers/usb/musb/musb_core.c:1339:27: got void [noderef] <asn:2>*mregs
drivers/usb/musb/musb_core.c:1347:17: warning: incorrect type in argument 1 (different address spaces)
drivers/usb/musb/musb_core.c:1347:17: expected void [noderef] <asn:2>*addr
drivers/usb/musb/musb_core.c:1347:17: got void *mbase
drivers/usb/musb/musb_core.h:487:27: warning: incorrect type in initializer (different address spaces)
drivers/usb/musb/musb_core.h:487:27: expected void *mbase
drivers/usb/musb/musb_core.h:487:27: got void [noderef] <asn:2>*mregs
drivers/usb/musb/musb_core.h:491:26: warning: incorrect type in argument 1 (different address spaces)
drivers/usb/musb/musb_core.h:491:26: expected void const [noderef] <asn:2>*addr
drivers/usb/musb/musb_core.h:491:26: got void *mbase
drivers/usb/musb/tusb6010.c:270:48: warning: incorrect type in argument 2 (different address spaces)
drivers/usb/musb/tusb6010.c:270:48: expected void [noderef] <asn:2>*buf
drivers/usb/musb/tusb6010.c:270:48: got unsigned char [usertype] *[assigned] buf
drivers/usb/musb/tusb6010.c:164:32: warning: incorrect type in argument 1 (different address spaces)
drivers/usb/musb/tusb6010.c:164:32: expected void *to
drivers/usb/musb/tusb6010.c:164:32: got void [noderef] <asn:2>*buf
drivers/usb/musb/tusb6010.c:172:24: warning: incorrect type in argument 1 (different address spaces)
drivers/usb/musb/tusb6010.c:172:24: expected void *to
drivers/usb/musb/tusb6010.c:172:24: got void [noderef] <asn:2>*[assigned] buf
Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r-- | drivers/usb/musb/musb_core.c | 4 | ||||
-rw-r--r-- | drivers/usb/musb/musb_core.h | 2 | ||||
-rw-r--r-- | drivers/usb/musb/tusb6010.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 69711e43ac6b..9bc4feab4fe0 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c | |||
@@ -354,7 +354,7 @@ void musb_load_testpacket(struct musb *musb) | |||
354 | /* | 354 | /* |
355 | * Handles OTG hnp timeouts, such as b_ase0_brst | 355 | * Handles OTG hnp timeouts, such as b_ase0_brst |
356 | */ | 356 | */ |
357 | void musb_otg_timer_func(unsigned long data) | 357 | static void musb_otg_timer_func(unsigned long data) |
358 | { | 358 | { |
359 | struct musb *musb = (struct musb *)data; | 359 | struct musb *musb = (struct musb *)data; |
360 | unsigned long flags; | 360 | unsigned long flags; |
@@ -1336,7 +1336,7 @@ static int __devinit ep_config_from_hw(struct musb *musb) | |||
1336 | { | 1336 | { |
1337 | u8 epnum = 0; | 1337 | u8 epnum = 0; |
1338 | struct musb_hw_ep *hw_ep; | 1338 | struct musb_hw_ep *hw_ep; |
1339 | void *mbase = musb->mregs; | 1339 | void __iomem *mbase = musb->mregs; |
1340 | int ret = 0; | 1340 | int ret = 0; |
1341 | 1341 | ||
1342 | dev_dbg(musb->controller, "<== static silicon ep config\n"); | 1342 | dev_dbg(musb->controller, "<== static silicon ep config\n"); |
diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index 586105b55a7c..8bb324dddd17 100644 --- a/drivers/usb/musb/musb_core.h +++ b/drivers/usb/musb/musb_core.h | |||
@@ -484,7 +484,7 @@ static inline void musb_configure_ep0(struct musb *musb) | |||
484 | static inline int musb_read_fifosize(struct musb *musb, | 484 | static inline int musb_read_fifosize(struct musb *musb, |
485 | struct musb_hw_ep *hw_ep, u8 epnum) | 485 | struct musb_hw_ep *hw_ep, u8 epnum) |
486 | { | 486 | { |
487 | void *mbase = musb->mregs; | 487 | void __iomem *mbase = musb->mregs; |
488 | u8 reg = 0; | 488 | u8 reg = 0; |
489 | 489 | ||
490 | /* read from core using indexed model */ | 490 | /* read from core using indexed model */ |
diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c index 1a1bd9cf40c5..4073a6fa2633 100644 --- a/drivers/usb/musb/tusb6010.c +++ b/drivers/usb/musb/tusb6010.c | |||
@@ -153,7 +153,7 @@ tusb_fifo_write_unaligned(void __iomem *fifo, const u8 *buf, u16 len) | |||
153 | } | 153 | } |
154 | 154 | ||
155 | static inline void tusb_fifo_read_unaligned(void __iomem *fifo, | 155 | static inline void tusb_fifo_read_unaligned(void __iomem *fifo, |
156 | void __iomem *buf, u16 len) | 156 | void *buf, u16 len) |
157 | { | 157 | { |
158 | u32 val; | 158 | u32 val; |
159 | int i; | 159 | int i; |