diff options
| author | Yong Wang <yong.y.wang@linux.intel.com> | 2010-04-05 09:09:40 -0400 |
|---|---|---|
| committer | Matthew Garrett <mjg@redhat.com> | 2010-04-12 13:10:19 -0400 |
| commit | a0624a90a2bea97e0d65187b4b53ad400226c3f1 (patch) | |
| tree | c16bb7781c18cecc28b2d56beed49e196bbedbda | |
| parent | 3d7b165539d4174b0b8396bd52ee37ba21bd0dfb (diff) | |
dell-wmi: Fix memory leak
The output of wmi_get_event_data shall be freed before return.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Yong Wang <yong.y.wang@linux.intel.com>
| -rw-r--r-- | drivers/platform/x86/dell-wmi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 6ba6c30e5bb6..66f53c3c35e8 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c | |||
| @@ -217,6 +217,7 @@ static void dell_wmi_notify(u32 value, void *context) | |||
| 217 | if (dell_new_hk_type && (buffer_entry[1] != 0x10)) { | 217 | if (dell_new_hk_type && (buffer_entry[1] != 0x10)) { |
| 218 | printk(KERN_INFO "dell-wmi: Received unknown WMI event" | 218 | printk(KERN_INFO "dell-wmi: Received unknown WMI event" |
| 219 | " (0x%x)\n", buffer_entry[1]); | 219 | " (0x%x)\n", buffer_entry[1]); |
| 220 | kfree(obj); | ||
| 220 | return; | 221 | return; |
| 221 | } | 222 | } |
| 222 | 223 | ||
| @@ -234,7 +235,7 @@ static void dell_wmi_notify(u32 value, void *context) | |||
| 234 | key->keycode == KEY_BRIGHTNESSDOWN) && acpi_video) { | 235 | key->keycode == KEY_BRIGHTNESSDOWN) && acpi_video) { |
| 235 | /* Don't report brightness notifications that will also | 236 | /* Don't report brightness notifications that will also |
| 236 | * come via ACPI */ | 237 | * come via ACPI */ |
| 237 | return; | 238 | ; |
| 238 | } else { | 239 | } else { |
| 239 | input_report_key(dell_wmi_input_dev, key->keycode, 1); | 240 | input_report_key(dell_wmi_input_dev, key->keycode, 1); |
| 240 | input_sync(dell_wmi_input_dev); | 241 | input_sync(dell_wmi_input_dev); |
