diff options
| author | Dave Airlie <airlied@redhat.com> | 2013-09-19 19:01:27 -0400 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2013-09-19 19:01:27 -0400 |
| commit | 9808cc946943e4c260ff270f8b2e7884dd6968f8 (patch) | |
| tree | d95e9ee29c9fc4d82a26c1a13a6320866479c337 | |
| parent | 8e1f80c01a4c9e21921cdbfd372196cee0b50c5c (diff) | |
| parent | 662bb6992a505ad41db3c8b52b1e70934507c2e2 (diff) | |
Merge branch 'exynos-drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes
Just small fixes, and code cleanups.
* 'exynos-drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos:
drm/exynos: fix return value check in lowlevel_buffer_allocate()
drm/exynos: Fix address space warnings in exynos_drm_fbdev.c
drm/exynos: Fix address space warning in exynos_drm_buf.c
drm/exynos: Remove redundant OF dependency
| -rw-r--r-- | drivers/gpu/drm/exynos/Kconfig | 2 | ||||
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_buf.c | 7 | ||||
| -rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 5 |
3 files changed, 8 insertions, 6 deletions
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 4752f223e5b2..45b6ef595965 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig | |||
| @@ -56,7 +56,7 @@ config DRM_EXYNOS_IPP | |||
| 56 | 56 | ||
| 57 | config DRM_EXYNOS_FIMC | 57 | config DRM_EXYNOS_FIMC |
| 58 | bool "Exynos DRM FIMC" | 58 | bool "Exynos DRM FIMC" |
| 59 | depends on DRM_EXYNOS_IPP && MFD_SYSCON && OF | 59 | depends on DRM_EXYNOS_IPP && MFD_SYSCON |
| 60 | help | 60 | help |
| 61 | Choose this option if you want to use Exynos FIMC for DRM. | 61 | Choose this option if you want to use Exynos FIMC for DRM. |
| 62 | 62 | ||
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index 3445a0f3a6b2..9c8088462c26 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c | |||
| @@ -63,7 +63,8 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, | |||
| 63 | return -ENOMEM; | 63 | return -ENOMEM; |
| 64 | } | 64 | } |
| 65 | 65 | ||
| 66 | buf->kvaddr = dma_alloc_attrs(dev->dev, buf->size, | 66 | buf->kvaddr = (void __iomem *)dma_alloc_attrs(dev->dev, |
| 67 | buf->size, | ||
| 67 | &buf->dma_addr, GFP_KERNEL, | 68 | &buf->dma_addr, GFP_KERNEL, |
| 68 | &buf->dma_attrs); | 69 | &buf->dma_attrs); |
| 69 | if (!buf->kvaddr) { | 70 | if (!buf->kvaddr) { |
| @@ -90,9 +91,9 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, | |||
| 90 | } | 91 | } |
| 91 | 92 | ||
| 92 | buf->sgt = drm_prime_pages_to_sg(buf->pages, nr_pages); | 93 | buf->sgt = drm_prime_pages_to_sg(buf->pages, nr_pages); |
| 93 | if (!buf->sgt) { | 94 | if (IS_ERR(buf->sgt)) { |
| 94 | DRM_ERROR("failed to get sg table.\n"); | 95 | DRM_ERROR("failed to get sg table.\n"); |
| 95 | ret = -ENOMEM; | 96 | ret = PTR_ERR(buf->sgt); |
| 96 | goto err_free_attrs; | 97 | goto err_free_attrs; |
| 97 | } | 98 | } |
| 98 | 99 | ||
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 78e868bcf1ec..e7c2f2d07f19 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c | |||
| @@ -99,12 +99,13 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, | |||
| 99 | if (is_drm_iommu_supported(dev)) { | 99 | if (is_drm_iommu_supported(dev)) { |
| 100 | unsigned int nr_pages = buffer->size >> PAGE_SHIFT; | 100 | unsigned int nr_pages = buffer->size >> PAGE_SHIFT; |
| 101 | 101 | ||
| 102 | buffer->kvaddr = vmap(buffer->pages, nr_pages, VM_MAP, | 102 | buffer->kvaddr = (void __iomem *) vmap(buffer->pages, |
| 103 | nr_pages, VM_MAP, | ||
| 103 | pgprot_writecombine(PAGE_KERNEL)); | 104 | pgprot_writecombine(PAGE_KERNEL)); |
| 104 | } else { | 105 | } else { |
| 105 | phys_addr_t dma_addr = buffer->dma_addr; | 106 | phys_addr_t dma_addr = buffer->dma_addr; |
| 106 | if (dma_addr) | 107 | if (dma_addr) |
| 107 | buffer->kvaddr = phys_to_virt(dma_addr); | 108 | buffer->kvaddr = (void __iomem *)phys_to_virt(dma_addr); |
| 108 | else | 109 | else |
| 109 | buffer->kvaddr = (void __iomem *)NULL; | 110 | buffer->kvaddr = (void __iomem *)NULL; |
| 110 | } | 111 | } |
