aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Ellerman <mpe@ellerman.id.au>2014-05-23 04:15:26 -0400
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2014-05-27 23:35:35 -0400
commit8d6f7c5aa3db6f3e5e43d09f8a0166c7d96f33f3 (patch)
treeabde7ff85f8eb47d7c028228101c0fd3880bb0fa
parent441c19c8a290f5f1e1b263691641124c84232b6e (diff)
powerpc/powernv: Make it possible to skip the IRQHAPPENED check in power7_nap()
To support split core we need to be able to force all secondaries into nap, so the core can detect they are idle and do an unsplit. Currently power7_nap() will return without napping if there is an irq pending. We want to ignore the pending irq and nap anyway, we will deal with the interrupt later. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--arch/powerpc/include/asm/processor.h2
-rw-r--r--arch/powerpc/kernel/idle_power7.S9
-rw-r--r--arch/powerpc/platforms/powernv/smp.c2
3 files changed, 11 insertions, 2 deletions
diff --git a/arch/powerpc/include/asm/processor.h b/arch/powerpc/include/asm/processor.h
index d660dc36831a..6d59072e13a7 100644
--- a/arch/powerpc/include/asm/processor.h
+++ b/arch/powerpc/include/asm/processor.h
@@ -449,7 +449,7 @@ extern unsigned long cpuidle_disable;
449enum idle_boot_override {IDLE_NO_OVERRIDE = 0, IDLE_POWERSAVE_OFF}; 449enum idle_boot_override {IDLE_NO_OVERRIDE = 0, IDLE_POWERSAVE_OFF};
450 450
451extern int powersave_nap; /* set if nap mode can be used in idle loop */ 451extern int powersave_nap; /* set if nap mode can be used in idle loop */
452extern void power7_nap(void); 452extern void power7_nap(int check_irq);
453extern void power7_sleep(void); 453extern void power7_sleep(void);
454extern void flush_instruction_cache(void); 454extern void flush_instruction_cache(void);
455extern void hard_reset_now(void); 455extern void hard_reset_now(void);
diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
index dca6e16c2436..2480256272d4 100644
--- a/arch/powerpc/kernel/idle_power7.S
+++ b/arch/powerpc/kernel/idle_power7.S
@@ -39,6 +39,10 @@
39 * Pass requested state in r3: 39 * Pass requested state in r3:
40 * 0 - nap 40 * 0 - nap
41 * 1 - sleep 41 * 1 - sleep
42 *
43 * To check IRQ_HAPPENED in r4
44 * 0 - don't check
45 * 1 - check
42 */ 46 */
43_GLOBAL(power7_powersave_common) 47_GLOBAL(power7_powersave_common)
44 /* Use r3 to pass state nap/sleep/winkle */ 48 /* Use r3 to pass state nap/sleep/winkle */
@@ -71,6 +75,8 @@ _GLOBAL(power7_powersave_common)
71 lbz r0,PACAIRQHAPPENED(r13) 75 lbz r0,PACAIRQHAPPENED(r13)
72 cmpwi cr0,r0,0 76 cmpwi cr0,r0,0
73 beq 1f 77 beq 1f
78 cmpwi cr0,r4,0
79 beq 1f
74 addi r1,r1,INT_FRAME_SIZE 80 addi r1,r1,INT_FRAME_SIZE
75 ld r0,16(r1) 81 ld r0,16(r1)
76 mtlr r0 82 mtlr r0
@@ -114,15 +120,18 @@ _GLOBAL(power7_idle)
114 lwz r4,ADDROFF(powersave_nap)(r3) 120 lwz r4,ADDROFF(powersave_nap)(r3)
115 cmpwi 0,r4,0 121 cmpwi 0,r4,0
116 beqlr 122 beqlr
123 li r3, 1
117 /* fall through */ 124 /* fall through */
118 125
119_GLOBAL(power7_nap) 126_GLOBAL(power7_nap)
127 mr r4,r3
120 li r3,0 128 li r3,0
121 b power7_powersave_common 129 b power7_powersave_common
122 /* No return */ 130 /* No return */
123 131
124_GLOBAL(power7_sleep) 132_GLOBAL(power7_sleep)
125 li r3,1 133 li r3,1
134 li r4,0
126 b power7_powersave_common 135 b power7_powersave_common
127 /* No return */ 136 /* No return */
128 137
diff --git a/arch/powerpc/platforms/powernv/smp.c b/arch/powerpc/platforms/powernv/smp.c
index 1601a1ea02c4..65faf998fe2c 100644
--- a/arch/powerpc/platforms/powernv/smp.c
+++ b/arch/powerpc/platforms/powernv/smp.c
@@ -159,7 +159,7 @@ static void pnv_smp_cpu_kill_self(void)
159 mtspr(SPRN_LPCR, mfspr(SPRN_LPCR) & ~(u64)LPCR_PECE1); 159 mtspr(SPRN_LPCR, mfspr(SPRN_LPCR) & ~(u64)LPCR_PECE1);
160 while (!generic_check_cpu_restart(cpu)) { 160 while (!generic_check_cpu_restart(cpu)) {
161 ppc64_runlatch_off(); 161 ppc64_runlatch_off();
162 power7_nap(); 162 power7_nap(1);
163 ppc64_runlatch_on(); 163 ppc64_runlatch_on();
164 if (!generic_check_cpu_restart(cpu)) { 164 if (!generic_check_cpu_restart(cpu)) {
165 DBG("CPU%d Unexpected exit while offline !\n", cpu); 165 DBG("CPU%d Unexpected exit while offline !\n", cpu);