diff options
author | Koul, Vinod <vinod.koul@intel.com> | 2010-10-04 06:38:25 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2010-10-07 18:03:43 -0400 |
commit | 8b6492231d2a92352a6371eebd622e3bc824a663 (patch) | |
tree | 875a69042151b5c317a9dc4b89a63bbbfbd5c834 | |
parent | 576e3c394a6c427c9a1378ec88ef7eb97e731992 (diff) |
intel_mid_dma: fix the WARN_ONs
Moved the WARN_ON to BUG_ON, as WARN_ON if hit,
can cause null pointer derefrences
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/dma/intel_mid_dma.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c index 2ae1086b9481..ef7ffb813fe9 100644 --- a/drivers/dma/intel_mid_dma.c +++ b/drivers/dma/intel_mid_dma.c | |||
@@ -581,15 +581,15 @@ static struct dma_async_tx_descriptor *intel_mid_dma_prep_memcpy( | |||
581 | enum intel_mid_dma_width width = 0; | 581 | enum intel_mid_dma_width width = 0; |
582 | 582 | ||
583 | pr_debug("MDMA: Prep for memcpy\n"); | 583 | pr_debug("MDMA: Prep for memcpy\n"); |
584 | WARN_ON(!chan); | 584 | BUG_ON(!chan); |
585 | if (!len) | 585 | if (!len) |
586 | return NULL; | 586 | return NULL; |
587 | 587 | ||
588 | mids = chan->private; | 588 | mids = chan->private; |
589 | WARN_ON(!mids); | 589 | BUG_ON(!mids); |
590 | 590 | ||
591 | midc = to_intel_mid_dma_chan(chan); | 591 | midc = to_intel_mid_dma_chan(chan); |
592 | WARN_ON(!midc); | 592 | BUG_ON(!midc); |
593 | 593 | ||
594 | pr_debug("MDMA:called for DMA %x CH %d Length %zu\n", | 594 | pr_debug("MDMA:called for DMA %x CH %d Length %zu\n", |
595 | midc->dma->pci_id, midc->ch_id, len); | 595 | midc->dma->pci_id, midc->ch_id, len); |