diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2012-05-07 13:59:49 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2012-05-08 06:35:06 -0400 |
commit | 85f7f656274fa0ba109dd8774db3887d42de5c6b (patch) | |
tree | d5ec3ed47c86a00ee198d988afc059ebb4d38c42 | |
parent | 4a1625133d4faaefcec0dc175941f49b186918d9 (diff) |
x86: Use kick_all_cpus_sync()
Use kick_all_cpus_sync() and remove cpu_idle_wait().
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120507175652.190382227@linutronix.de
Cc: x86@kernel.org
-rw-r--r-- | arch/x86/Kconfig | 3 | ||||
-rw-r--r-- | arch/x86/include/asm/processor.h | 2 | ||||
-rw-r--r-- | arch/x86/kernel/apm_32.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/process.c | 20 |
4 files changed, 1 insertions, 26 deletions
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 046bf4bd2510..98876f55a2e0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig | |||
@@ -161,9 +161,6 @@ config RWSEM_GENERIC_SPINLOCK | |||
161 | config RWSEM_XCHGADD_ALGORITHM | 161 | config RWSEM_XCHGADD_ALGORITHM |
162 | def_bool X86_XADD | 162 | def_bool X86_XADD |
163 | 163 | ||
164 | config ARCH_HAS_CPU_IDLE_WAIT | ||
165 | def_bool y | ||
166 | |||
167 | config GENERIC_CALIBRATE_DELAY | 164 | config GENERIC_CALIBRATE_DELAY |
168 | def_bool y | 165 | def_bool y |
169 | 166 | ||
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 4fa7dcceb6c0..ccbb1ea99ccb 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h | |||
@@ -974,8 +974,6 @@ extern bool cpu_has_amd_erratum(const int *); | |||
974 | #define cpu_has_amd_erratum(x) (false) | 974 | #define cpu_has_amd_erratum(x) (false) |
975 | #endif /* CONFIG_CPU_SUP_AMD */ | 975 | #endif /* CONFIG_CPU_SUP_AMD */ |
976 | 976 | ||
977 | void cpu_idle_wait(void); | ||
978 | |||
979 | extern unsigned long arch_align_stack(unsigned long sp); | 977 | extern unsigned long arch_align_stack(unsigned long sp); |
980 | extern void free_init_pages(char *what, unsigned long begin, unsigned long end); | 978 | extern void free_init_pages(char *what, unsigned long begin, unsigned long end); |
981 | 979 | ||
diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c index 459e78cbf61e..07b0c0db466c 100644 --- a/arch/x86/kernel/apm_32.c +++ b/arch/x86/kernel/apm_32.c | |||
@@ -2401,7 +2401,7 @@ static void __exit apm_exit(void) | |||
2401 | * (pm_idle), Wait for all processors to update cached/local | 2401 | * (pm_idle), Wait for all processors to update cached/local |
2402 | * copies of pm_idle before proceeding. | 2402 | * copies of pm_idle before proceeding. |
2403 | */ | 2403 | */ |
2404 | cpu_idle_wait(); | 2404 | kick_all_cpus_sync(); |
2405 | } | 2405 | } |
2406 | if (((apm_info.bios.flags & APM_BIOS_DISENGAGED) == 0) | 2406 | if (((apm_info.bios.flags & APM_BIOS_DISENGAGED) == 0) |
2407 | && (apm_info.connection_version > 0x0100)) { | 2407 | && (apm_info.connection_version > 0x0100)) { |
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 8aa532fa015d..8215458f6af5 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c | |||
@@ -525,26 +525,6 @@ void stop_this_cpu(void *dummy) | |||
525 | } | 525 | } |
526 | } | 526 | } |
527 | 527 | ||
528 | static void do_nothing(void *unused) | ||
529 | { | ||
530 | } | ||
531 | |||
532 | /* | ||
533 | * cpu_idle_wait - Used to ensure that all the CPUs discard old value of | ||
534 | * pm_idle and update to new pm_idle value. Required while changing pm_idle | ||
535 | * handler on SMP systems. | ||
536 | * | ||
537 | * Caller must have changed pm_idle to the new value before the call. Old | ||
538 | * pm_idle value will not be used by any CPU after the return of this function. | ||
539 | */ | ||
540 | void cpu_idle_wait(void) | ||
541 | { | ||
542 | smp_mb(); | ||
543 | /* kick all the CPUs so that they exit out of pm_idle */ | ||
544 | smp_call_function(do_nothing, NULL, 1); | ||
545 | } | ||
546 | EXPORT_SYMBOL_GPL(cpu_idle_wait); | ||
547 | |||
548 | /* Default MONITOR/MWAIT with no hints, used for default C1 state */ | 528 | /* Default MONITOR/MWAIT with no hints, used for default C1 state */ |
549 | static void mwait_idle(void) | 529 | static void mwait_idle(void) |
550 | { | 530 | { |