aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Lendacky <thomas.lendacky@amd.com>2014-01-06 14:34:23 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2014-01-14 22:33:40 -0500
commit82d1585b9a9d5106ec6a630696f3e2e532fc3cba (patch)
tree7d9afd48c678884bb88f98168098ea53aee57936
parent81a59f000e1d4a60a03081a1fc64aee46d6f0c3e (diff)
crypto: ccp - Cleanup hash invocation calls
Cleanup the ahash digest invocations to check the init return code and make use of the finup routine. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/ccp/ccp-crypto-aes-cmac.c2
-rw-r--r--drivers/crypto/ccp/ccp-crypto-sha.c8
2 files changed, 7 insertions, 3 deletions
diff --git a/drivers/crypto/ccp/ccp-crypto-aes-cmac.c b/drivers/crypto/ccp/ccp-crypto-aes-cmac.c
index a52b97a4c843..8e162ad82085 100644
--- a/drivers/crypto/ccp/ccp-crypto-aes-cmac.c
+++ b/drivers/crypto/ccp/ccp-crypto-aes-cmac.c
@@ -198,7 +198,7 @@ static int ccp_aes_cmac_digest(struct ahash_request *req)
198 if (ret) 198 if (ret)
199 return ret; 199 return ret;
200 200
201 return ccp_do_cmac_update(req, req->nbytes, 1); 201 return ccp_aes_cmac_finup(req);
202} 202}
203 203
204static int ccp_aes_cmac_setkey(struct crypto_ahash *tfm, const u8 *key, 204static int ccp_aes_cmac_setkey(struct crypto_ahash *tfm, const u8 *key,
diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c b/drivers/crypto/ccp/ccp-crypto-sha.c
index d30f6c893ffb..3867290b3531 100644
--- a/drivers/crypto/ccp/ccp-crypto-sha.c
+++ b/drivers/crypto/ccp/ccp-crypto-sha.c
@@ -248,9 +248,13 @@ static int ccp_sha_finup(struct ahash_request *req)
248 248
249static int ccp_sha_digest(struct ahash_request *req) 249static int ccp_sha_digest(struct ahash_request *req)
250{ 250{
251 ccp_sha_init(req); 251 int ret;
252 252
253 return ccp_do_sha_update(req, req->nbytes, 1); 253 ret = ccp_sha_init(req);
254 if (ret)
255 return ret;
256
257 return ccp_sha_finup(req);
254} 258}
255 259
256static int ccp_sha_setkey(struct crypto_ahash *tfm, const u8 *key, 260static int ccp_sha_setkey(struct crypto_ahash *tfm, const u8 *key,