aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVille Syrjälä <ville.syrjala@linux.intel.com>2015-03-27 09:51:56 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2015-03-27 11:08:34 -0400
commit7e7392a6e854a29016377b87bebe5ae263f65e5c (patch)
tree4161151f4357a715cfc9d6ef254c97398d54ca31
parent9c7d3d3e289c9870ae688780a0f9807bb5ae9faf (diff)
drm: Drop ioctl->cmd_drv
ioctl->cmd_drv is pointless and we can just as well stick the full ioctl definition into ioctl->cmd. Cc: Jakob Bornecrantz <jakob@vmware.com> Cc: Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/drm_ioctl.c6
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_drv.c4
-rw-r--r--include/drm/drmP.h3
3 files changed, 6 insertions, 7 deletions
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index a6d773a61c2d..fc0cf4a84011 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -525,7 +525,7 @@ static int drm_ioctl_permit(u32 flags, struct drm_file *file_priv)
525} 525}
526 526
527#define DRM_IOCTL_DEF(ioctl, _func, _flags) \ 527#define DRM_IOCTL_DEF(ioctl, _func, _flags) \
528 [DRM_IOCTL_NR(ioctl)] = {.cmd = ioctl, .func = _func, .flags = _flags, .cmd_drv = 0, .name = #ioctl} 528 [DRM_IOCTL_NR(ioctl)] = {.cmd = ioctl, .func = _func, .flags = _flags, .name = #ioctl}
529 529
530/** Ioctl table */ 530/** Ioctl table */
531static const struct drm_ioctl_desc drm_ioctls[] = { 531static const struct drm_ioctl_desc drm_ioctls[] = {
@@ -677,11 +677,11 @@ long drm_ioctl(struct file *filp,
677 (nr < DRM_COMMAND_BASE + dev->driver->num_ioctls)) { 677 (nr < DRM_COMMAND_BASE + dev->driver->num_ioctls)) {
678 u32 drv_size; 678 u32 drv_size;
679 ioctl = &dev->driver->ioctls[nr - DRM_COMMAND_BASE]; 679 ioctl = &dev->driver->ioctls[nr - DRM_COMMAND_BASE];
680 drv_size = _IOC_SIZE(ioctl->cmd_drv); 680 drv_size = _IOC_SIZE(ioctl->cmd);
681 usize = asize = _IOC_SIZE(cmd); 681 usize = asize = _IOC_SIZE(cmd);
682 if (drv_size > asize) 682 if (drv_size > asize)
683 asize = drv_size; 683 asize = drv_size;
684 cmd = ioctl->cmd_drv; 684 cmd = ioctl->cmd;
685 } 685 }
686 else if ((nr >= DRM_COMMAND_END) || (nr < DRM_COMMAND_BASE)) { 686 else if ((nr >= DRM_COMMAND_END) || (nr < DRM_COMMAND_BASE)) {
687 u32 drv_size; 687 u32 drv_size;
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
index 6c6b655defcf..761b2a767ce0 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
@@ -134,7 +134,7 @@
134 */ 134 */
135 135
136#define VMW_IOCTL_DEF(ioctl, func, flags) \ 136#define VMW_IOCTL_DEF(ioctl, func, flags) \
137 [DRM_IOCTL_NR(DRM_IOCTL_##ioctl) - DRM_COMMAND_BASE] = {DRM_##ioctl, flags, func, DRM_IOCTL_##ioctl} 137 [DRM_IOCTL_NR(DRM_IOCTL_##ioctl) - DRM_COMMAND_BASE] = {DRM_IOCTL_##ioctl, flags, func}
138 138
139/** 139/**
140 * Ioctl definitions. 140 * Ioctl definitions.
@@ -1041,7 +1041,7 @@ static long vmw_generic_ioctl(struct file *filp, unsigned int cmd,
1041 const struct drm_ioctl_desc *ioctl = 1041 const struct drm_ioctl_desc *ioctl =
1042 &vmw_ioctls[nr - DRM_COMMAND_BASE]; 1042 &vmw_ioctls[nr - DRM_COMMAND_BASE];
1043 1043
1044 if (unlikely(ioctl->cmd_drv != cmd)) { 1044 if (unlikely(ioctl->cmd != cmd)) {
1045 DRM_ERROR("Invalid command format, ioctl %d\n", 1045 DRM_ERROR("Invalid command format, ioctl %d\n",
1046 nr - DRM_COMMAND_BASE); 1046 nr - DRM_COMMAND_BASE);
1047 return -EINVAL; 1047 return -EINVAL;
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 6195ee9b4c2a..0d501ed20775 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -253,7 +253,6 @@ struct drm_ioctl_desc {
253 unsigned int cmd; 253 unsigned int cmd;
254 int flags; 254 int flags;
255 drm_ioctl_t *func; 255 drm_ioctl_t *func;
256 unsigned int cmd_drv;
257 const char *name; 256 const char *name;
258}; 257};
259 258
@@ -263,7 +262,7 @@ struct drm_ioctl_desc {
263 */ 262 */
264 263
265#define DRM_IOCTL_DEF_DRV(ioctl, _func, _flags) \ 264#define DRM_IOCTL_DEF_DRV(ioctl, _func, _flags) \
266 [DRM_IOCTL_NR(DRM_IOCTL_##ioctl) - DRM_COMMAND_BASE] = {.cmd = DRM_##ioctl, .func = _func, .flags = _flags, .cmd_drv = DRM_IOCTL_##ioctl, .name = #ioctl} 265 [DRM_IOCTL_NR(DRM_IOCTL_##ioctl) - DRM_COMMAND_BASE] = {.cmd = DRM_IOCTL_##ioctl, .func = _func, .flags = _flags, .name = #ioctl}
267 266
268/* Event queued up for userspace to read */ 267/* Event queued up for userspace to read */
269struct drm_pending_event { 268struct drm_pending_event {