diff options
| author | Sage Weil <sage@newdream.net> | 2011-11-11 12:48:08 -0500 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2011-11-11 12:50:17 -0500 |
| commit | 774ac21da76f5c3018428725074e27a3fd40b128 (patch) | |
| tree | 3c22879278514494e467e651c918994cd6f359d2 | |
| parent | 15a2015fbc692e1c97d7ce12d96e077f5ae7ea6d (diff) | |
ceph: initialize root dentry
Set up d_fsdata on the root dentry. This fixes a NULL pointer dereference
in ceph_d_prune on umount. It also means we can eventually strip out all
of the conditional checks on d_fsdata because it is now set unconditionally
(prior to setting up the d_ops).
Fix the ceph_d_prune debug print while we're here.
Signed-off-by: Sage Weil <sage@newdream.net>
| -rw-r--r-- | fs/ceph/dir.c | 2 | ||||
| -rw-r--r-- | fs/ceph/super.c | 6 |
2 files changed, 5 insertions, 3 deletions
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 2abd0dfad7f8..bca3948e9dbf 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c | |||
| @@ -1143,7 +1143,7 @@ static void ceph_d_prune(struct dentry *dentry) | |||
| 1143 | { | 1143 | { |
| 1144 | struct ceph_dentry_info *di; | 1144 | struct ceph_dentry_info *di; |
| 1145 | 1145 | ||
| 1146 | dout("d_release %p\n", dentry); | 1146 | dout("ceph_d_prune %p\n", dentry); |
| 1147 | 1147 | ||
| 1148 | /* do we have a valid parent? */ | 1148 | /* do we have a valid parent? */ |
| 1149 | if (!dentry->d_parent || IS_ROOT(dentry)) | 1149 | if (!dentry->d_parent || IS_ROOT(dentry)) |
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index a90846fac759..8dc73a594a90 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c | |||
| @@ -638,10 +638,12 @@ static struct dentry *open_root_dentry(struct ceph_fs_client *fsc, | |||
| 638 | if (err == 0) { | 638 | if (err == 0) { |
| 639 | dout("open_root_inode success\n"); | 639 | dout("open_root_inode success\n"); |
| 640 | if (ceph_ino(req->r_target_inode) == CEPH_INO_ROOT && | 640 | if (ceph_ino(req->r_target_inode) == CEPH_INO_ROOT && |
| 641 | fsc->sb->s_root == NULL) | 641 | fsc->sb->s_root == NULL) { |
| 642 | root = d_alloc_root(req->r_target_inode); | 642 | root = d_alloc_root(req->r_target_inode); |
| 643 | else | 643 | ceph_init_dentry(root); |
| 644 | } else { | ||
| 644 | root = d_obtain_alias(req->r_target_inode); | 645 | root = d_obtain_alias(req->r_target_inode); |
| 646 | } | ||
| 645 | req->r_target_inode = NULL; | 647 | req->r_target_inode = NULL; |
| 646 | dout("open_root_inode success, root dentry is %p\n", root); | 648 | dout("open_root_inode success, root dentry is %p\n", root); |
| 647 | } else { | 649 | } else { |
