diff options
| author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2011-07-28 13:42:21 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-11-03 16:27:55 -0400 |
| commit | 716eba3ec1d8d89acd19617eb0bd85fc9b58497f (patch) | |
| tree | 4ef77bdce41b7fd4571aa310d2f494815f6bb36c | |
| parent | 5e891294f6dd7af617275477946e75d20c5e8136 (diff) | |
[media] V4L: imx074: remove superfluous soc-camera client operations
Now that all soc-camera hosts have been ported to use V4L2 subdevice
mediabus-config operations and soc-camera client bus-parameter operations
have been made optional, they can be removed.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/video/imx074.c | 24 |
1 files changed, 1 insertions, 23 deletions
diff --git a/drivers/media/video/imx074.c b/drivers/media/video/imx074.c index 63f17aa57271..20756e03dbb1 100644 --- a/drivers/media/video/imx074.c +++ b/drivers/media/video/imx074.c | |||
| @@ -298,26 +298,6 @@ static struct v4l2_subdev_ops imx074_subdev_ops = { | |||
| 298 | .video = &imx074_subdev_video_ops, | 298 | .video = &imx074_subdev_video_ops, |
| 299 | }; | 299 | }; |
| 300 | 300 | ||
| 301 | /* | ||
| 302 | * We have to provide soc-camera operations, but we don't have anything to say | ||
| 303 | * there. The MIPI CSI2 driver will provide .query_bus_param and .set_bus_param | ||
| 304 | */ | ||
| 305 | static unsigned long imx074_query_bus_param(struct soc_camera_device *icd) | ||
| 306 | { | ||
| 307 | return 0; | ||
| 308 | } | ||
| 309 | |||
| 310 | static int imx074_set_bus_param(struct soc_camera_device *icd, | ||
| 311 | unsigned long flags) | ||
| 312 | { | ||
| 313 | return -EINVAL; | ||
| 314 | } | ||
| 315 | |||
| 316 | static struct soc_camera_ops imx074_ops = { | ||
| 317 | .query_bus_param = imx074_query_bus_param, | ||
| 318 | .set_bus_param = imx074_set_bus_param, | ||
| 319 | }; | ||
| 320 | |||
| 321 | static int imx074_video_probe(struct soc_camera_device *icd, | 301 | static int imx074_video_probe(struct soc_camera_device *icd, |
| 322 | struct i2c_client *client) | 302 | struct i2c_client *client) |
| 323 | { | 303 | { |
| @@ -457,12 +437,11 @@ static int imx074_probe(struct i2c_client *client, | |||
| 457 | 437 | ||
| 458 | v4l2_i2c_subdev_init(&priv->subdev, client, &imx074_subdev_ops); | 438 | v4l2_i2c_subdev_init(&priv->subdev, client, &imx074_subdev_ops); |
| 459 | 439 | ||
| 460 | icd->ops = &imx074_ops; | 440 | icd->ops = NULL; |
| 461 | priv->fmt = &imx074_colour_fmts[0]; | 441 | priv->fmt = &imx074_colour_fmts[0]; |
| 462 | 442 | ||
| 463 | ret = imx074_video_probe(icd, client); | 443 | ret = imx074_video_probe(icd, client); |
| 464 | if (ret < 0) { | 444 | if (ret < 0) { |
| 465 | icd->ops = NULL; | ||
| 466 | kfree(priv); | 445 | kfree(priv); |
| 467 | return ret; | 446 | return ret; |
| 468 | } | 447 | } |
| @@ -476,7 +455,6 @@ static int imx074_remove(struct i2c_client *client) | |||
| 476 | struct soc_camera_device *icd = client->dev.platform_data; | 455 | struct soc_camera_device *icd = client->dev.platform_data; |
| 477 | struct soc_camera_link *icl = to_soc_camera_link(icd); | 456 | struct soc_camera_link *icl = to_soc_camera_link(icd); |
| 478 | 457 | ||
| 479 | icd->ops = NULL; | ||
| 480 | if (icl->free_bus) | 458 | if (icl->free_bus) |
| 481 | icl->free_bus(icl); | 459 | icl->free_bus(icl); |
| 482 | kfree(priv); | 460 | kfree(priv); |
