aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjørn Erik Nilsen <ben@datarespons.no>2013-11-29 08:35:25 -0500
committerBjorn Helgaas <bhelgaas@google.com>2013-12-09 17:11:14 -0500
commit64989e7399f09b72689e25fb40f2d0d5e073b13a (patch)
tree3f76a3e3d8a3dbeb5aa6a1a2886ca2d0b1136574
parentbe3f48cb21c1ca4907a0822eea406c8dd4a73ddb (diff)
PCI: designware: Remove redundant call to pci_write_config_word()
write_msi_msg() does exactly the same so there is no need to explicitly call pci_write_config_word() and do the same twice. Tested-by: Mohit Kumar <mohit.kumar@st.com> Signed-off-by: Bjørn Erik Nilsen <ben@datarespons.no> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Marek Vasut <marex@denx.de> Acked-by: Jingoo Han <jg1.han@samsung.com>
-rw-r--r--drivers/pci/host/pcie-designware.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 61345a18a6d1..5274085ecd4b 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -345,10 +345,10 @@ static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev,
345 if (irq < 0) 345 if (irq < 0)
346 return irq; 346 return irq;
347 347
348 msg_ctr &= ~PCI_MSI_FLAGS_QSIZE; 348 /*
349 msg_ctr |= msgvec << 4; 349 * write_msi_msg() will update PCI_MSI_FLAGS so there is
350 pci_write_config_word(pdev, desc->msi_attrib.pos + PCI_MSI_FLAGS, 350 * no need to explicitly call pci_write_config_word().
351 msg_ctr); 351 */
352 desc->msi_attrib.multiple = msgvec; 352 desc->msi_attrib.multiple = msgvec;
353 353
354 msg.address_lo = virt_to_phys((void *)pp->msi_data); 354 msg.address_lo = virt_to_phys((void *)pp->msi_data);