diff options
author | Wei Liu <wei.liu2@citrix.com> | 2014-08-12 06:59:30 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-08-13 23:06:43 -0400 |
commit | 628fa76b09d7b0923c142631fc25b6affbfb868d (patch) | |
tree | 1c738b4350f79c4f65f1a2441a857b88eb8ccb7b | |
parent | 5c807005fa60deef2db6616d9b7b24fc4c436be9 (diff) |
xen-netback: fix debugfs entry creation
The original code is bogus. The function gets called in a loop which
leaks entries created in previous rounds.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/xen-netback/xenbus.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 4c9041e60e7d..9c47b897b6d2 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c | |||
@@ -174,10 +174,9 @@ static const struct file_operations xenvif_dbg_io_ring_ops_fops = { | |||
174 | .write = xenvif_write_io_ring, | 174 | .write = xenvif_write_io_ring, |
175 | }; | 175 | }; |
176 | 176 | ||
177 | static void xenvif_debugfs_addif(struct xenvif_queue *queue) | 177 | static void xenvif_debugfs_addif(struct xenvif *vif) |
178 | { | 178 | { |
179 | struct dentry *pfile; | 179 | struct dentry *pfile; |
180 | struct xenvif *vif = queue->vif; | ||
181 | int i; | 180 | int i; |
182 | 181 | ||
183 | if (IS_ERR_OR_NULL(xen_netback_dbg_root)) | 182 | if (IS_ERR_OR_NULL(xen_netback_dbg_root)) |
@@ -736,10 +735,11 @@ static void connect(struct backend_info *be) | |||
736 | be->vif->num_queues = queue_index; | 735 | be->vif->num_queues = queue_index; |
737 | goto err; | 736 | goto err; |
738 | } | 737 | } |
738 | } | ||
739 | |||
739 | #ifdef CONFIG_DEBUG_FS | 740 | #ifdef CONFIG_DEBUG_FS |
740 | xenvif_debugfs_addif(queue); | 741 | xenvif_debugfs_addif(be->vif); |
741 | #endif /* CONFIG_DEBUG_FS */ | 742 | #endif /* CONFIG_DEBUG_FS */ |
742 | } | ||
743 | 743 | ||
744 | /* Initialisation completed, tell core driver the number of | 744 | /* Initialisation completed, tell core driver the number of |
745 | * active queues. | 745 | * active queues. |