diff options
author | Ben Widawsky <benjamin.widawsky@intel.com> | 2013-11-25 12:54:43 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-11-26 04:21:27 -0500 |
commit | 5ed1678206a392ac509cd1f6415df74b9008aa9a (patch) | |
tree | ed843227d77ecbb03607f5b2821252362a3191f7 | |
parent | 5ce097254e71cd727687800bf15ca7af23a6bf08 (diff) |
drm/i915: Move the gtt mm takedown to cleanup
Our VM code already has a cleanup function, and this is a nice place to
put the drm_mm_takedown. This should have no functional impact, it just
leaves the unload function a bit cleaer, and is more logical IMO
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/i915_dma.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem_gtt.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 25acbb5eca6e..5aeb103eae44 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c | |||
@@ -1777,7 +1777,6 @@ int i915_driver_unload(struct drm_device *dev) | |||
1777 | 1777 | ||
1778 | list_del(&dev_priv->gtt.base.global_link); | 1778 | list_del(&dev_priv->gtt.base.global_link); |
1779 | WARN_ON(!list_empty(&dev_priv->vm_list)); | 1779 | WARN_ON(!list_empty(&dev_priv->vm_list)); |
1780 | drm_mm_takedown(&dev_priv->gtt.base.mm); | ||
1781 | 1780 | ||
1782 | drm_vblank_cleanup(dev); | 1781 | drm_vblank_cleanup(dev); |
1783 | 1782 | ||
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index c1d04a36688f..056f1f0e2772 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c | |||
@@ -1411,6 +1411,8 @@ static void gen6_gmch_remove(struct i915_address_space *vm) | |||
1411 | { | 1411 | { |
1412 | 1412 | ||
1413 | struct i915_gtt *gtt = container_of(vm, struct i915_gtt, base); | 1413 | struct i915_gtt *gtt = container_of(vm, struct i915_gtt, base); |
1414 | |||
1415 | drm_mm_takedown(&vm->mm); | ||
1414 | iounmap(gtt->gsm); | 1416 | iounmap(gtt->gsm); |
1415 | teardown_scratch_page(vm->dev); | 1417 | teardown_scratch_page(vm->dev); |
1416 | } | 1418 | } |