aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYadwinder Singh Brar <yadi.brar@samsung.com>2013-06-29 08:51:19 -0400
committerMark Brown <broonie@linaro.org>2013-07-15 06:27:48 -0400
commit5b175952011adae30b531ab89cc24acb173b2ce4 (patch)
tree3d32b5482cb43df0958ca9e93381249c889fe9ee
parent1653ccf4c52df6a4abe8ec2f33f2cb2896d129ea (diff)
regulator: core: Remove redundant checks
In function _regulator_do_set_voltage(), old_selector gets intialised only if (_regulator_is_enabled(rdev) && rdev->desc->ops->set_voltage_time_sel && rdev->desc->ops->get_voltage_sel)) is true. Before calling set_voltage_time_sel() we checks if (old_selector >= 0) and it will true if it got intialised properly. so we don't need to check again _regulator_is_enabled(rdev) && rdev->desc->ops->set_voltage_time_sel before calling set_voltage_time_sel(). Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--drivers/regulator/core.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6e6371c2346c..15368f35bbdf 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2439,9 +2439,8 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
2439 } 2439 }
2440 2440
2441 /* Call set_voltage_time_sel if successfully obtained old_selector */ 2441 /* Call set_voltage_time_sel if successfully obtained old_selector */
2442 if (ret == 0 && !rdev->constraints->ramp_disable && 2442 if (ret == 0 && !rdev->constraints->ramp_disable && old_selector >= 0
2443 _regulator_is_enabled(rdev) && old_selector >= 0 && 2443 && old_selector != selector) {
2444 old_selector != selector && rdev->desc->ops->set_voltage_time_sel) {
2445 2444
2446 delay = rdev->desc->ops->set_voltage_time_sel(rdev, 2445 delay = rdev->desc->ops->set_voltage_time_sel(rdev,
2447 old_selector, selector); 2446 old_selector, selector);