diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2014-03-31 00:09:57 -0400 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-03-31 00:22:43 -0400 |
commit | 57673c2b0baa900dddae3b9eb3d7748ebf550eb3 (patch) | |
tree | 8d485d6427d818f61b4c95945925b6c0235a3f50 | |
parent | 58f86cc89c3372d3e61d5b71e5513ec5a0b02848 (diff) |
Use 'E' instead of 'X' for unsigned module taint flag.
Takashi Iwai <tiwai@suse.de> says:
> The letter 'X' has been already used for SUSE kernels for very long
> time, to indicate the external supported modules. Can the new flag be
> changed to another letter for avoiding conflict...?
> (BTW, we also use 'N' for "no support", too.)
Note: this code should be cleaned up, so we don't have such maps in
three places!
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r-- | Documentation/ABI/testing/sysfs-module | 2 | ||||
-rw-r--r-- | Documentation/module-signing.txt | 2 | ||||
-rw-r--r-- | Documentation/oops-tracing.txt | 2 | ||||
-rw-r--r-- | kernel/module.c | 2 | ||||
-rw-r--r-- | kernel/panic.c | 4 |
5 files changed, 6 insertions, 6 deletions
diff --git a/Documentation/ABI/testing/sysfs-module b/Documentation/ABI/testing/sysfs-module index b9a29cdbaccb..0aac02e7fb0e 100644 --- a/Documentation/ABI/testing/sysfs-module +++ b/Documentation/ABI/testing/sysfs-module | |||
@@ -49,4 +49,4 @@ Description: Module taint flags: | |||
49 | O - out-of-tree module | 49 | O - out-of-tree module |
50 | F - force-loaded module | 50 | F - force-loaded module |
51 | C - staging driver module | 51 | C - staging driver module |
52 | X - unsigned module | 52 | E - unsigned module |
diff --git a/Documentation/module-signing.txt b/Documentation/module-signing.txt index b6af42e4d790..2429024c0749 100644 --- a/Documentation/module-signing.txt +++ b/Documentation/module-signing.txt | |||
@@ -54,7 +54,7 @@ This has a number of options available: | |||
54 | If this is off (ie. "permissive"), then modules for which the key is not | 54 | If this is off (ie. "permissive"), then modules for which the key is not |
55 | available and modules that are unsigned are permitted, but the kernel will | 55 | available and modules that are unsigned are permitted, but the kernel will |
56 | be marked as being tainted, and the concerned modules will be marked as | 56 | be marked as being tainted, and the concerned modules will be marked as |
57 | tainted, shown with the character 'X'. | 57 | tainted, shown with the character 'E'. |
58 | 58 | ||
59 | If this is on (ie. "restrictive"), only modules that have a valid | 59 | If this is on (ie. "restrictive"), only modules that have a valid |
60 | signature that can be verified by a public key in the kernel's possession | 60 | signature that can be verified by a public key in the kernel's possession |
diff --git a/Documentation/oops-tracing.txt b/Documentation/oops-tracing.txt index 879abe289523..e3155995ddd8 100644 --- a/Documentation/oops-tracing.txt +++ b/Documentation/oops-tracing.txt | |||
@@ -265,7 +265,7 @@ characters, each representing a particular tainted value. | |||
265 | 265 | ||
266 | 13: 'O' if an externally-built ("out-of-tree") module has been loaded. | 266 | 13: 'O' if an externally-built ("out-of-tree") module has been loaded. |
267 | 267 | ||
268 | 14: 'X' if an unsigned module has been loaded in a kernel supporting | 268 | 14: 'E' if an unsigned module has been loaded in a kernel supporting |
269 | module signature. | 269 | module signature. |
270 | 270 | ||
271 | The primary reason for the 'Tainted: ' string is to tell kernel | 271 | The primary reason for the 'Tainted: ' string is to tell kernel |
diff --git a/kernel/module.c b/kernel/module.c index c1acb0c5b637..5806e096d110 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -1014,7 +1014,7 @@ static size_t module_flags_taint(struct module *mod, char *buf) | |||
1014 | if (mod->taints & (1 << TAINT_CRAP)) | 1014 | if (mod->taints & (1 << TAINT_CRAP)) |
1015 | buf[l++] = 'C'; | 1015 | buf[l++] = 'C'; |
1016 | if (mod->taints & (1 << TAINT_UNSIGNED_MODULE)) | 1016 | if (mod->taints & (1 << TAINT_UNSIGNED_MODULE)) |
1017 | buf[l++] = 'X'; | 1017 | buf[l++] = 'E'; |
1018 | /* | 1018 | /* |
1019 | * TAINT_FORCED_RMMOD: could be added. | 1019 | * TAINT_FORCED_RMMOD: could be added. |
1020 | * TAINT_UNSAFE_SMP, TAINT_MACHINE_CHECK, TAINT_BAD_PAGE don't | 1020 | * TAINT_UNSAFE_SMP, TAINT_MACHINE_CHECK, TAINT_BAD_PAGE don't |
diff --git a/kernel/panic.c b/kernel/panic.c index 0e25fe10871e..02b6c9f0171b 100644 --- a/kernel/panic.c +++ b/kernel/panic.c | |||
@@ -210,7 +210,7 @@ static const struct tnt tnts[] = { | |||
210 | { TAINT_CRAP, 'C', ' ' }, | 210 | { TAINT_CRAP, 'C', ' ' }, |
211 | { TAINT_FIRMWARE_WORKAROUND, 'I', ' ' }, | 211 | { TAINT_FIRMWARE_WORKAROUND, 'I', ' ' }, |
212 | { TAINT_OOT_MODULE, 'O', ' ' }, | 212 | { TAINT_OOT_MODULE, 'O', ' ' }, |
213 | { TAINT_UNSIGNED_MODULE, 'X', ' ' }, | 213 | { TAINT_UNSIGNED_MODULE, 'E', ' ' }, |
214 | }; | 214 | }; |
215 | 215 | ||
216 | /** | 216 | /** |
@@ -229,7 +229,7 @@ static const struct tnt tnts[] = { | |||
229 | * 'C' - modules from drivers/staging are loaded. | 229 | * 'C' - modules from drivers/staging are loaded. |
230 | * 'I' - Working around severe firmware bug. | 230 | * 'I' - Working around severe firmware bug. |
231 | * 'O' - Out-of-tree module has been loaded. | 231 | * 'O' - Out-of-tree module has been loaded. |
232 | * 'X' - Unsigned module has been loaded. | 232 | * 'E' - Unsigned module has been loaded. |
233 | * | 233 | * |
234 | * The string is overwritten by the next call to print_tainted(). | 234 | * The string is overwritten by the next call to print_tainted(). |
235 | */ | 235 | */ |