diff options
author | Ben Widawsky <benjamin.widawsky@intel.com> | 2014-05-27 19:53:08 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-06-05 02:52:47 -0400 |
commit | 562d55d991b39ce376c492df2f7890fd6a541ffc (patch) | |
tree | 6ba23ea79002f1b464b9dc7dd3fc5b6da49fbaec | |
parent | 0e8abc81bf4b54a01bb026ba4d883de7c415cc03 (diff) |
drm/i915/bdw: Only use 2g GGTT for 32b platforms
Daniel requested in the bug that I use a 3GB fallback size. Since this
is not in the spec as a valid size, I decided against it. We could
potentially add a patch to bump it to 3GB on top of this one.
This probably should be CC: stable - but I'll let the powers that be
decide that one.
Regression from a revert of the revert:
commit 7907f45bf9f67a1c5e5d4ae05bab428d7c2f43b2
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date: Wed Feb 19 22:05:46 2014 -0800
Revert "drm/i915/bdw: Limit GTT to 2GB"
v2: Change ifdef to 32b, instead of ifndef
update comment
v3. Update comment to not wrap (Daniel).
Update commit message
v4: s/CONFIG_32/CONFIG_X86_32 (Jani).
v5: s/CONFIG_x86_32BIT/CONFIG_x86_32, as meant in v4
s/32B/32b (chris)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76619
Cc: stable@vger.kernel.org
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Tested-by: "Yang, Guang A" <guang.a.yang@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem_gtt.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 94916362b61c..f3e23e15c46d 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c | |||
@@ -1763,6 +1763,13 @@ static inline unsigned int gen8_get_total_gtt_size(u16 bdw_gmch_ctl) | |||
1763 | bdw_gmch_ctl &= BDW_GMCH_GGMS_MASK; | 1763 | bdw_gmch_ctl &= BDW_GMCH_GGMS_MASK; |
1764 | if (bdw_gmch_ctl) | 1764 | if (bdw_gmch_ctl) |
1765 | bdw_gmch_ctl = 1 << bdw_gmch_ctl; | 1765 | bdw_gmch_ctl = 1 << bdw_gmch_ctl; |
1766 | |||
1767 | #ifdef CONFIG_X86_32 | ||
1768 | /* Limit 32b platforms to a 2GB GGTT: 4 << 20 / pte size * PAGE_SIZE */ | ||
1769 | if (bdw_gmch_ctl > 4) | ||
1770 | bdw_gmch_ctl = 4; | ||
1771 | #endif | ||
1772 | |||
1766 | return bdw_gmch_ctl << 20; | 1773 | return bdw_gmch_ctl << 20; |
1767 | } | 1774 | } |
1768 | 1775 | ||