diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-08-09 01:24:35 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2013-08-09 10:12:23 -0400 |
commit | 3d70a363d965ddb34678e33d5ab8d19ac5969aed (patch) | |
tree | d858a9a36feea17b2b710e1627d292a6331c3e8d | |
parent | b91bb0da07808f4a489a328d21dee2264001e179 (diff) |
ata: pata_samsung_cf: add missing __iomem annotation
Added missing __iomem annotation and staticized local symbol
in order to fix the following sparse warnings:
drivers/ata/pata_samsung_cf.c:244:14: warning: symbol 'pata_s3c_data_xfer' was not declared. Should it be static?
drivers/ata/pata_samsung_cf.c:423:20: warning: incorrect type in argument 1 (different address spaces)
drivers/ata/pata_samsung_cf.c:423:20: expected void const volatile [noderef] <asn:2>*addr
drivers/ata/pata_samsung_cf.c:423:20: got void *
drivers/ata/pata_samsung_cf.c:425:9: warning: incorrect type in argument 2 (different address spaces)
drivers/ata/pata_samsung_cf.c:425:9: expected void volatile [noderef] <asn:2>*addr
drivers/ata/pata_samsung_cf.c:425:9: got void *
drivers/ata/pata_samsung_cf.c:448:37: warning: incorrect type in argument 1 (different address spaces)
drivers/ata/pata_samsung_cf.c:448:37: expected void *s3c_ide_regbase
drivers/ata/pata_samsung_cf.c:448:37: got void [noderef] <asn:2>*ide_addr
drivers/ata/pata_samsung_cf.c:463:37: warning: incorrect type in argument 1 (different address spaces)
drivers/ata/pata_samsung_cf.c:463:37: expected void *s3c_ide_regbase
drivers/ata/pata_samsung_cf.c:463:37: got void [noderef] <asn:2>*ide_addr
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | drivers/ata/pata_samsung_cf.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index 951aa951ffdb..898e544a7ae8 100644 --- a/drivers/ata/pata_samsung_cf.c +++ b/drivers/ata/pata_samsung_cf.c | |||
@@ -241,8 +241,8 @@ static u8 pata_s3c_check_altstatus(struct ata_port *ap) | |||
241 | /* | 241 | /* |
242 | * pata_s3c_data_xfer - Transfer data by PIO | 242 | * pata_s3c_data_xfer - Transfer data by PIO |
243 | */ | 243 | */ |
244 | unsigned int pata_s3c_data_xfer(struct ata_device *dev, unsigned char *buf, | 244 | static unsigned int pata_s3c_data_xfer(struct ata_device *dev, |
245 | unsigned int buflen, int rw) | 245 | unsigned char *buf, unsigned int buflen, int rw) |
246 | { | 246 | { |
247 | struct ata_port *ap = dev->link->ap; | 247 | struct ata_port *ap = dev->link->ap; |
248 | struct s3c_ide_info *info = ap->host->private_data; | 248 | struct s3c_ide_info *info = ap->host->private_data; |
@@ -418,7 +418,7 @@ static struct ata_port_operations pata_s5p_port_ops = { | |||
418 | .set_piomode = pata_s3c_set_piomode, | 418 | .set_piomode = pata_s3c_set_piomode, |
419 | }; | 419 | }; |
420 | 420 | ||
421 | static void pata_s3c_enable(void *s3c_ide_regbase, bool state) | 421 | static void pata_s3c_enable(void __iomem *s3c_ide_regbase, bool state) |
422 | { | 422 | { |
423 | u32 temp = readl(s3c_ide_regbase + S3C_ATA_CTRL); | 423 | u32 temp = readl(s3c_ide_regbase + S3C_ATA_CTRL); |
424 | temp = state ? (temp | 1) : (temp & ~1); | 424 | temp = state ? (temp | 1) : (temp & ~1); |