diff options
author | Kumar Gala <galak@kernel.crashing.org> | 2009-04-02 00:38:49 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-03 12:48:29 -0400 |
commit | 3688e07f83d81941c4a8b20e29602c6d0c883539 (patch) | |
tree | d7169ef37071cc14225e7700a4f6c08981f3f5e4 | |
parent | c54c4dec61eec88de8260a00260fe89aa538f267 (diff) |
Fix highmem PPC build failure
Commit f4112de6b679d84bd9b9681c7504be7bdfb7c7d5 ("mm: introduce
debug_kmap_atomic") broke PPC builds with CONFIG_HIGHMEM=y:
CC init/main.o
In file included from include/linux/highmem.h:25,
from include/linux/pagemap.h:11,
from include/linux/mempolicy.h:63,
from init/main.c:53:
arch/powerpc/include/asm/highmem.h: In function 'kmap_atomic_prot':
arch/powerpc/include/asm/highmem.h:98: error: implicit declaration of function 'debug_kmap_atomic'
In file included from include/linux/pagemap.h:11,
from include/linux/mempolicy.h:63,
from init/main.c:53:
include/linux/highmem.h: At top level:
include/linux/highmem.h:196: warning: conflicting types for 'debug_kmap_atomic'
include/linux/highmem.h:196: error: static declaration of 'debug_kmap_atomic' follows non-static declaration
include/asm/highmem.h:98: error: previous implicit declaration of 'debug_kmap_atomic' was here
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/highmem.h | 29 |
1 files changed, 14 insertions, 15 deletions
diff --git a/include/linux/highmem.h b/include/linux/highmem.h index 7ff5c55f9b55..1fcb7126a01f 100644 --- a/include/linux/highmem.h +++ b/include/linux/highmem.h | |||
@@ -19,8 +19,21 @@ static inline void flush_kernel_dcache_page(struct page *page) | |||
19 | } | 19 | } |
20 | #endif | 20 | #endif |
21 | 21 | ||
22 | #ifdef CONFIG_HIGHMEM | 22 | #include <asm/kmap_types.h> |
23 | |||
24 | #if defined(CONFIG_DEBUG_HIGHMEM) && defined(CONFIG_TRACE_IRQFLAGS_SUPPORT) | ||
25 | |||
26 | void debug_kmap_atomic(enum km_type type); | ||
27 | |||
28 | #else | ||
23 | 29 | ||
30 | static inline void debug_kmap_atomic(enum km_type type) | ||
31 | { | ||
32 | } | ||
33 | |||
34 | #endif | ||
35 | |||
36 | #ifdef CONFIG_HIGHMEM | ||
24 | #include <asm/highmem.h> | 37 | #include <asm/highmem.h> |
25 | 38 | ||
26 | /* declarations for linux/mm/highmem.c */ | 39 | /* declarations for linux/mm/highmem.c */ |
@@ -44,8 +57,6 @@ static inline void *kmap(struct page *page) | |||
44 | 57 | ||
45 | #define kunmap(page) do { (void) (page); } while (0) | 58 | #define kunmap(page) do { (void) (page); } while (0) |
46 | 59 | ||
47 | #include <asm/kmap_types.h> | ||
48 | |||
49 | static inline void *kmap_atomic(struct page *page, enum km_type idx) | 60 | static inline void *kmap_atomic(struct page *page, enum km_type idx) |
50 | { | 61 | { |
51 | pagefault_disable(); | 62 | pagefault_disable(); |
@@ -187,16 +198,4 @@ static inline void copy_highpage(struct page *to, struct page *from) | |||
187 | kunmap_atomic(vto, KM_USER1); | 198 | kunmap_atomic(vto, KM_USER1); |
188 | } | 199 | } |
189 | 200 | ||
190 | #if defined(CONFIG_DEBUG_HIGHMEM) && defined(CONFIG_TRACE_IRQFLAGS_SUPPORT) | ||
191 | |||
192 | void debug_kmap_atomic(enum km_type type); | ||
193 | |||
194 | #else | ||
195 | |||
196 | static inline void debug_kmap_atomic(enum km_type type) | ||
197 | { | ||
198 | } | ||
199 | |||
200 | #endif | ||
201 | |||
202 | #endif /* _LINUX_HIGHMEM_H */ | 201 | #endif /* _LINUX_HIGHMEM_H */ |