diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2014-10-09 18:27:59 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-10-09 22:25:56 -0400 |
commit | 1c93923cc264105418e6ead149c76bd88302eff4 (patch) | |
tree | 1862aef87b2636d01b55f4ccbac7542fbe016060 | |
parent | dd6eecb917938c1b7e505a83df307b3476e7c8bd (diff) |
include/linux/migrate.h: remove migrate_page #define
This is designed to avoid a few ifdefs in .c files but it's obnoxious
because it can cause unsuspecting "migrate_page" symbols to get turned into
"NULL".
Just nuke it and use the ifdefs.
Cc: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Cc: Rafael Aquini <aquini@redhat.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/migrate.h | 3 | ||||
-rw-r--r-- | mm/shmem.c | 2 | ||||
-rw-r--r-- | mm/swap_state.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/include/linux/migrate.h b/include/linux/migrate.h index a2901c414664..b66fd10f4b93 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h | |||
@@ -82,9 +82,6 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping, | |||
82 | return -ENOSYS; | 82 | return -ENOSYS; |
83 | } | 83 | } |
84 | 84 | ||
85 | /* Possible settings for the migrate_page() method in address_operations */ | ||
86 | #define migrate_page NULL | ||
87 | |||
88 | #endif /* CONFIG_MIGRATION */ | 85 | #endif /* CONFIG_MIGRATION */ |
89 | 86 | ||
90 | #ifdef CONFIG_NUMA_BALANCING | 87 | #ifdef CONFIG_NUMA_BALANCING |
diff --git a/mm/shmem.c b/mm/shmem.c index 469f90d56051..4fad61bb41e5 100644 --- a/mm/shmem.c +++ b/mm/shmem.c | |||
@@ -3077,7 +3077,9 @@ static const struct address_space_operations shmem_aops = { | |||
3077 | .write_begin = shmem_write_begin, | 3077 | .write_begin = shmem_write_begin, |
3078 | .write_end = shmem_write_end, | 3078 | .write_end = shmem_write_end, |
3079 | #endif | 3079 | #endif |
3080 | #ifdef CONFIG_MIGRATION | ||
3080 | .migratepage = migrate_page, | 3081 | .migratepage = migrate_page, |
3082 | #endif | ||
3081 | .error_remove_page = generic_error_remove_page, | 3083 | .error_remove_page = generic_error_remove_page, |
3082 | }; | 3084 | }; |
3083 | 3085 | ||
diff --git a/mm/swap_state.c b/mm/swap_state.c index 3e0ec83d000c..ef1f39139b71 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c | |||
@@ -28,7 +28,9 @@ | |||
28 | static const struct address_space_operations swap_aops = { | 28 | static const struct address_space_operations swap_aops = { |
29 | .writepage = swap_writepage, | 29 | .writepage = swap_writepage, |
30 | .set_page_dirty = swap_set_page_dirty, | 30 | .set_page_dirty = swap_set_page_dirty, |
31 | #ifdef CONFIG_MIGRATION | ||
31 | .migratepage = migrate_page, | 32 | .migratepage = migrate_page, |
33 | #endif | ||
32 | }; | 34 | }; |
33 | 35 | ||
34 | static struct backing_dev_info swap_backing_dev_info = { | 36 | static struct backing_dev_info swap_backing_dev_info = { |