diff options
author | Or Gerlitz <ogerlitz@mellanox.com> | 2012-05-15 06:34:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-05-16 00:56:58 -0400 |
commit | 162344ed2c80845200845f83e310fa3058bfe001 (patch) | |
tree | 2c6da0a466f9dd63d57fab6cb150d9d4eb9ca01b | |
parent | bc9b35ad41387379e0b1257b3171da0dca73562d (diff) |
net/mlx4: Address build warnings on set but not used variables
Handle the compiler warnings on variables which are set but not used
by removing the relevant variable or casting a return value which is
ignored on purpose to void.
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/mr.c | 3 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/port.c | 7 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 9 |
5 files changed, 8 insertions, 18 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c index 773c70ea3f62..53b738b8a004 100644 --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c | |||
@@ -1254,7 +1254,6 @@ static void mlx4_master_do_cmd(struct mlx4_dev *dev, int slave, u8 cmd, | |||
1254 | struct mlx4_priv *priv = mlx4_priv(dev); | 1254 | struct mlx4_priv *priv = mlx4_priv(dev); |
1255 | struct mlx4_slave_state *slave_state = priv->mfunc.master.slave_state; | 1255 | struct mlx4_slave_state *slave_state = priv->mfunc.master.slave_state; |
1256 | u32 reply; | 1256 | u32 reply; |
1257 | u32 slave_status = 0; | ||
1258 | u8 is_going_down = 0; | 1257 | u8 is_going_down = 0; |
1259 | int i; | 1258 | int i; |
1260 | 1259 | ||
@@ -1274,10 +1273,8 @@ static void mlx4_master_do_cmd(struct mlx4_dev *dev, int slave, u8 cmd, | |||
1274 | } | 1273 | } |
1275 | /*check if we are in the middle of FLR process, | 1274 | /*check if we are in the middle of FLR process, |
1276 | if so return "retry" status to the slave*/ | 1275 | if so return "retry" status to the slave*/ |
1277 | if (MLX4_COMM_CMD_FLR == slave_state[slave].last_cmd) { | 1276 | if (MLX4_COMM_CMD_FLR == slave_state[slave].last_cmd) |
1278 | slave_status = MLX4_DELAY_RESET_SLAVE; | ||
1279 | goto inform_slave_state; | 1277 | goto inform_slave_state; |
1280 | } | ||
1281 | 1278 | ||
1282 | /* write the version in the event field */ | 1279 | /* write the version in the event field */ |
1283 | reply |= mlx4_comm_get_version(); | 1280 | reply |= mlx4_comm_get_version(); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c index 4799e824052f..f4a8f98e402a 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c | |||
@@ -357,7 +357,6 @@ static int add_promisc_qp(struct mlx4_dev *dev, u8 port, | |||
357 | u32 prot; | 357 | u32 prot; |
358 | int i; | 358 | int i; |
359 | bool found; | 359 | bool found; |
360 | int last_index; | ||
361 | int err; | 360 | int err; |
362 | struct mlx4_priv *priv = mlx4_priv(dev); | 361 | struct mlx4_priv *priv = mlx4_priv(dev); |
363 | 362 | ||
@@ -419,7 +418,6 @@ static int add_promisc_qp(struct mlx4_dev *dev, u8 port, | |||
419 | if (err) | 418 | if (err) |
420 | goto out_mailbox; | 419 | goto out_mailbox; |
421 | } | 420 | } |
422 | last_index = entry->index; | ||
423 | } | 421 | } |
424 | 422 | ||
425 | /* add the new qpn to list of promisc qps */ | 423 | /* add the new qpn to list of promisc qps */ |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mr.c b/drivers/net/ethernet/mellanox/mlx4/mr.c index fe2ac8449c19..cefa76f509c1 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mr.c +++ b/drivers/net/ethernet/mellanox/mlx4/mr.c | |||
@@ -788,7 +788,6 @@ int mlx4_fmr_alloc(struct mlx4_dev *dev, u32 pd, u32 access, int max_pages, | |||
788 | int max_maps, u8 page_shift, struct mlx4_fmr *fmr) | 788 | int max_maps, u8 page_shift, struct mlx4_fmr *fmr) |
789 | { | 789 | { |
790 | struct mlx4_priv *priv = mlx4_priv(dev); | 790 | struct mlx4_priv *priv = mlx4_priv(dev); |
791 | u64 mtt_offset; | ||
792 | int err = -ENOMEM; | 791 | int err = -ENOMEM; |
793 | 792 | ||
794 | if (max_maps > dev->caps.max_fmr_maps) | 793 | if (max_maps > dev->caps.max_fmr_maps) |
@@ -811,8 +810,6 @@ int mlx4_fmr_alloc(struct mlx4_dev *dev, u32 pd, u32 access, int max_pages, | |||
811 | if (err) | 810 | if (err) |
812 | return err; | 811 | return err; |
813 | 812 | ||
814 | mtt_offset = fmr->mr.mtt.offset * dev->caps.mtt_entry_sz; | ||
815 | |||
816 | fmr->mtts = mlx4_table_find(&priv->mr_table.mtt_table, | 813 | fmr->mtts = mlx4_table_find(&priv->mr_table.mtt_table, |
817 | fmr->mr.mtt.offset, | 814 | fmr->mr.mtt.offset, |
818 | &fmr->dma_handle); | 815 | &fmr->dma_handle); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 55b12e6bed87..1fe2c7a8b40c 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c | |||
@@ -338,13 +338,12 @@ EXPORT_SYMBOL_GPL(__mlx4_unregister_mac); | |||
338 | void mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac) | 338 | void mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, u64 mac) |
339 | { | 339 | { |
340 | u64 out_param; | 340 | u64 out_param; |
341 | int err; | ||
342 | 341 | ||
343 | if (mlx4_is_mfunc(dev)) { | 342 | if (mlx4_is_mfunc(dev)) { |
344 | set_param_l(&out_param, port); | 343 | set_param_l(&out_param, port); |
345 | err = mlx4_cmd_imm(dev, mac, &out_param, RES_MAC, | 344 | (void) mlx4_cmd_imm(dev, mac, &out_param, RES_MAC, |
346 | RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES, | 345 | RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES, |
347 | MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED); | 346 | MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED); |
348 | return; | 347 | return; |
349 | } | 348 | } |
350 | __mlx4_unregister_mac(dev, port, mac); | 349 | __mlx4_unregister_mac(dev, port, mac); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index 8752e6e08169..4b045b8cfdde 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | |||
@@ -2536,7 +2536,7 @@ int mlx4_QP_ATTACH_wrapper(struct mlx4_dev *dev, int slave, | |||
2536 | struct mlx4_qp qp; /* dummy for calling attach/detach */ | 2536 | struct mlx4_qp qp; /* dummy for calling attach/detach */ |
2537 | u8 *gid = inbox->buf; | 2537 | u8 *gid = inbox->buf; |
2538 | enum mlx4_protocol prot = (vhcr->in_modifier >> 28) & 0x7; | 2538 | enum mlx4_protocol prot = (vhcr->in_modifier >> 28) & 0x7; |
2539 | int err, err1; | 2539 | int err; |
2540 | int qpn; | 2540 | int qpn; |
2541 | struct res_qp *rqp; | 2541 | struct res_qp *rqp; |
2542 | int attach = vhcr->op_modifier; | 2542 | int attach = vhcr->op_modifier; |
@@ -2571,7 +2571,7 @@ int mlx4_QP_ATTACH_wrapper(struct mlx4_dev *dev, int slave, | |||
2571 | 2571 | ||
2572 | ex_rem: | 2572 | ex_rem: |
2573 | /* ignore error return below, already in error */ | 2573 | /* ignore error return below, already in error */ |
2574 | err1 = rem_mcg_res(dev, slave, rqp, gid, prot, type); | 2574 | (void) rem_mcg_res(dev, slave, rqp, gid, prot, type); |
2575 | ex_put: | 2575 | ex_put: |
2576 | put_res(dev, slave, qpn, RES_QP); | 2576 | put_res(dev, slave, qpn, RES_QP); |
2577 | 2577 | ||
@@ -2604,13 +2604,12 @@ static void detach_qp(struct mlx4_dev *dev, int slave, struct res_qp *rqp) | |||
2604 | { | 2604 | { |
2605 | struct res_gid *rgid; | 2605 | struct res_gid *rgid; |
2606 | struct res_gid *tmp; | 2606 | struct res_gid *tmp; |
2607 | int err; | ||
2608 | struct mlx4_qp qp; /* dummy for calling attach/detach */ | 2607 | struct mlx4_qp qp; /* dummy for calling attach/detach */ |
2609 | 2608 | ||
2610 | list_for_each_entry_safe(rgid, tmp, &rqp->mcg_list, list) { | 2609 | list_for_each_entry_safe(rgid, tmp, &rqp->mcg_list, list) { |
2611 | qp.qpn = rqp->local_qpn; | 2610 | qp.qpn = rqp->local_qpn; |
2612 | err = mlx4_qp_detach_common(dev, &qp, rgid->gid, rgid->prot, | 2611 | (void) mlx4_qp_detach_common(dev, &qp, rgid->gid, rgid->prot, |
2613 | rgid->steer); | 2612 | rgid->steer); |
2614 | list_del(&rgid->list); | 2613 | list_del(&rgid->list); |
2615 | kfree(rgid); | 2614 | kfree(rgid); |
2616 | } | 2615 | } |