diff options
author | Wu Fengguang <fengguang.wu@intel.com> | 2012-01-17 12:18:56 -0500 |
---|---|---|
committer | Wu Fengguang <fengguang.wu@intel.com> | 2012-02-01 03:53:40 -0500 |
commit | 15eb77a07c714ac80201abd0a9568888bcee6276 (patch) | |
tree | cc43dc8458cb431900fd47990772ffa56b36b4f4 | |
parent | 2673b4cf5d59c3ee5e0c12f6d734d38770324dc4 (diff) |
writeback: fix NULL bdi->dev in trace writeback_single_inode
bdi_prune_sb() resets sb->s_bdi to default_backing_dev_info when the
tearing down the original bdi. Fix trace_writeback_single_inode to
use sb->s_bdi=default_backing_dev_info rather than bdi->dev=NULL for a
teared down bdi.
Cc: <stable@kernel.org>
Reported-by: Rabin Vincent <rabin@rab.in>
Tested-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
-rw-r--r-- | fs/fs-writeback.c | 16 | ||||
-rw-r--r-- | include/trace/events/writeback.h | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index f855916657ba..5b4a9362d5aa 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -53,14 +53,6 @@ struct wb_writeback_work { | |||
53 | }; | 53 | }; |
54 | 54 | ||
55 | /* | 55 | /* |
56 | * Include the creation of the trace points after defining the | ||
57 | * wb_writeback_work structure so that the definition remains local to this | ||
58 | * file. | ||
59 | */ | ||
60 | #define CREATE_TRACE_POINTS | ||
61 | #include <trace/events/writeback.h> | ||
62 | |||
63 | /* | ||
64 | * We don't actually have pdflush, but this one is exported though /proc... | 56 | * We don't actually have pdflush, but this one is exported though /proc... |
65 | */ | 57 | */ |
66 | int nr_pdflush_threads; | 58 | int nr_pdflush_threads; |
@@ -92,6 +84,14 @@ static inline struct inode *wb_inode(struct list_head *head) | |||
92 | return list_entry(head, struct inode, i_wb_list); | 84 | return list_entry(head, struct inode, i_wb_list); |
93 | } | 85 | } |
94 | 86 | ||
87 | /* | ||
88 | * Include the creation of the trace points after defining the | ||
89 | * wb_writeback_work structure and inline functions so that the definition | ||
90 | * remains local to this file. | ||
91 | */ | ||
92 | #define CREATE_TRACE_POINTS | ||
93 | #include <trace/events/writeback.h> | ||
94 | |||
95 | /* Wakeup flusher thread or forker thread to fork it. Requires bdi->wb_lock. */ | 95 | /* Wakeup flusher thread or forker thread to fork it. Requires bdi->wb_lock. */ |
96 | static void bdi_wakeup_flusher(struct backing_dev_info *bdi) | 96 | static void bdi_wakeup_flusher(struct backing_dev_info *bdi) |
97 | { | 97 | { |
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index 8588a8918023..06d302ebcb72 100644 --- a/include/trace/events/writeback.h +++ b/include/trace/events/writeback.h | |||
@@ -426,7 +426,7 @@ DECLARE_EVENT_CLASS(writeback_single_inode_template, | |||
426 | 426 | ||
427 | TP_fast_assign( | 427 | TP_fast_assign( |
428 | strncpy(__entry->name, | 428 | strncpy(__entry->name, |
429 | dev_name(inode->i_mapping->backing_dev_info->dev), 32); | 429 | dev_name(inode_to_bdi(inode)->dev), 32); |
430 | __entry->ino = inode->i_ino; | 430 | __entry->ino = inode->i_ino; |
431 | __entry->state = inode->i_state; | 431 | __entry->state = inode->i_state; |
432 | __entry->dirtied_when = inode->dirtied_when; | 432 | __entry->dirtied_when = inode->dirtied_when; |