diff options
author | David Rientjes <rientjes@google.com> | 2011-07-25 20:12:17 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-07-25 23:57:09 -0400 |
commit | 11239836c04b50ba8453ec58ca7a7bd716ef02c1 (patch) | |
tree | 358705632aecb348e35f01fcc26281326d5a514a | |
parent | 6ac47520063b230641a64062b8a229201cd0a3a8 (diff) |
oom: remove references to old badness() function
The badness() function in the oom killer was renamed to oom_badness() in
a63d83f427fb ("oom: badness heuristic rewrite") since it is a globally
exported function for clarity.
The prototype for the old function still existed in linux/oom.h, so remove
it. There are no existing users.
Also fixes documentation and comment references to badness() and adjusts
them accordingly.
Signed-off-by: David Rientjes <rientjes@google.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | Documentation/ABI/obsolete/proc-pid-oom_adj | 2 | ||||
-rw-r--r-- | Documentation/feature-removal-schedule.txt | 2 | ||||
-rw-r--r-- | include/linux/oom.h | 4 | ||||
-rw-r--r-- | mm/oom_kill.c | 2 |
4 files changed, 3 insertions, 7 deletions
diff --git a/Documentation/ABI/obsolete/proc-pid-oom_adj b/Documentation/ABI/obsolete/proc-pid-oom_adj index cf63f264ce0f..9a3cb88ade47 100644 --- a/Documentation/ABI/obsolete/proc-pid-oom_adj +++ b/Documentation/ABI/obsolete/proc-pid-oom_adj | |||
@@ -14,7 +14,7 @@ Why: /proc/<pid>/oom_adj allows userspace to influence the oom killer's | |||
14 | 14 | ||
15 | A much more powerful interface, /proc/<pid>/oom_score_adj, was | 15 | A much more powerful interface, /proc/<pid>/oom_score_adj, was |
16 | introduced with the oom killer rewrite that allows users to increase or | 16 | introduced with the oom killer rewrite that allows users to increase or |
17 | decrease the badness() score linearly. This interface will replace | 17 | decrease the badness score linearly. This interface will replace |
18 | /proc/<pid>/oom_adj. | 18 | /proc/<pid>/oom_adj. |
19 | 19 | ||
20 | A warning will be emitted to the kernel log if an application uses this | 20 | A warning will be emitted to the kernel log if an application uses this |
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index f9d240dfac06..d093e550dbeb 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt | |||
@@ -184,7 +184,7 @@ Why: /proc/<pid>/oom_adj allows userspace to influence the oom killer's | |||
184 | 184 | ||
185 | A much more powerful interface, /proc/<pid>/oom_score_adj, was | 185 | A much more powerful interface, /proc/<pid>/oom_score_adj, was |
186 | introduced with the oom killer rewrite that allows users to increase or | 186 | introduced with the oom killer rewrite that allows users to increase or |
187 | decrease the badness() score linearly. This interface will replace | 187 | decrease the badness score linearly. This interface will replace |
188 | /proc/<pid>/oom_adj. | 188 | /proc/<pid>/oom_adj. |
189 | 189 | ||
190 | A warning will be emitted to the kernel log if an application uses this | 190 | A warning will be emitted to the kernel log if an application uses this |
diff --git a/include/linux/oom.h b/include/linux/oom.h index 4952fb874ad3..13b7b02e599a 100644 --- a/include/linux/oom.h +++ b/include/linux/oom.h | |||
@@ -64,10 +64,6 @@ static inline void oom_killer_enable(void) | |||
64 | oom_killer_disabled = false; | 64 | oom_killer_disabled = false; |
65 | } | 65 | } |
66 | 66 | ||
67 | /* The badness from the OOM killer */ | ||
68 | extern unsigned long badness(struct task_struct *p, struct mem_cgroup *mem, | ||
69 | const nodemask_t *nodemask, unsigned long uptime); | ||
70 | |||
71 | extern struct task_struct *find_lock_task_mm(struct task_struct *p); | 67 | extern struct task_struct *find_lock_task_mm(struct task_struct *p); |
72 | 68 | ||
73 | /* sysctls */ | 69 | /* sysctls */ |
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index b0be989d4365..eafff89b3dd6 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -487,7 +487,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, | |||
487 | 487 | ||
488 | /* | 488 | /* |
489 | * If any of p's children has a different mm and is eligible for kill, | 489 | * If any of p's children has a different mm and is eligible for kill, |
490 | * the one with the highest badness() score is sacrificed for its | 490 | * the one with the highest oom_badness() score is sacrificed for its |
491 | * parent. This attempts to lose the minimal amount of work done while | 491 | * parent. This attempts to lose the minimal amount of work done while |
492 | * still freeing memory. | 492 | * still freeing memory. |
493 | */ | 493 | */ |