aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2014-11-23 07:37:33 -0500
committerMark Brown <broonie@kernel.org>2014-11-24 13:29:05 -0500
commit0a87a6e1c09c3b93d91bf65809e79cf6cf358785 (patch)
tree292696597c8b6d60a063d7b5d37b3f0c984c4c39
parente2280c9040d8bc5039617af35ccf7b8ac4abb428 (diff)
ASoC: wm8960: Cleanup manual bias level transitions
Set the CODEC driver's suspend_bias_off flag rather than manually going to SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes the code a bit shorter and cleaner. Since the ASoC core now takes care of setting the bias level to SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually anymore either. The manual transition to SND_SOC_BIAS_STANDBY at the end of CODEC probe() can also be removed as the core will automatically do this after the CODEC has been probed. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/codecs/wm8960.c31
1 files changed, 1 insertions, 30 deletions
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 99d6457c87ba..bc8793cd1d72 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -943,22 +943,6 @@ static struct snd_soc_dai_driver wm8960_dai = {
943 .symmetric_rates = 1, 943 .symmetric_rates = 1,
944}; 944};
945 945
946static int wm8960_suspend(struct snd_soc_codec *codec)
947{
948 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
949
950 wm8960->set_bias_level(codec, SND_SOC_BIAS_OFF);
951 return 0;
952}
953
954static int wm8960_resume(struct snd_soc_codec *codec)
955{
956 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
957
958 wm8960->set_bias_level(codec, SND_SOC_BIAS_STANDBY);
959 return 0;
960}
961
962static int wm8960_probe(struct snd_soc_codec *codec) 946static int wm8960_probe(struct snd_soc_codec *codec)
963{ 947{
964 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec); 948 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
@@ -976,8 +960,6 @@ static int wm8960_probe(struct snd_soc_codec *codec)
976 return ret; 960 return ret;
977 } 961 }
978 962
979 wm8960->set_bias_level(codec, SND_SOC_BIAS_STANDBY);
980
981 /* Latch the update bits */ 963 /* Latch the update bits */
982 snd_soc_update_bits(codec, WM8960_LINVOL, 0x100, 0x100); 964 snd_soc_update_bits(codec, WM8960_LINVOL, 0x100, 0x100);
983 snd_soc_update_bits(codec, WM8960_RINVOL, 0x100, 0x100); 965 snd_soc_update_bits(codec, WM8960_RINVOL, 0x100, 0x100);
@@ -997,21 +979,10 @@ static int wm8960_probe(struct snd_soc_codec *codec)
997 return 0; 979 return 0;
998} 980}
999 981
1000/* power down chip */
1001static int wm8960_remove(struct snd_soc_codec *codec)
1002{
1003 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
1004
1005 wm8960->set_bias_level(codec, SND_SOC_BIAS_OFF);
1006 return 0;
1007}
1008
1009static struct snd_soc_codec_driver soc_codec_dev_wm8960 = { 982static struct snd_soc_codec_driver soc_codec_dev_wm8960 = {
1010 .probe = wm8960_probe, 983 .probe = wm8960_probe,
1011 .remove = wm8960_remove,
1012 .suspend = wm8960_suspend,
1013 .resume = wm8960_resume,
1014 .set_bias_level = wm8960_set_bias_level, 984 .set_bias_level = wm8960_set_bias_level,
985 .suspend_bias_off = true,
1015}; 986};
1016 987
1017static const struct regmap_config wm8960_regmap = { 988static const struct regmap_config wm8960_regmap = {