diff options
author | Wolfgang Mauerer <wolfgang.mauerer@siemens.com> | 2012-03-22 06:18:20 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2012-03-22 12:19:23 -0400 |
commit | 01de982abf8c9e10fc3089e10585cd2cc914bdab (patch) | |
tree | 09819515fa130cf8fad5b17367bbd6f9e787e4a5 | |
parent | 89c5bd08df5841326abbf167d136bcf14cf759ed (diff) |
tracing: Fix ftrace stack trace entries
8 hex characters tell only half the tale for 64 bit CPUs,
so use the appropriate length.
Link: http://lkml.kernel.org/r/1332411501-8059-2-git-send-email-wolfgang.mauerer@siemens.com
Cc: stable@vger.kernel.org
Signed-off-by: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r-- | kernel/trace/trace_entries.h | 16 | ||||
-rw-r--r-- | kernel/trace/trace_export.c | 2 |
2 files changed, 13 insertions, 5 deletions
diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h index 93365907f219..205dcac89206 100644 --- a/kernel/trace/trace_entries.h +++ b/kernel/trace/trace_entries.h | |||
@@ -156,6 +156,12 @@ FTRACE_ENTRY_DUP(wakeup, ctx_switch_entry, | |||
156 | 156 | ||
157 | #define FTRACE_STACK_ENTRIES 8 | 157 | #define FTRACE_STACK_ENTRIES 8 |
158 | 158 | ||
159 | #ifndef CONFIG_64BIT | ||
160 | # define IP_FMT "%08lx" | ||
161 | #else | ||
162 | # define IP_FMT "%016lx" | ||
163 | #endif | ||
164 | |||
159 | FTRACE_ENTRY(kernel_stack, stack_entry, | 165 | FTRACE_ENTRY(kernel_stack, stack_entry, |
160 | 166 | ||
161 | TRACE_STACK, | 167 | TRACE_STACK, |
@@ -165,8 +171,9 @@ FTRACE_ENTRY(kernel_stack, stack_entry, | |||
165 | __dynamic_array(unsigned long, caller ) | 171 | __dynamic_array(unsigned long, caller ) |
166 | ), | 172 | ), |
167 | 173 | ||
168 | F_printk("\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n" | 174 | F_printk("\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n" |
169 | "\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n", | 175 | "\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n" |
176 | "\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n", | ||
170 | __entry->caller[0], __entry->caller[1], __entry->caller[2], | 177 | __entry->caller[0], __entry->caller[1], __entry->caller[2], |
171 | __entry->caller[3], __entry->caller[4], __entry->caller[5], | 178 | __entry->caller[3], __entry->caller[4], __entry->caller[5], |
172 | __entry->caller[6], __entry->caller[7]) | 179 | __entry->caller[6], __entry->caller[7]) |
@@ -181,8 +188,9 @@ FTRACE_ENTRY(user_stack, userstack_entry, | |||
181 | __array( unsigned long, caller, FTRACE_STACK_ENTRIES ) | 188 | __array( unsigned long, caller, FTRACE_STACK_ENTRIES ) |
182 | ), | 189 | ), |
183 | 190 | ||
184 | F_printk("\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n" | 191 | F_printk("\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n" |
185 | "\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n\t=> (%08lx)\n", | 192 | "\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n" |
193 | "\t=> (" IP_FMT ")\n\t=> (" IP_FMT ")\n", | ||
186 | __entry->caller[0], __entry->caller[1], __entry->caller[2], | 194 | __entry->caller[0], __entry->caller[1], __entry->caller[2], |
187 | __entry->caller[3], __entry->caller[4], __entry->caller[5], | 195 | __entry->caller[3], __entry->caller[4], __entry->caller[5], |
188 | __entry->caller[6], __entry->caller[7]) | 196 | __entry->caller[6], __entry->caller[7]) |
diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c index bbeec31e0ae3..ad4000c71be0 100644 --- a/kernel/trace/trace_export.c +++ b/kernel/trace/trace_export.c | |||
@@ -150,7 +150,7 @@ ftrace_define_fields_##name(struct ftrace_event_call *event_call) \ | |||
150 | #define __dynamic_array(type, item) | 150 | #define __dynamic_array(type, item) |
151 | 151 | ||
152 | #undef F_printk | 152 | #undef F_printk |
153 | #define F_printk(fmt, args...) #fmt ", " __stringify(args) | 153 | #define F_printk(fmt, args...) __stringify(fmt) ", " __stringify(args) |
154 | 154 | ||
155 | #undef FTRACE_ENTRY | 155 | #undef FTRACE_ENTRY |
156 | #define FTRACE_ENTRY(call, struct_name, etype, tstruct, print) \ | 156 | #define FTRACE_ENTRY(call, struct_name, etype, tstruct, print) \ |