diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-17 18:46:35 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-17 18:46:35 -0400 |
commit | f01674e459923c6df540e6c983d37e5fc94d43b8 (patch) | |
tree | 3a92f84ee42a62f6c1b070adcfcf74cd5be0b7a7 | |
parent | aab8ad9ec81255ee08825bed36b57484052b94ea (diff) |
ide: remove obsoleted "idex=noprobe" kernel parameter (take 2)
* Remove obsoleted "idex=noprobe" kernel parameter.
* Remove no longer needed hwif->noprobe quirk from ide_hwif_configure()
and hwif->noprobe checking from cmd640.c.
v2:
* "ide?=noprobe" -> "ide?=ata66" in Documentation/kernel-parameters.txt.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r-- | Documentation/kernel-parameters.txt | 2 | ||||
-rw-r--r-- | drivers/ide/ide.c | 6 | ||||
-rw-r--r-- | drivers/ide/pci/cmd640.c | 3 | ||||
-rw-r--r-- | drivers/ide/setup-pci.c | 7 |
4 files changed, 4 insertions, 14 deletions
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 228d85a3f319..239e78a1fcd0 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt | |||
@@ -767,7 +767,7 @@ and is between 256 and 4096 characters. It is defined in the file | |||
767 | See Documentation/ide/ide.txt. | 767 | See Documentation/ide/ide.txt. |
768 | 768 | ||
769 | ide?= [HW] (E)IDE subsystem | 769 | ide?= [HW] (E)IDE subsystem |
770 | Format: ide?=noprobe or chipset specific parameters. | 770 | Format: ide?=ata66 or chipset specific parameters. |
771 | See Documentation/ide/ide.txt. | 771 | See Documentation/ide/ide.txt. |
772 | 772 | ||
773 | idebus= [HW] (E)IDE subsystem - VLB/PCI bus speed | 773 | idebus= [HW] (E)IDE subsystem - VLB/PCI bus speed |
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c index 690b5ff4d88f..aa809aded87f 100644 --- a/drivers/ide/ide.c +++ b/drivers/ide/ide.c | |||
@@ -1131,7 +1131,7 @@ static int __init ide_setup(char *s) | |||
1131 | * (-8, -9, -10) are reserved to ease the hardcoding. | 1131 | * (-8, -9, -10) are reserved to ease the hardcoding. |
1132 | */ | 1132 | */ |
1133 | static const char *ide_words[] = { | 1133 | static const char *ide_words[] = { |
1134 | "noprobe", "serialize", "minus3", "minus4", | 1134 | "minus1", "serialize", "minus3", "minus4", |
1135 | "reset", "minus6", "ata66", "minus8", "minus9", | 1135 | "reset", "minus6", "ata66", "minus8", "minus9", |
1136 | "minus10", "four", "qd65xx", "ht6560b", "cmd640_vlb", | 1136 | "minus10", "four", "qd65xx", "ht6560b", "cmd640_vlb", |
1137 | "dtc2278", "umc8672", "ali14xx", NULL }; | 1137 | "dtc2278", "umc8672", "ali14xx", NULL }; |
@@ -1218,9 +1218,7 @@ static int __init ide_setup(char *s) | |||
1218 | hwif->serialized = hwif->mate->serialized = 1; | 1218 | hwif->serialized = hwif->mate->serialized = 1; |
1219 | goto obsolete_option; | 1219 | goto obsolete_option; |
1220 | 1220 | ||
1221 | case -1: /* "noprobe" */ | 1221 | case -1: |
1222 | hwif->noprobe = 1; | ||
1223 | goto obsolete_option; | ||
1224 | case 0: | 1222 | case 0: |
1225 | case 1: | 1223 | case 1: |
1226 | case 2: | 1224 | case 2: |
diff --git a/drivers/ide/pci/cmd640.c b/drivers/ide/pci/cmd640.c index dbf0fa733b76..a1cfe033a55f 100644 --- a/drivers/ide/pci/cmd640.c +++ b/drivers/ide/pci/cmd640.c | |||
@@ -789,8 +789,7 @@ static int __init cmd640x_init(void) | |||
789 | /* | 789 | /* |
790 | * Try to enable the secondary interface, if not already enabled | 790 | * Try to enable the secondary interface, if not already enabled |
791 | */ | 791 | */ |
792 | if (cmd_hwif1->noprobe || | 792 | if (cmd_hwif1->drives[0].noprobe && cmd_hwif1->drives[1].noprobe) { |
793 | (cmd_hwif1->drives[0].noprobe && cmd_hwif1->drives[1].noprobe)) { | ||
794 | port2 = "not probed"; | 793 | port2 = "not probed"; |
795 | } else { | 794 | } else { |
796 | b = get_cmd640_reg(CNTRL); | 795 | b = get_cmd640_reg(CNTRL); |
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c index ee4a34b49062..f7ede0e42881 100644 --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c | |||
@@ -345,7 +345,6 @@ static ide_hwif_t *ide_hwif_configure(struct pci_dev *dev, | |||
345 | unsigned long ctl = 0, base = 0; | 345 | unsigned long ctl = 0, base = 0; |
346 | ide_hwif_t *hwif; | 346 | ide_hwif_t *hwif; |
347 | u8 bootable = (d->host_flags & IDE_HFLAG_BOOTABLE) ? 1 : 0; | 347 | u8 bootable = (d->host_flags & IDE_HFLAG_BOOTABLE) ? 1 : 0; |
348 | u8 oldnoprobe = 0; | ||
349 | struct hw_regs_s hw; | 348 | struct hw_regs_s hw; |
350 | 349 | ||
351 | if ((d->host_flags & IDE_HFLAG_ISA_PORTS) == 0) { | 350 | if ((d->host_flags & IDE_HFLAG_ISA_PORTS) == 0) { |
@@ -376,14 +375,8 @@ static ide_hwif_t *ide_hwif_configure(struct pci_dev *dev, | |||
376 | hw.chipset = d->chipset ? d->chipset : ide_pci; | 375 | hw.chipset = d->chipset ? d->chipset : ide_pci; |
377 | ide_std_init_ports(&hw, base, ctl | 2); | 376 | ide_std_init_ports(&hw, base, ctl | 2); |
378 | 377 | ||
379 | if (hwif->io_ports[IDE_DATA_OFFSET] == base && | ||
380 | hwif->io_ports[IDE_CONTROL_OFFSET] == (ctl | 2)) | ||
381 | oldnoprobe = hwif->noprobe; | ||
382 | |||
383 | ide_init_port_hw(hwif, &hw); | 378 | ide_init_port_hw(hwif, &hw); |
384 | 379 | ||
385 | hwif->noprobe = oldnoprobe; | ||
386 | |||
387 | hwif->dev = &dev->dev; | 380 | hwif->dev = &dev->dev; |
388 | hwif->cds = d; | 381 | hwif->cds = d; |
389 | 382 | ||