[ALSA] Add snd_pcm_group_for_each_entry() for code cleanup

Added a new macro snd_pcm_group_for_each_entry() just for code cleanup.
Old macros, snd_pcm_group_for_each() and snd_pcm_group_substream_entry(),
are removed.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>

18 files changed, 34 insertions, 85 deletions

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index deff5a92efa6..73334e0f823f 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -603,11 +603,8 @@ do { \
         read_unlock_irqrestore(&snd_pcm_link_rwlock, (flags)); \
 } while (0)
 
-#define snd_pcm_group_for_each(pos, substream) \
-        list_for_each(pos, &substream->group->substreams)
-
-#define snd_pcm_group_substream_entry(pos) \
-        list_entry(pos, struct snd_pcm_substream, link_list)
+#define snd_pcm_group_for_each_entry(s, substream) \
+        list_for_each_entry(s, &substream->group->substreams, link_list)
 
 static inline int snd_pcm_running(struct snd_pcm_substream *substream)
 {
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 905234817c89..42a039cc50a8 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -712,26 +712,22 @@ static int snd_pcm_action_group(struct action_ops *ops,
                                 struct snd_pcm_substream *substream,
                                 int state, int do_lock)
 {
-        struct list_head *pos;
         struct snd_pcm_substream *s = NULL;
         struct snd_pcm_substream *s1;
         int res = 0;
 
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 if (do_lock && s != substream)
                         spin_lock(&s->self_group.lock);
                 res = ops->pre_action(s, state);
                 if (res < 0)
                         goto _unlock;
         }
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 res = ops->do_action(s, state);
                 if (res < 0) {
                         if (ops->undo_action) {
-                                snd_pcm_group_for_each(pos, substream) {
-                                        s1 = snd_pcm_group_substream_entry(pos);
+                                snd_pcm_group_for_each_entry(s1, substream) {
                                         if (s1 == s) /* failed stream */
                                                 break;
                                         ops->undo_action(s1, state);
@@ -741,15 +737,13 @@ static int snd_pcm_action_group(struct action_ops *ops,
                         goto _unlock;
                 }
         }
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 ops->post_action(s, state);
         }
  _unlock:
         if (do_lock) {
                 /* unlock streams */
-                snd_pcm_group_for_each(pos, substream) {
-                        s1 = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s1, substream) {
                         if (s1 != substream)
                                 spin_unlock(&s1->self_group.lock);
                         if (s1 == s)    /* end */
@@ -1438,7 +1432,7 @@ static int snd_pcm_drain(struct snd_pcm_substream *substream)
 {
         struct snd_card *card;
         struct snd_pcm_runtime *runtime;
-        struct list_head *pos;
+        struct snd_pcm_substream *s;
         int result = 0;
         int i, num_drecs;
         struct drain_rec *drec, drec_tmp, *d;
@@ -1473,8 +1467,7 @@ static int snd_pcm_drain(struct snd_pcm_substream *substream)
 
         /* count only playback streams */
         num_drecs = 0;
-        snd_pcm_group_for_each(pos, substream) {
-                struct snd_pcm_substream *s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 runtime = s->runtime;
                 if (s->stream == SNDRV_PCM_STREAM_PLAYBACK) {
                         d = &drec[num_drecs++];
@@ -1674,7 +1667,7 @@ static void relink_to_local(struct snd_pcm_substream *substream)
 
 static int snd_pcm_unlink(struct snd_pcm_substream *substream)
 {
-        struct list_head *pos;
+        struct snd_pcm_substream *s;
         int res = 0;
 
         down_write(&snd_pcm_link_rwsem);
@@ -1686,8 +1679,8 @@ static int snd_pcm_unlink(struct snd_pcm_substream *substream)
         list_del(&substream->link_list);
         substream->group->count--;
         if (substream->group->count == 1) {     /* detach the last stream, too */
-                snd_pcm_group_for_each(pos, substream) {
-                        relink_to_local(snd_pcm_group_substream_entry(pos));
+                snd_pcm_group_for_each_entry(s, substream) {
+                        relink_to_local(s);
                         break;
                 }
                 kfree(substream->group);
diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c
index 75c7c5f01989..914d77b61b0c 100644
--- a/sound/isa/cs423x/cs4231_lib.c
+++ b/sound/isa/cs423x/cs4231_lib.c
@@ -405,7 +405,6 @@ static int snd_cs4231_trigger(struct snd_pcm_substream *substream,
         struct snd_cs4231 *chip = snd_pcm_substream_chip(substream);
         int result = 0;
         unsigned int what;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         int do_start;
 
@@ -425,8 +424,7 @@ static int snd_cs4231_trigger(struct snd_pcm_substream *substream,
         }
 
         what = 0;
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 if (s == chip->playback_substream) {
                         what |= CS4231_PLAYBACK_ENABLE;
                         snd_pcm_trigger_done(s, substream);
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 1c390580bd50..95d0ab124d5b 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -934,10 +934,8 @@ static int snd_opti93x_trigger(struct snd_pcm_substream *substream,
         case SNDRV_PCM_TRIGGER_STOP:
         {
                 unsigned int what = 0;
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == chip->playback_substream) {
                                 what |= OPTi93X_PLAYBACK_ENABLE;
                                 snd_pcm_trigger_done(s, substream);
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
index ba7fa22b285d..cd2fe374744c 100644
--- a/sound/pci/ali5451/ali5451.c
+++ b/sound/pci/ali5451/ali5451.c
@@ -1224,7 +1224,6 @@ static int snd_ali_trigger(struct snd_pcm_substream *substream,
                                     
 {
         struct snd_ali *codec = snd_pcm_substream_chip(substream);
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         unsigned int what, whati, capture_flag;
         struct snd_ali_voice *pvoice = NULL, *evoice = NULL;
@@ -1243,8 +1242,7 @@ static int snd_ali_trigger(struct snd_pcm_substream *substream,
         }
 
         what = whati = capture_flag = 0;
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 if ((struct snd_ali *) snd_pcm_substream_chip(s) == codec) {
                         pvoice = s->runtime->private_data;
                         evoice = pvoice->extra;
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index ea6712b63c9f..48f3f17c5170 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -775,7 +775,6 @@ static int snd_ca0106_pcm_trigger_playback(struct snd_pcm_substream *substream,
         struct snd_ca0106_pcm *epcm;
         int channel;
         int result = 0;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         u32 basic = 0;
         u32 extended = 0;
@@ -790,8 +789,7 @@ static int snd_ca0106_pcm_trigger_playback(struct snd_pcm_substream *substream,
                 running=0;
                 break;
         }
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 runtime = s->runtime;
                 epcm = runtime->private_data;
                 channel = epcm->channel_id;
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index e413da00759b..f27b6a733b96 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -705,11 +705,9 @@ static int pcm_trigger(struct snd_pcm_substream *substream, int cmd)
         struct audiopipe *pipe = runtime->private_data;
         int i, err;
         u32 channelmask = 0;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
 
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 for (i = 0; i < DSP_MAXPIPES; i++) {
                         if (s == chip->substream[i]) {
                                 channelmask |= 1 << i;
diff --git a/sound/pci/emu10k1/p16v.c b/sound/pci/emu10k1/p16v.c
index 465f8d505329..7ee19c63c2c8 100644
--- a/sound/pci/emu10k1/p16v.c
+++ b/sound/pci/emu10k1/p16v.c
@@ -433,7 +433,6 @@ static int snd_p16v_pcm_trigger_playback(struct snd_pcm_substream *substream,
         struct snd_emu10k1_pcm *epcm;
         int channel;
         int result = 0;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         u32 basic = 0;
         u32 inte = 0;
@@ -448,8 +447,7 @@ static int snd_p16v_pcm_trigger_playback(struct snd_pcm_substream *substream,
                 running = 0;
                 break;
         }
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 runtime = s->runtime;
                 epcm = runtime->private_data;
                 channel = substream->pcm->device-emu->p16v_device_offset;
diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
index 425b167522d5..6a0ddcf00884 100644
--- a/sound/pci/ens1370.c
+++ b/sound/pci/ens1370.c
@@ -798,10 +798,8 @@ static int snd_ensoniq_trigger(struct snd_pcm_substream *substream, int cmd)
         case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
         {
                 unsigned int what = 0;
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == ensoniq->playback1_substream) {
                                 what |= ES_P1_PAUSE;
                                 snd_pcm_trigger_done(s, substream);
@@ -824,10 +822,8 @@ static int snd_ensoniq_trigger(struct snd_pcm_substream *substream, int cmd)
         case SNDRV_PCM_TRIGGER_STOP:
         {
                 unsigned int what = 0;
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == ensoniq->playback1_substream) {
                                 what |= ES_DAC1_EN;
                                 snd_pcm_trigger_done(s, substream);
diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 830a1bbd7110..e880469beb4f 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -977,11 +977,9 @@ static int snd_ice1712_pro_trigger(struct snd_pcm_substream *substream,
         {
                 unsigned int what = 0;
                 unsigned int old;
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
 
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == ice->playback_pro_substream) {
                                 what |= ICE1712_PLAYBACK_START;
                                 snd_pcm_trigger_done(s, substream);
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 1127ebdf5fec..3f2aca20a625 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -337,13 +337,11 @@ static int snd_vt1724_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
         struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
         unsigned char what;
         unsigned char old;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
 
         what = 0;
-        snd_pcm_group_for_each(pos, substream) {
+        snd_pcm_group_for_each_entry(s, substream) {
                 const struct vt1724_pcm_reg *reg;
-                s = snd_pcm_group_substream_entry(pos);
                 reg = s->runtime->private_data;
                 what |= reg->start;
                 snd_pcm_trigger_done(s, substream);
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index d97413484ae9..e1bdeed3a465 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -638,7 +638,6 @@ static void pcxhr_trigger_tasklet(unsigned long arg)
 static int pcxhr_trigger(struct snd_pcm_substream *subs, int cmd)
 {
         struct pcxhr_stream *stream;
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         int i;
 
@@ -646,8 +645,7 @@ static int pcxhr_trigger(struct snd_pcm_substream *subs, int cmd)
         case SNDRV_PCM_TRIGGER_START:
                 snd_printdd("SNDRV_PCM_TRIGGER_START\n");
                 i = 0;
-                snd_pcm_group_for_each(pos, subs) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, subs) {
                         stream = s->runtime->private_data;
                         stream->status = PCXHR_STREAM_STATUS_SCHEDULE_RUN;
                         snd_pcm_trigger_done(s, subs);
@@ -672,8 +670,7 @@ static int pcxhr_trigger(struct snd_pcm_substream *subs, int cmd)
                 break;
         case SNDRV_PCM_TRIGGER_STOP:
                 snd_printdd("SNDRV_PCM_TRIGGER_STOP\n");
-                snd_pcm_group_for_each(pos, subs) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, subs) {
                         stream = s->runtime->private_data;
                         stream->status = PCXHR_STREAM_STATUS_SCHEDULE_STOP;
                         if (pcxhr_set_stream_state(stream))
diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index 6bb7ac650ec4..618653e22561 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -1078,12 +1078,10 @@ static int
 snd_rme32_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 {
         struct rme32 *rme32 = snd_pcm_substream_chip(substream);
-        struct list_head *pos;
         struct snd_pcm_substream *s;
 
         spin_lock(&rme32->lock);
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 if (s != rme32->playback_substream &&
                     s != rme32->capture_substream)
                         continue;
@@ -1110,8 +1108,7 @@ snd_rme32_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
         
         /* prefill playback buffer */
         if (cmd == SNDRV_PCM_TRIGGER_START && rme32->fullduplex_mode) {
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == rme32->playback_substream) {
                                 s->ops->ack(s);
                                 break;
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 89b3c7ff5037..6540037a11e4 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -3780,11 +3780,9 @@ static int snd_hdsp_reset(struct snd_pcm_substream *substream)
         else
                 runtime->status->hw_ptr = 0;
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
                 struct snd_pcm_runtime *oruntime = other->runtime;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 oruntime->status->hw_ptr = runtime->status->hw_ptr;
                                 break;
@@ -3933,10 +3931,8 @@ static int snd_hdsp_trigger(struct snd_pcm_substream *substream, int cmd)
                 other = hdsp->playback_substream;
 
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 snd_pcm_trigger_done(s, substream);
                                 if (cmd == SNDRV_PCM_TRIGGER_START)
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 6e95857e4e67..d2ae6380943e 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -3575,11 +3575,9 @@ static int snd_hdspm_reset(struct snd_pcm_substream *substream)
         else
                 runtime->status->hw_ptr = 0;
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
                 struct snd_pcm_runtime *oruntime = other->runtime;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 oruntime->status->hw_ptr =
                                     runtime->status->hw_ptr;
@@ -3791,10 +3789,8 @@ static int snd_hdspm_trigger(struct snd_pcm_substream *substream, int cmd)
                 other = hdspm->playback_substream;
 
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 snd_pcm_trigger_done(s, substream);
                                 if (cmd == SNDRV_PCM_TRIGGER_START)
diff --git a/sound/pci/rme9652/rme9652.c b/sound/pci/rme9652/rme9652.c
index cc3bdececce7..bd7dbd267ed1 100644
--- a/sound/pci/rme9652/rme9652.c
+++ b/sound/pci/rme9652/rme9652.c
@@ -1992,11 +1992,9 @@ static int snd_rme9652_reset(struct snd_pcm_substream *substream)
         else
                 runtime->status->hw_ptr = 0;
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
                 struct snd_pcm_runtime *oruntime = other->runtime;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 oruntime->status->hw_ptr = runtime->status->hw_ptr;
                                 break;
@@ -2140,10 +2138,8 @@ static int snd_rme9652_trigger(struct snd_pcm_substream *substream,
                 other = rme9652->playback_substream;
 
         if (other) {
-                struct list_head *pos;
                 struct snd_pcm_substream *s;
-                snd_pcm_group_for_each(pos, substream) {
-                        s = snd_pcm_group_substream_entry(pos);
+                snd_pcm_group_for_each_entry(s, substream) {
                         if (s == other) {
                                 snd_pcm_trigger_done(s, substream);
                                 if (cmd == SNDRV_PCM_TRIGGER_START)
diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c
index 3bff32167f66..7ca606272460 100644
--- a/sound/pci/trident/trident_main.c
+++ b/sound/pci/trident/trident_main.c
@@ -1540,7 +1540,6 @@ static int snd_trident_trigger(struct snd_pcm_substream *substream,
                                     
 {
         struct snd_trident *trident = snd_pcm_substream_chip(substream);
-        struct list_head *pos;
         struct snd_pcm_substream *s;
         unsigned int what, whati, capture_flag, spdif_flag;
         struct snd_trident_voice *voice, *evoice;
@@ -1563,8 +1562,7 @@ static int snd_trident_trigger(struct snd_pcm_substream *substream,
         what = whati = capture_flag = spdif_flag = 0;
         spin_lock(&trident->reg_lock);
         val = inl(TRID_REG(trident, T4D_STIMER)) & 0x00ffffff;
-        snd_pcm_group_for_each(pos, substream) {
-                s = snd_pcm_group_substream_entry(pos);
+        snd_pcm_group_for_each_entry(s, substream) {
                 if ((struct snd_trident *) snd_pcm_substream_chip(s) == trident) {
                         voice = s->runtime->private_data;
                         evoice = voice->extra;
diff --git a/sound/sparc/cs4231.c b/sound/sparc/cs4231.c
index 900a00de35fd..96d51abcb73a 100644
--- a/sound/sparc/cs4231.c
+++ b/sound/sparc/cs4231.c
@@ -661,10 +661,9 @@ static int snd_cs4231_trigger(struct snd_pcm_substream *substream, int cmd)
         {
                 unsigned int what = 0;
                 struct snd_pcm_substream *s;
-                struct list_head *pos;
                 unsigned long flags;
 
-                snd_pcm_group_for_each(pos, substream) {
+                snd_pcm_group_for_each_entry(s, substream) {
                         s = snd_pcm_group_substream_entry(pos);
                         if (s == chip->playback_substream) {
                                 what |= CS4231_PLAYBACK_ENABLE;