diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-04-30 03:53:27 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 11:29:40 -0400 |
| commit | c0754c99a6bcfcba7e1d68b75e3f25cb367af0fa (patch) | |
| tree | 0c78590e52b490cd36c7f7baa71dc72d5527f03c | |
| parent | 6e4d376c664ded7cb9cc1c7d0cae67c9672e46b1 (diff) | |
68360serial: Note that there isn't any info->mcr locking
Noticed while auditing the code for the BKL elimination project
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/serial/68360serial.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c index f59463601874..6f540107d0bb 100644 --- a/drivers/serial/68360serial.c +++ b/drivers/serial/68360serial.c | |||
| @@ -1282,7 +1282,7 @@ static int rs_360_tiocmset(struct tty_struct *tty, struct file *file, | |||
| 1282 | 1282 | ||
| 1283 | if (tty->flags & (1 << TTY_IO_ERROR)) | 1283 | if (tty->flags & (1 << TTY_IO_ERROR)) |
| 1284 | return -EIO; | 1284 | return -EIO; |
| 1285 | 1285 | /* FIXME: locking on info->mcr */ | |
| 1286 | if (set & TIOCM_RTS) | 1286 | if (set & TIOCM_RTS) |
| 1287 | info->mcr |= UART_MCR_RTS; | 1287 | info->mcr |= UART_MCR_RTS; |
| 1288 | if (set & TIOCM_DTR) | 1288 | if (set & TIOCM_DTR) |