diff options
author | Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> | 2008-06-26 07:06:24 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2008-06-27 16:01:14 -0400 |
commit | b97089400d44b9e90ce5029a2e458cd087473c74 (patch) | |
tree | cefbe4ac45ad92ae757120010173bdaa737c56bf | |
parent | 3aa50c44628629a6d58f93e0a1244e95a874884e (diff) |
pciehp: use get_service_data
Current pciehp driver saves its private data pointer into pci_dev
structure using pci_set_drvdata()/pci_get_drvdata(). But because
pciehp is not a pci device driver but a PCI Express service driver, it
should save its private data pointer into pcie_device structure using
set_service_data()/get_service_data().
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
-rw-r--r-- | drivers/pci/hotplug/pciehp_core.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index d0fb56936911..3677495c4f91 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c | |||
@@ -405,7 +405,7 @@ static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_ | |||
405 | dbg("%s: controller initialization failed\n", PCIE_MODULE_NAME); | 405 | dbg("%s: controller initialization failed\n", PCIE_MODULE_NAME); |
406 | goto err_out_none; | 406 | goto err_out_none; |
407 | } | 407 | } |
408 | pci_set_drvdata(pdev, ctrl); | 408 | set_service_data(dev, ctrl); |
409 | 409 | ||
410 | /* Setup the slot information structures */ | 410 | /* Setup the slot information structures */ |
411 | rc = init_slots(ctrl); | 411 | rc = init_slots(ctrl); |
@@ -445,8 +445,7 @@ err_out_none: | |||
445 | 445 | ||
446 | static void pciehp_remove (struct pcie_device *dev) | 446 | static void pciehp_remove (struct pcie_device *dev) |
447 | { | 447 | { |
448 | struct pci_dev *pdev = dev->port; | 448 | struct controller *ctrl = get_service_data(dev); |
449 | struct controller *ctrl = pci_get_drvdata(pdev); | ||
450 | 449 | ||
451 | cleanup_slots(ctrl); | 450 | cleanup_slots(ctrl); |
452 | ctrl->hpc_ops->release_ctlr(ctrl); | 451 | ctrl->hpc_ops->release_ctlr(ctrl); |
@@ -463,8 +462,7 @@ static int pciehp_resume (struct pcie_device *dev) | |||
463 | { | 462 | { |
464 | printk("%s ENTRY\n", __func__); | 463 | printk("%s ENTRY\n", __func__); |
465 | if (pciehp_force) { | 464 | if (pciehp_force) { |
466 | struct pci_dev *pdev = dev->port; | 465 | struct controller *ctrl = get_service_data(dev); |
467 | struct controller *ctrl = pci_get_drvdata(pdev); | ||
468 | struct slot *t_slot; | 466 | struct slot *t_slot; |
469 | u8 status; | 467 | u8 status; |
470 | 468 | ||