diff options
author | Adrian Bunk <bunk@stusta.de> | 2007-07-17 07:05:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-17 13:23:13 -0400 |
commit | b309c050cd8a705229085bff790ad532b3cdf819 (patch) | |
tree | 13b529ab5d7fcb247446f64b34534723e71580e2 | |
parent | a58d67ce7d648f3a2512d6d044b5eab0c6f71253 (diff) |
pm3fb: possible cleanups
- remove the empty pm3fb_setup() and corresponding code
- pm3fb_init() can become static
[adaplas]
- retain call to fb_get_options() for global options
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/video/pm3fb.c | 29 |
1 files changed, 2 insertions, 27 deletions
diff --git a/drivers/video/pm3fb.c b/drivers/video/pm3fb.c index a9b841c6f356..5b3f54c0918e 100644 --- a/drivers/video/pm3fb.c +++ b/drivers/video/pm3fb.c | |||
@@ -612,8 +612,6 @@ static void pm3fb_write_mode(struct fb_info *info) | |||
612 | /* | 612 | /* |
613 | * hardware independent functions | 613 | * hardware independent functions |
614 | */ | 614 | */ |
615 | int pm3fb_init(void); | ||
616 | |||
617 | static int pm3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) | 615 | static int pm3fb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) |
618 | { | 616 | { |
619 | u32 lpitch; | 617 | u32 lpitch; |
@@ -1170,35 +1168,12 @@ static struct pci_driver pm3fb_driver = { | |||
1170 | 1168 | ||
1171 | MODULE_DEVICE_TABLE(pci, pm3fb_id_table); | 1169 | MODULE_DEVICE_TABLE(pci, pm3fb_id_table); |
1172 | 1170 | ||
1173 | #ifndef MODULE | 1171 | static int __init pm3fb_init(void) |
1174 | /* | ||
1175 | * Setup | ||
1176 | */ | ||
1177 | |||
1178 | /* | ||
1179 | * Only necessary if your driver takes special options, | ||
1180 | * otherwise we fall back on the generic fb_setup(). | ||
1181 | */ | ||
1182 | static int __init pm3fb_setup(char *options) | ||
1183 | { | 1172 | { |
1184 | /* Parse user speficied options (`video=pm3fb:') */ | ||
1185 | return 0; | ||
1186 | } | ||
1187 | #endif /* MODULE */ | ||
1188 | |||
1189 | int __init pm3fb_init(void) | ||
1190 | { | ||
1191 | /* | ||
1192 | * For kernel boot options (in 'video=pm3fb:<options>' format) | ||
1193 | */ | ||
1194 | #ifndef MODULE | 1173 | #ifndef MODULE |
1195 | char *option = NULL; | 1174 | if (fb_get_options("pm3fb", NULL)) |
1196 | |||
1197 | if (fb_get_options("pm3fb", &option)) | ||
1198 | return -ENODEV; | 1175 | return -ENODEV; |
1199 | pm3fb_setup(option); | ||
1200 | #endif | 1176 | #endif |
1201 | |||
1202 | return pci_register_driver(&pm3fb_driver); | 1177 | return pci_register_driver(&pm3fb_driver); |
1203 | } | 1178 | } |
1204 | 1179 | ||