diff options
author | Lepton Wu <ytht.net@gmail.com> | 2007-10-17 02:29:50 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:57 -0400 |
commit | 80eb68d23897126e7f25e2b3689bc27fb8cdde17 (patch) | |
tree | f054c849b1e8856912050342fcb27d83a6f42830 | |
parent | a6cd6bf9f8cab154a4a086fe786bd7422954d8dc (diff) |
reiserfs: fix kernel panic on corrupted directory
When reading corrupted reiserfs directory data, d_reclen could be a
negative number or a big positive number, this can lead to kernel panic or
oop. The following patch adds a sanity check.
Signed-off-by: Lepton Wu <ytht.net@gmail.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: "Vladimir V. Saveliev" <vs@namesys.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/reiserfs/dir.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c index ffbfc2caaf20..e6b03d2020c1 100644 --- a/fs/reiserfs/dir.c +++ b/fs/reiserfs/dir.c | |||
@@ -121,6 +121,16 @@ static int reiserfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
121 | continue; | 121 | continue; |
122 | d_reclen = entry_length(bh, ih, entry_num); | 122 | d_reclen = entry_length(bh, ih, entry_num); |
123 | d_name = B_I_DEH_ENTRY_FILE_NAME(bh, ih, deh); | 123 | d_name = B_I_DEH_ENTRY_FILE_NAME(bh, ih, deh); |
124 | |||
125 | if (d_reclen <= 0 || | ||
126 | d_name + d_reclen > bh->b_data + bh->b_size) { | ||
127 | /* There is corrupted data in entry, | ||
128 | * We'd better stop here */ | ||
129 | pathrelse(&path_to_entry); | ||
130 | ret = -EIO; | ||
131 | goto out; | ||
132 | } | ||
133 | |||
124 | if (!d_name[d_reclen - 1]) | 134 | if (!d_name[d_reclen - 1]) |
125 | d_reclen = strlen(d_name); | 135 | d_reclen = strlen(d_name); |
126 | 136 | ||