diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2006-12-06 23:37:22 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-07 11:39:36 -0500 |
commit | 6cfd76a26d9fe2ba54b9d496a48c1d9285e5c5ed (patch) | |
tree | 1114a0630c5045d0650c6d78a8097fdea6f94d8e | |
parent | a4c410f00f7ca4bd448b0d63f6f882fd244dc991 (diff) |
[PATCH] lockdep: name some old style locks
Name some of the remaning 'old_style_spin_init' locks
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | arch/i386/kernel/traps.c | 2 | ||||
-rw-r--r-- | include/asm-i386/rwsem.h | 4 | ||||
-rw-r--r-- | include/linux/init_task.h | 2 | ||||
-rw-r--r-- | include/linux/mutex.h | 2 | ||||
-rw-r--r-- | include/linux/rtmutex.h | 2 | ||||
-rw-r--r-- | include/linux/rwsem-spinlock.h | 3 | ||||
-rw-r--r-- | include/linux/sunrpc/sched.h | 4 | ||||
-rw-r--r-- | kernel/acct.c | 3 | ||||
-rw-r--r-- | kernel/irq/handle.c | 2 | ||||
-rw-r--r-- | net/sunrpc/svcauth.c | 3 | ||||
-rw-r--r-- | security/keys/process_keys.c | 2 |
11 files changed, 16 insertions, 13 deletions
diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c index fe9c5e8e7e6f..3124f1b04d67 100644 --- a/arch/i386/kernel/traps.c +++ b/arch/i386/kernel/traps.c | |||
@@ -452,7 +452,7 @@ void die(const char * str, struct pt_regs * regs, long err) | |||
452 | u32 lock_owner; | 452 | u32 lock_owner; |
453 | int lock_owner_depth; | 453 | int lock_owner_depth; |
454 | } die = { | 454 | } die = { |
455 | .lock = SPIN_LOCK_UNLOCKED, | 455 | .lock = __SPIN_LOCK_UNLOCKED(die.lock), |
456 | .lock_owner = -1, | 456 | .lock_owner = -1, |
457 | .lock_owner_depth = 0 | 457 | .lock_owner_depth = 0 |
458 | }; | 458 | }; |
diff --git a/include/asm-i386/rwsem.h b/include/asm-i386/rwsem.h index bc598d6388e3..041906f3c6df 100644 --- a/include/asm-i386/rwsem.h +++ b/include/asm-i386/rwsem.h | |||
@@ -75,8 +75,8 @@ struct rw_semaphore { | |||
75 | 75 | ||
76 | 76 | ||
77 | #define __RWSEM_INITIALIZER(name) \ | 77 | #define __RWSEM_INITIALIZER(name) \ |
78 | { RWSEM_UNLOCKED_VALUE, SPIN_LOCK_UNLOCKED, LIST_HEAD_INIT((name).wait_list) \ | 78 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait_lock), \ |
79 | __RWSEM_DEP_MAP_INIT(name) } | 79 | LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) } |
80 | 80 | ||
81 | #define DECLARE_RWSEM(name) \ | 81 | #define DECLARE_RWSEM(name) \ |
82 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | 82 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) |
diff --git a/include/linux/init_task.h b/include/linux/init_task.h index 33c5daacc743..733790d4f7db 100644 --- a/include/linux/init_task.h +++ b/include/linux/init_task.h | |||
@@ -73,7 +73,7 @@ | |||
73 | extern struct nsproxy init_nsproxy; | 73 | extern struct nsproxy init_nsproxy; |
74 | #define INIT_NSPROXY(nsproxy) { \ | 74 | #define INIT_NSPROXY(nsproxy) { \ |
75 | .count = ATOMIC_INIT(1), \ | 75 | .count = ATOMIC_INIT(1), \ |
76 | .nslock = SPIN_LOCK_UNLOCKED, \ | 76 | .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \ |
77 | .uts_ns = &init_uts_ns, \ | 77 | .uts_ns = &init_uts_ns, \ |
78 | .namespace = NULL, \ | 78 | .namespace = NULL, \ |
79 | INIT_IPC_NS(ipc_ns) \ | 79 | INIT_IPC_NS(ipc_ns) \ |
diff --git a/include/linux/mutex.h b/include/linux/mutex.h index 27c48daa3183..b2b91c477563 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h | |||
@@ -94,7 +94,7 @@ do { \ | |||
94 | 94 | ||
95 | #define __MUTEX_INITIALIZER(lockname) \ | 95 | #define __MUTEX_INITIALIZER(lockname) \ |
96 | { .count = ATOMIC_INIT(1) \ | 96 | { .count = ATOMIC_INIT(1) \ |
97 | , .wait_lock = SPIN_LOCK_UNLOCKED \ | 97 | , .wait_lock = __SPIN_LOCK_UNLOCKED(lockname.wait_lock) \ |
98 | , .wait_list = LIST_HEAD_INIT(lockname.wait_list) \ | 98 | , .wait_list = LIST_HEAD_INIT(lockname.wait_list) \ |
99 | __DEBUG_MUTEX_INITIALIZER(lockname) \ | 99 | __DEBUG_MUTEX_INITIALIZER(lockname) \ |
100 | __DEP_MAP_MUTEX_INITIALIZER(lockname) } | 100 | __DEP_MAP_MUTEX_INITIALIZER(lockname) } |
diff --git a/include/linux/rtmutex.h b/include/linux/rtmutex.h index 5d41dee82f80..b0090e9f7884 100644 --- a/include/linux/rtmutex.h +++ b/include/linux/rtmutex.h | |||
@@ -63,7 +63,7 @@ struct hrtimer_sleeper; | |||
63 | #endif | 63 | #endif |
64 | 64 | ||
65 | #define __RT_MUTEX_INITIALIZER(mutexname) \ | 65 | #define __RT_MUTEX_INITIALIZER(mutexname) \ |
66 | { .wait_lock = SPIN_LOCK_UNLOCKED \ | 66 | { .wait_lock = __SPIN_LOCK_UNLOCKED(mutexname.wait_lock) \ |
67 | , .wait_list = PLIST_HEAD_INIT(mutexname.wait_list, mutexname.wait_lock) \ | 67 | , .wait_list = PLIST_HEAD_INIT(mutexname.wait_list, mutexname.wait_lock) \ |
68 | , .owner = NULL \ | 68 | , .owner = NULL \ |
69 | __DEBUG_RT_MUTEX_INITIALIZER(mutexname)} | 69 | __DEBUG_RT_MUTEX_INITIALIZER(mutexname)} |
diff --git a/include/linux/rwsem-spinlock.h b/include/linux/rwsem-spinlock.h index ae1fcadd598e..813cee13da0d 100644 --- a/include/linux/rwsem-spinlock.h +++ b/include/linux/rwsem-spinlock.h | |||
@@ -44,7 +44,8 @@ struct rw_semaphore { | |||
44 | #endif | 44 | #endif |
45 | 45 | ||
46 | #define __RWSEM_INITIALIZER(name) \ | 46 | #define __RWSEM_INITIALIZER(name) \ |
47 | { 0, SPIN_LOCK_UNLOCKED, LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) } | 47 | { 0, __SPIN_LOCK_UNLOCKED(name.wait_lock), LIST_HEAD_INIT((name).wait_list) \ |
48 | __RWSEM_DEP_MAP_INIT(name) } | ||
48 | 49 | ||
49 | #define DECLARE_RWSEM(name) \ | 50 | #define DECLARE_RWSEM(name) \ |
50 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | 51 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) |
diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h index f399c138f79d..0746c3b16f3a 100644 --- a/include/linux/sunrpc/sched.h +++ b/include/linux/sunrpc/sched.h | |||
@@ -222,7 +222,7 @@ struct rpc_wait_queue { | |||
222 | 222 | ||
223 | #ifndef RPC_DEBUG | 223 | #ifndef RPC_DEBUG |
224 | # define RPC_WAITQ_INIT(var,qname) { \ | 224 | # define RPC_WAITQ_INIT(var,qname) { \ |
225 | .lock = SPIN_LOCK_UNLOCKED, \ | 225 | .lock = __SPIN_LOCK_UNLOCKED(var.lock), \ |
226 | .tasks = { \ | 226 | .tasks = { \ |
227 | [0] = LIST_HEAD_INIT(var.tasks[0]), \ | 227 | [0] = LIST_HEAD_INIT(var.tasks[0]), \ |
228 | [1] = LIST_HEAD_INIT(var.tasks[1]), \ | 228 | [1] = LIST_HEAD_INIT(var.tasks[1]), \ |
@@ -231,7 +231,7 @@ struct rpc_wait_queue { | |||
231 | } | 231 | } |
232 | #else | 232 | #else |
233 | # define RPC_WAITQ_INIT(var,qname) { \ | 233 | # define RPC_WAITQ_INIT(var,qname) { \ |
234 | .lock = SPIN_LOCK_UNLOCKED, \ | 234 | .lock = __SPIN_LOCK_UNLOCKED(var.lock), \ |
235 | .tasks = { \ | 235 | .tasks = { \ |
236 | [0] = LIST_HEAD_INIT(var.tasks[0]), \ | 236 | [0] = LIST_HEAD_INIT(var.tasks[0]), \ |
237 | [1] = LIST_HEAD_INIT(var.tasks[1]), \ | 237 | [1] = LIST_HEAD_INIT(var.tasks[1]), \ |
diff --git a/kernel/acct.c b/kernel/acct.c index 0aad5ca36a81..dc12db8600e7 100644 --- a/kernel/acct.c +++ b/kernel/acct.c | |||
@@ -89,7 +89,8 @@ struct acct_glbs { | |||
89 | struct timer_list timer; | 89 | struct timer_list timer; |
90 | }; | 90 | }; |
91 | 91 | ||
92 | static struct acct_glbs acct_globals __cacheline_aligned = {SPIN_LOCK_UNLOCKED}; | 92 | static struct acct_glbs acct_globals __cacheline_aligned = |
93 | {__SPIN_LOCK_UNLOCKED(acct_globals.lock)}; | ||
93 | 94 | ||
94 | /* | 95 | /* |
95 | * Called whenever the timer says to check the free space. | 96 | * Called whenever the timer says to check the free space. |
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index a681912bc89a..aff1f0fabb0d 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c | |||
@@ -54,7 +54,7 @@ struct irq_desc irq_desc[NR_IRQS] __cacheline_aligned = { | |||
54 | .chip = &no_irq_chip, | 54 | .chip = &no_irq_chip, |
55 | .handle_irq = handle_bad_irq, | 55 | .handle_irq = handle_bad_irq, |
56 | .depth = 1, | 56 | .depth = 1, |
57 | .lock = SPIN_LOCK_UNLOCKED, | 57 | .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock), |
58 | #ifdef CONFIG_SMP | 58 | #ifdef CONFIG_SMP |
59 | .affinity = CPU_MASK_ALL | 59 | .affinity = CPU_MASK_ALL |
60 | #endif | 60 | #endif |
diff --git a/net/sunrpc/svcauth.c b/net/sunrpc/svcauth.c index ee9bb1522d5e..c7bb5f7f21a5 100644 --- a/net/sunrpc/svcauth.c +++ b/net/sunrpc/svcauth.c | |||
@@ -119,7 +119,8 @@ EXPORT_SYMBOL(svc_auth_unregister); | |||
119 | #define DN_HASHMASK (DN_HASHMAX-1) | 119 | #define DN_HASHMASK (DN_HASHMAX-1) |
120 | 120 | ||
121 | static struct hlist_head auth_domain_table[DN_HASHMAX]; | 121 | static struct hlist_head auth_domain_table[DN_HASHMAX]; |
122 | static spinlock_t auth_domain_lock = SPIN_LOCK_UNLOCKED; | 122 | static spinlock_t auth_domain_lock = |
123 | __SPIN_LOCK_UNLOCKED(auth_domain_lock); | ||
123 | 124 | ||
124 | void auth_domain_put(struct auth_domain *dom) | 125 | void auth_domain_put(struct auth_domain *dom) |
125 | { | 126 | { |
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index 32150cf7c37f..b6f86808475a 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c | |||
@@ -27,7 +27,7 @@ static DEFINE_MUTEX(key_session_mutex); | |||
27 | struct key_user root_key_user = { | 27 | struct key_user root_key_user = { |
28 | .usage = ATOMIC_INIT(3), | 28 | .usage = ATOMIC_INIT(3), |
29 | .consq = LIST_HEAD_INIT(root_key_user.consq), | 29 | .consq = LIST_HEAD_INIT(root_key_user.consq), |
30 | .lock = SPIN_LOCK_UNLOCKED, | 30 | .lock = __SPIN_LOCK_UNLOCKED(root_key_user.lock), |
31 | .nkeys = ATOMIC_INIT(2), | 31 | .nkeys = ATOMIC_INIT(2), |
32 | .nikeys = ATOMIC_INIT(2), | 32 | .nikeys = ATOMIC_INIT(2), |
33 | .uid = 0, | 33 | .uid = 0, |