aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@us.ibm.com>2007-01-30 04:18:44 -0500
committerJames Bottomley <jejb@mulgrave.localdomain>2007-07-18 12:15:20 -0400
commit38691593cda9674f41d8708eaa73b0b7e14e95c3 (patch)
tree49deec786e646fc48175d45f4dc6df8a104c7078
parent1c50dc83f9ca752b1e1b985f1ce33d2695103ffa (diff)
[SCSI] sas_ata: Don't copy aic94xx's sactive to ata_port
Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it no longer makes any sense to copy the sactive field in the STP response to ata_port->sactive, as that will confuse libata. Also, libata seems to be capable of managing sactive on its own. The attached patch gets rid of one of the causes of the BUG messages in ata_qc_new, and seems to work without problems on an IBM x206m. Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r--drivers/scsi/libsas/sas_ata.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index c8af884abe18..16c3e5a581ae 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -106,7 +106,6 @@ static void sas_ata_task_done(struct sas_task *task)
106 dev->sata_dev.sstatus = resp->sstatus; 106 dev->sata_dev.sstatus = resp->sstatus;
107 dev->sata_dev.serror = resp->serror; 107 dev->sata_dev.serror = resp->serror;
108 dev->sata_dev.scontrol = resp->scontrol; 108 dev->sata_dev.scontrol = resp->scontrol;
109 dev->sata_dev.ap->sactive = resp->sactive;
110 } else if (stat->stat != SAM_STAT_GOOD) { 109 } else if (stat->stat != SAM_STAT_GOOD) {
111 ac = sas_to_ata_err(stat); 110 ac = sas_to_ata_err(stat);
112 if (ac) { 111 if (ac) {