diff options
author | Dan Williams <dan.j.williams@intel.com> | 2007-07-16 02:40:26 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-16 12:05:45 -0400 |
commit | 1b0fac45878bb88759eec347c273285195649ff7 (patch) | |
tree | a9871a47ef98c90bac3f65a7f9309e87420c694c | |
parent | 9e7bf24b1b979db256ddc84d0d4ac6040d706da6 (diff) |
dma-mapping: prevent dma dependent code from linking on !HAS_DMA archs
Continuing the work started in 411f0f3edc141a582190d3605cadd1d993abb6df ...
This enables code with a dma path, that compiles away, to build without
requiring additional code factoring. It also prevents code that calls
dma_alloc_coherent and dma_free_coherent from linking whereas previously
the code would hit a BUG() at run time. Finally, it allows archs that set
!HAS_DMA to delete their asm/dma-mapping.h file.
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Kyle McMartin <kyle@parisc-linux.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: <geert@linux-m68k.org>
Cc: <zippel@linux-m68k.org>
Cc: <spyro@f2s.com>
Cc: <ysato@users.sourceforge.jp>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/arm26/Kconfig | 3 | ||||
-rw-r--r-- | arch/h8300/Kconfig | 3 | ||||
-rw-r--r-- | arch/m32r/Kconfig | 3 | ||||
-rw-r--r-- | drivers/dma/Kconfig | 2 | ||||
-rw-r--r-- | include/asm-arm26/dma-mapping.h | 2 | ||||
-rw-r--r-- | include/asm-generic/dma-mapping-broken.h | 82 | ||||
-rw-r--r-- | include/asm-h8300/dma-mapping.h | 1 | ||||
-rw-r--r-- | include/asm-m32r/dma-mapping.h | 6 | ||||
-rw-r--r-- | include/asm-s390/dma-mapping.h | 12 | ||||
-rw-r--r-- | include/linux/dma-mapping.h | 4 |
10 files changed, 84 insertions, 34 deletions
diff --git a/arch/arm26/Kconfig b/arch/arm26/Kconfig index 20688bc13e9b..9044f33299f7 100644 --- a/arch/arm26/Kconfig +++ b/arch/arm26/Kconfig | |||
@@ -17,6 +17,9 @@ config MMU | |||
17 | bool | 17 | bool |
18 | default y | 18 | default y |
19 | 19 | ||
20 | config NO_DMA | ||
21 | def_bool y | ||
22 | |||
20 | config ARCH_ACORN | 23 | config ARCH_ACORN |
21 | bool | 24 | bool |
22 | default y | 25 | default y |
diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig index 618dbad696f6..e35f74e6e505 100644 --- a/arch/h8300/Kconfig +++ b/arch/h8300/Kconfig | |||
@@ -68,6 +68,9 @@ config TIME_LOW_RES | |||
68 | config NO_IOPORT | 68 | config NO_IOPORT |
69 | def_bool y | 69 | def_bool y |
70 | 70 | ||
71 | config NO_DMA | ||
72 | def_bool y | ||
73 | |||
71 | config ISA | 74 | config ISA |
72 | bool | 75 | bool |
73 | default y | 76 | default y |
diff --git a/arch/m32r/Kconfig b/arch/m32r/Kconfig index c3bb8a755b00..8ccf3e47bff8 100644 --- a/arch/m32r/Kconfig +++ b/arch/m32r/Kconfig | |||
@@ -31,6 +31,9 @@ config GENERIC_IRQ_PROBE | |||
31 | config NO_IOPORT | 31 | config NO_IOPORT |
32 | def_bool y | 32 | def_bool y |
33 | 33 | ||
34 | config NO_DMA | ||
35 | def_bool y | ||
36 | |||
34 | source "init/Kconfig" | 37 | source "init/Kconfig" |
35 | 38 | ||
36 | 39 | ||
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index b31756d59978..8f670dae53bb 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig | |||
@@ -3,7 +3,7 @@ | |||
3 | # | 3 | # |
4 | 4 | ||
5 | menu "DMA Engine support" | 5 | menu "DMA Engine support" |
6 | depends on !S390 | 6 | depends on HAS_DMA |
7 | 7 | ||
8 | config DMA_ENGINE | 8 | config DMA_ENGINE |
9 | bool "Support for DMA engines" | 9 | bool "Support for DMA engines" |
diff --git a/include/asm-arm26/dma-mapping.h b/include/asm-arm26/dma-mapping.h deleted file mode 100644 index a95eae0aeb77..000000000000 --- a/include/asm-arm26/dma-mapping.h +++ /dev/null | |||
@@ -1,2 +0,0 @@ | |||
1 | #include <asm-generic/dma-mapping-broken.h> | ||
2 | |||
diff --git a/include/asm-generic/dma-mapping-broken.h b/include/asm-generic/dma-mapping-broken.h index 29413d3d4605..e2468f894d2a 100644 --- a/include/asm-generic/dma-mapping-broken.h +++ b/include/asm-generic/dma-mapping-broken.h | |||
@@ -1,24 +1,82 @@ | |||
1 | #ifndef _ASM_GENERIC_DMA_MAPPING_H | 1 | #ifndef _ASM_GENERIC_DMA_MAPPING_H |
2 | #define _ASM_GENERIC_DMA_MAPPING_H | 2 | #define _ASM_GENERIC_DMA_MAPPING_H |
3 | 3 | ||
4 | /* This is used for archs that do not support DMA */ | 4 | /* define the dma api to allow compilation but not linking of |
5 | * dma dependent code. Code that depends on the dma-mapping | ||
6 | * API needs to set 'depends on HAS_DMA' in its Kconfig | ||
7 | */ | ||
5 | 8 | ||
6 | static inline void * | 9 | struct scatterlist; |
10 | |||
11 | extern void * | ||
7 | dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, | 12 | dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, |
8 | gfp_t flag) | 13 | gfp_t flag); |
9 | { | ||
10 | BUG(); | ||
11 | return NULL; | ||
12 | } | ||
13 | 14 | ||
14 | static inline void | 15 | extern void |
15 | dma_free_coherent(struct device *dev, size_t size, void *cpu_addr, | 16 | dma_free_coherent(struct device *dev, size_t size, void *cpu_addr, |
16 | dma_addr_t dma_handle) | 17 | dma_addr_t dma_handle); |
17 | { | ||
18 | BUG(); | ||
19 | } | ||
20 | 18 | ||
21 | #define dma_alloc_noncoherent(d, s, h, f) dma_alloc_coherent(d, s, h, f) | 19 | #define dma_alloc_noncoherent(d, s, h, f) dma_alloc_coherent(d, s, h, f) |
22 | #define dma_free_noncoherent(d, s, v, h) dma_free_coherent(d, s, v, h) | 20 | #define dma_free_noncoherent(d, s, v, h) dma_free_coherent(d, s, v, h) |
23 | 21 | ||
22 | extern dma_addr_t | ||
23 | dma_map_single(struct device *dev, void *ptr, size_t size, | ||
24 | enum dma_data_direction direction); | ||
25 | |||
26 | extern void | ||
27 | dma_unmap_single(struct device *dev, dma_addr_t dma_addr, size_t size, | ||
28 | enum dma_data_direction direction); | ||
29 | |||
30 | extern int | ||
31 | dma_map_sg(struct device *dev, struct scatterlist *sg, int nents, | ||
32 | enum dma_data_direction direction); | ||
33 | |||
34 | extern void | ||
35 | dma_unmap_sg(struct device *dev, struct scatterlist *sg, int nhwentries, | ||
36 | enum dma_data_direction direction); | ||
37 | |||
38 | extern dma_addr_t | ||
39 | dma_map_page(struct device *dev, struct page *page, unsigned long offset, | ||
40 | size_t size, enum dma_data_direction direction); | ||
41 | |||
42 | extern void | ||
43 | dma_unmap_page(struct device *dev, dma_addr_t dma_address, size_t size, | ||
44 | enum dma_data_direction direction); | ||
45 | |||
46 | extern void | ||
47 | dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle, size_t size, | ||
48 | enum dma_data_direction direction); | ||
49 | |||
50 | extern void | ||
51 | dma_sync_single_range_for_cpu(struct device *dev, dma_addr_t dma_handle, | ||
52 | unsigned long offset, size_t size, | ||
53 | enum dma_data_direction direction); | ||
54 | |||
55 | extern void | ||
56 | dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems, | ||
57 | enum dma_data_direction direction); | ||
58 | |||
59 | #define dma_sync_single_for_device dma_sync_single_for_cpu | ||
60 | #define dma_sync_single_range_for_device dma_sync_single_range_for_cpu | ||
61 | #define dma_sync_sg_for_device dma_sync_sg_for_cpu | ||
62 | |||
63 | extern int | ||
64 | dma_mapping_error(dma_addr_t dma_addr); | ||
65 | |||
66 | extern int | ||
67 | dma_supported(struct device *dev, u64 mask); | ||
68 | |||
69 | extern int | ||
70 | dma_set_mask(struct device *dev, u64 mask); | ||
71 | |||
72 | extern int | ||
73 | dma_get_cache_alignment(void); | ||
74 | |||
75 | extern int | ||
76 | dma_is_consistent(struct device *dev, dma_addr_t dma_handle); | ||
77 | |||
78 | extern void | ||
79 | dma_cache_sync(struct device *dev, void *vaddr, size_t size, | ||
80 | enum dma_data_direction direction); | ||
81 | |||
24 | #endif /* _ASM_GENERIC_DMA_MAPPING_H */ | 82 | #endif /* _ASM_GENERIC_DMA_MAPPING_H */ |
diff --git a/include/asm-h8300/dma-mapping.h b/include/asm-h8300/dma-mapping.h deleted file mode 100644 index d00e40099165..000000000000 --- a/include/asm-h8300/dma-mapping.h +++ /dev/null | |||
@@ -1 +0,0 @@ | |||
1 | #include <asm-generic/dma-mapping-broken.h> | ||
diff --git a/include/asm-m32r/dma-mapping.h b/include/asm-m32r/dma-mapping.h deleted file mode 100644 index f9b58ebba361..000000000000 --- a/include/asm-m32r/dma-mapping.h +++ /dev/null | |||
@@ -1,6 +0,0 @@ | |||
1 | #ifndef _ASM_M32R_DMA_MAPPING_H | ||
2 | #define _ASM_M32R_DMA_MAPPING_H | ||
3 | |||
4 | #include <asm-generic/dma-mapping-broken.h> | ||
5 | |||
6 | #endif /* _ASM_M32R_DMA_MAPPING_H */ | ||
diff --git a/include/asm-s390/dma-mapping.h b/include/asm-s390/dma-mapping.h deleted file mode 100644 index 3f8c12fde0f0..000000000000 --- a/include/asm-s390/dma-mapping.h +++ /dev/null | |||
@@ -1,12 +0,0 @@ | |||
1 | /* | ||
2 | * include/asm-s390/dma-mapping.h | ||
3 | * | ||
4 | * S390 version | ||
5 | * | ||
6 | * This file exists so that #include <dma-mapping.h> doesn't break anything. | ||
7 | */ | ||
8 | |||
9 | #ifndef _ASM_DMA_MAPPING_H | ||
10 | #define _ASM_DMA_MAPPING_H | ||
11 | |||
12 | #endif /* _ASM_DMA_MAPPING_H */ | ||
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 9a663c6db16a..2dc21cbeb304 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h | |||
@@ -31,7 +31,11 @@ static inline int valid_dma_direction(int dma_direction) | |||
31 | (dma_direction == DMA_FROM_DEVICE)); | 31 | (dma_direction == DMA_FROM_DEVICE)); |
32 | } | 32 | } |
33 | 33 | ||
34 | #ifdef CONFIG_HAS_DMA | ||
34 | #include <asm/dma-mapping.h> | 35 | #include <asm/dma-mapping.h> |
36 | #else | ||
37 | #include <asm-generic/dma-mapping-broken.h> | ||
38 | #endif | ||
35 | 39 | ||
36 | /* Backwards compat, remove in 2.7.x */ | 40 | /* Backwards compat, remove in 2.7.x */ |
37 | #define dma_sync_single dma_sync_single_for_cpu | 41 | #define dma_sync_single dma_sync_single_for_cpu |