aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-04-07 09:47:21 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:24 -0400
commit182d7bbac322d6921ce81f8e6aa23d250816381d (patch)
treee795cdf066915f7925e00417d6ff1ad253a0a42c
parentc9f75b04ed5ed65a058d18a8a8dda50632a96de8 (diff)
libata: clean up dummy port_ops
Now that SFF assumptions are removed from core layer, dummy port_ops can be slimmed down. Chop it down. Signed-off-by: Tejun Heo <htejun@gmail.com>
-rw-r--r--drivers/ata/libata-core.c22
1 files changed, 5 insertions, 17 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index f23f50af551c..3a94c69c7fe7 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6159,32 +6159,20 @@ u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
6159/* 6159/*
6160 * Dummy port_ops 6160 * Dummy port_ops
6161 */ 6161 */
6162static void ata_dummy_noret(struct ata_port *ap) { } 6162static unsigned int ata_dummy_qc_issue(struct ata_queued_cmd *qc)
6163static int ata_dummy_ret0(struct ata_port *ap) { return 0; }
6164static void ata_dummy_qc_noret(struct ata_queued_cmd *qc) { }
6165
6166static u8 ata_dummy_check_status(struct ata_port *ap)
6167{ 6163{
6168 return ATA_DRDY; 6164 return AC_ERR_SYSTEM;
6169} 6165}
6170 6166
6171static unsigned int ata_dummy_qc_issue(struct ata_queued_cmd *qc) 6167static void ata_dummy_error_handler(struct ata_port *ap)
6172{ 6168{
6173 return AC_ERR_SYSTEM; 6169 /* truly dummy */
6174} 6170}
6175 6171
6176struct ata_port_operations ata_dummy_port_ops = { 6172struct ata_port_operations ata_dummy_port_ops = {
6177 .sff_check_status = ata_dummy_check_status,
6178 .sff_check_altstatus = ata_dummy_check_status,
6179 .qc_prep = ata_noop_qc_prep, 6173 .qc_prep = ata_noop_qc_prep,
6180 .qc_issue = ata_dummy_qc_issue, 6174 .qc_issue = ata_dummy_qc_issue,
6181 .freeze = ata_dummy_noret, 6175 .error_handler = ata_dummy_error_handler,
6182 .thaw = ata_dummy_noret,
6183 .error_handler = ata_dummy_noret,
6184 .post_internal_cmd = ata_dummy_qc_noret,
6185 .sff_irq_clear = ata_dummy_noret,
6186 .port_start = ata_dummy_ret0,
6187 .port_stop = ata_dummy_noret,
6188}; 6176};
6189 6177
6190const struct ata_port_info ata_dummy_port_info = { 6178const struct ata_port_info ata_dummy_port_info = {