diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-11-16 18:45:25 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-11-17 01:19:54 -0500 |
commit | 1124ba73be6a758965340bd997593b2996649d60 (patch) | |
tree | 032e9a91f7fdaca8444d4138f6472d544b5221c9 | |
parent | 8ffcda17314cfeb698a667567ea63f63362dffbb (diff) |
perf buildid-list: Always show the DSO name
Porcelain can ignore it, humans can make more sense of it.
Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
Suggested-by: Ingo Molnar <mingo@elte.hu>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1258415125-15019-2-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | tools/perf/Documentation/perf-buildid-list.txt | 2 | ||||
-rw-r--r-- | tools/perf/builtin-buildid-list.c | 2 | ||||
-rw-r--r-- | tools/perf/util/symbol.c | 5 |
3 files changed, 3 insertions, 6 deletions
diff --git a/tools/perf/Documentation/perf-buildid-list.txt b/tools/perf/Documentation/perf-buildid-list.txt index abab34e05576..01b642c0bf8f 100644 --- a/tools/perf/Documentation/perf-buildid-list.txt +++ b/tools/perf/Documentation/perf-buildid-list.txt | |||
@@ -26,7 +26,7 @@ OPTIONS | |||
26 | Don't do ownership validation. | 26 | Don't do ownership validation. |
27 | -v:: | 27 | -v:: |
28 | --verbose:: | 28 | --verbose:: |
29 | Be more verbose, showing the name of the DSOs after the buildids. | 29 | Be more verbose. |
30 | 30 | ||
31 | SEE ALSO | 31 | SEE ALSO |
32 | -------- | 32 | -------- |
diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c index 2e377e1be435..7dee9d19ab7a 100644 --- a/tools/perf/builtin-buildid-list.c +++ b/tools/perf/builtin-buildid-list.c | |||
@@ -28,7 +28,7 @@ static const struct option options[] = { | |||
28 | "input file name"), | 28 | "input file name"), |
29 | OPT_BOOLEAN('f', "force", &force, "don't complain, do it"), | 29 | OPT_BOOLEAN('f', "force", &force, "don't complain, do it"), |
30 | OPT_BOOLEAN('v', "verbose", &verbose, | 30 | OPT_BOOLEAN('v', "verbose", &verbose, |
31 | "be more verbose (show counter open errors, etc)"), | 31 | "be more verbose"), |
32 | OPT_END() | 32 | OPT_END() |
33 | }; | 33 | }; |
34 | 34 | ||
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 53de9c4488d8..1b77e81b38de 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
@@ -1442,10 +1442,7 @@ size_t dsos__fprintf_buildid(FILE *fp) | |||
1442 | 1442 | ||
1443 | list_for_each_entry(pos, &dsos, node) { | 1443 | list_for_each_entry(pos, &dsos, node) { |
1444 | ret += dso__fprintf_buildid(pos, fp); | 1444 | ret += dso__fprintf_buildid(pos, fp); |
1445 | if (verbose) | 1445 | ret += fprintf(fp, " %s\n", pos->long_name); |
1446 | ret += fprintf(fp, " %s\n", pos->long_name); | ||
1447 | else | ||
1448 | ret += fprintf(fp, "\n"); | ||
1449 | } | 1446 | } |
1450 | return ret; | 1447 | return ret; |
1451 | } | 1448 | } |