diff options
author | Jens Axboe <jens.axboe@oracle.com> | 2007-01-18 19:30:16 -0500 |
---|---|---|
committer | Jens Axboe <axboe@carl.home.kernel.dk> | 2007-02-11 17:14:44 -0500 |
commit | aaf1228ddfb44f04c87d1e7dfc5ccffdba74363d (patch) | |
tree | fb57e223b97e52e78f88f87e7aefdb5a557985eb | |
parent | 783660b2f60418144e168ab75a06786f9695fc70 (diff) |
cfq-iosched: remove cfq_io_context last_queue
It hasn't been used for a while, kill it off and remove the old
if 0 code chunk.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r-- | block/cfq-iosched.c | 19 | ||||
-rw-r--r-- | include/linux/blkdev.h | 1 |
2 files changed, 2 insertions, 18 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 07b706243772..a31066d6c20c 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -1471,22 +1471,8 @@ err: | |||
1471 | static void | 1471 | static void |
1472 | cfq_update_io_thinktime(struct cfq_data *cfqd, struct cfq_io_context *cic) | 1472 | cfq_update_io_thinktime(struct cfq_data *cfqd, struct cfq_io_context *cic) |
1473 | { | 1473 | { |
1474 | unsigned long elapsed, ttime; | 1474 | unsigned long elapsed = jiffies - cic->last_end_request; |
1475 | 1475 | unsigned long ttime = min(elapsed, 2UL * cfqd->cfq_slice_idle); | |
1476 | /* | ||
1477 | * if this context already has stuff queued, thinktime is from | ||
1478 | * last queue not last end | ||
1479 | */ | ||
1480 | #if 0 | ||
1481 | if (time_after(cic->last_end_request, cic->last_queue)) | ||
1482 | elapsed = jiffies - cic->last_end_request; | ||
1483 | else | ||
1484 | elapsed = jiffies - cic->last_queue; | ||
1485 | #else | ||
1486 | elapsed = jiffies - cic->last_end_request; | ||
1487 | #endif | ||
1488 | |||
1489 | ttime = min(elapsed, 2UL * cfqd->cfq_slice_idle); | ||
1490 | 1476 | ||
1491 | cic->ttime_samples = (7*cic->ttime_samples + 256) / 8; | 1477 | cic->ttime_samples = (7*cic->ttime_samples + 256) / 8; |
1492 | cic->ttime_total = (7*cic->ttime_total + 256*ttime) / 8; | 1478 | cic->ttime_total = (7*cic->ttime_total + 256*ttime) / 8; |
@@ -1649,7 +1635,6 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq, | |||
1649 | cfq_update_io_seektime(cic, rq); | 1635 | cfq_update_io_seektime(cic, rq); |
1650 | cfq_update_idle_window(cfqd, cfqq, cic); | 1636 | cfq_update_idle_window(cfqd, cfqq, cic); |
1651 | 1637 | ||
1652 | cic->last_queue = jiffies; | ||
1653 | cic->last_request_pos = rq->sector + rq->nr_sectors; | 1638 | cic->last_request_pos = rq->sector + rq->nr_sectors; |
1654 | 1639 | ||
1655 | if (cfqq == cfqd->active_queue) { | 1640 | if (cfqq == cfqd->active_queue) { |
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 36a6eacefe20..83dcd8c0e974 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h | |||
@@ -82,7 +82,6 @@ struct cfq_io_context { | |||
82 | 82 | ||
83 | unsigned long last_end_request; | 83 | unsigned long last_end_request; |
84 | sector_t last_request_pos; | 84 | sector_t last_request_pos; |
85 | unsigned long last_queue; | ||
86 | 85 | ||
87 | unsigned long ttime_total; | 86 | unsigned long ttime_total; |
88 | unsigned long ttime_samples; | 87 | unsigned long ttime_samples; |