diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-31 07:35:57 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-31 22:27:50 -0500 |
commit | 1d670fdc8c14780b8e0ad915ad3bb13b2fd9223b (patch) | |
tree | 38e9859d29174b271c66a65fab6c05f55e407a9a | |
parent | 99fa5f53975b4c09beb5d11ed7418fee2dfb43e3 (diff) |
[NETFILTER]: nf_conntrack_netlink: fix unbalanced locking
Properly drop nf_conntrack_lock on tuple parsing error.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/netfilter/nf_conntrack_netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 38141f104db7..bdae2924d425 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c | |||
@@ -1237,7 +1237,7 @@ ctnetlink_new_conntrack(struct sock *ctnl, struct sk_buff *skb, | |||
1237 | CTA_TUPLE_MASTER, | 1237 | CTA_TUPLE_MASTER, |
1238 | u3); | 1238 | u3); |
1239 | if (err < 0) | 1239 | if (err < 0) |
1240 | return err; | 1240 | goto out_unlock; |
1241 | 1241 | ||
1242 | master_h = __nf_conntrack_find(&master, NULL); | 1242 | master_h = __nf_conntrack_find(&master, NULL); |
1243 | if (master_h == NULL) { | 1243 | if (master_h == NULL) { |