aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDouglas Thompson <dougthompson@xmission.com>2007-07-19 04:50:17 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-19 13:04:55 -0400
commit1c52152b3008b7bdcc3b94d0be4d0b814dce1530 (patch)
tree652d286f00ac3101dff0f129ad399a1204a38588
parent654ede200fe028373852bbca387ab4834ddb7228 (diff)
drivers/edac: fix ignored return i82875p
Compiling this module gave a warning that the return value of 'pci_bus_add_device()' was not checked. This patch adds that check and an output message Signed-off-by: Douglas Thompson <dougthompson@xmission.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/edac/i82875p_edac.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c
index 089ec397ca6a..ce5f0053cdd3 100644
--- a/drivers/edac/i82875p_edac.c
+++ b/drivers/edac/i82875p_edac.c
@@ -270,6 +270,7 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev,
270{ 270{
271 struct pci_dev *dev; 271 struct pci_dev *dev;
272 void __iomem *window; 272 void __iomem *window;
273 int err;
273 274
274 *ovrfl_pdev = NULL; 275 *ovrfl_pdev = NULL;
275 *ovrfl_window = NULL; 276 *ovrfl_window = NULL;
@@ -287,7 +288,12 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev,
287 if (dev == NULL) 288 if (dev == NULL)
288 return 1; 289 return 1;
289 290
290 pci_bus_add_device(dev); 291 err = pci_bus_add_device(dev);
292 if (err) {
293 i82875p_printk(KERN_ERR,
294 "%s(): pci_bus_add_device() Failed\n",
295 __func__);
296 }
291 } 297 }
292 298
293 *ovrfl_pdev = dev; 299 *ovrfl_pdev = dev;