diff options
author | Christoph Lameter <cl@linux-foundation.org> | 2009-10-07 19:04:29 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2009-10-12 06:51:49 -0400 |
commit | 494f6a9e12f5137d355d3ce3f5789ef148b642bc (patch) | |
tree | 40e2af82b18ccfcf21133944984a1e16124e2b29 | |
parent | b7a4c946d0dfa91c28029756e8861eaa691fbbc3 (diff) |
this_cpu: Use this_cpu_xx in nmi handling
this_cpu_inc/dec reduces the number of instructions needed.
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | arch/sparc/kernel/nmi.c | 8 | ||||
-rw-r--r-- | arch/x86/kernel/apic/nmi.c | 8 |
2 files changed, 8 insertions, 8 deletions
diff --git a/arch/sparc/kernel/nmi.c b/arch/sparc/kernel/nmi.c index b129611590a4..f30f4a1ead23 100644 --- a/arch/sparc/kernel/nmi.c +++ b/arch/sparc/kernel/nmi.c | |||
@@ -47,7 +47,7 @@ static DEFINE_PER_CPU(short, wd_enabled); | |||
47 | static int endflag __initdata; | 47 | static int endflag __initdata; |
48 | 48 | ||
49 | static DEFINE_PER_CPU(unsigned int, last_irq_sum); | 49 | static DEFINE_PER_CPU(unsigned int, last_irq_sum); |
50 | static DEFINE_PER_CPU(local_t, alert_counter); | 50 | static DEFINE_PER_CPU(long, alert_counter); |
51 | static DEFINE_PER_CPU(int, nmi_touch); | 51 | static DEFINE_PER_CPU(int, nmi_touch); |
52 | 52 | ||
53 | void touch_nmi_watchdog(void) | 53 | void touch_nmi_watchdog(void) |
@@ -112,13 +112,13 @@ notrace __kprobes void perfctr_irq(int irq, struct pt_regs *regs) | |||
112 | touched = 1; | 112 | touched = 1; |
113 | } | 113 | } |
114 | if (!touched && __get_cpu_var(last_irq_sum) == sum) { | 114 | if (!touched && __get_cpu_var(last_irq_sum) == sum) { |
115 | local_inc(&__get_cpu_var(alert_counter)); | 115 | __this_cpu_inc(per_cpu_var(alert_counter)); |
116 | if (local_read(&__get_cpu_var(alert_counter)) == 30 * nmi_hz) | 116 | if (__this_cpu_read(per_cpu_var(alert_counter)) == 30 * nmi_hz) |
117 | die_nmi("BUG: NMI Watchdog detected LOCKUP", | 117 | die_nmi("BUG: NMI Watchdog detected LOCKUP", |
118 | regs, panic_on_timeout); | 118 | regs, panic_on_timeout); |
119 | } else { | 119 | } else { |
120 | __get_cpu_var(last_irq_sum) = sum; | 120 | __get_cpu_var(last_irq_sum) = sum; |
121 | local_set(&__get_cpu_var(alert_counter), 0); | 121 | __this_cpu_write(per_cpu_var(alert_counter), 0); |
122 | } | 122 | } |
123 | if (__get_cpu_var(wd_enabled)) { | 123 | if (__get_cpu_var(wd_enabled)) { |
124 | write_pic(picl_value(nmi_hz)); | 124 | write_pic(picl_value(nmi_hz)); |
diff --git a/arch/x86/kernel/apic/nmi.c b/arch/x86/kernel/apic/nmi.c index 7ff61d6a188a..e631cc4416f7 100644 --- a/arch/x86/kernel/apic/nmi.c +++ b/arch/x86/kernel/apic/nmi.c | |||
@@ -360,7 +360,7 @@ void stop_apic_nmi_watchdog(void *unused) | |||
360 | */ | 360 | */ |
361 | 361 | ||
362 | static DEFINE_PER_CPU(unsigned, last_irq_sum); | 362 | static DEFINE_PER_CPU(unsigned, last_irq_sum); |
363 | static DEFINE_PER_CPU(local_t, alert_counter); | 363 | static DEFINE_PER_CPU(long, alert_counter); |
364 | static DEFINE_PER_CPU(int, nmi_touch); | 364 | static DEFINE_PER_CPU(int, nmi_touch); |
365 | 365 | ||
366 | void touch_nmi_watchdog(void) | 366 | void touch_nmi_watchdog(void) |
@@ -437,8 +437,8 @@ nmi_watchdog_tick(struct pt_regs *regs, unsigned reason) | |||
437 | * Ayiee, looks like this CPU is stuck ... | 437 | * Ayiee, looks like this CPU is stuck ... |
438 | * wait a few IRQs (5 seconds) before doing the oops ... | 438 | * wait a few IRQs (5 seconds) before doing the oops ... |
439 | */ | 439 | */ |
440 | local_inc(&__get_cpu_var(alert_counter)); | 440 | __this_cpu_inc(per_cpu_var(alert_counter)); |
441 | if (local_read(&__get_cpu_var(alert_counter)) == 5 * nmi_hz) | 441 | if (__this_cpu_read(per_cpu_var(alert_counter)) == 5 * nmi_hz) |
442 | /* | 442 | /* |
443 | * die_nmi will return ONLY if NOTIFY_STOP happens.. | 443 | * die_nmi will return ONLY if NOTIFY_STOP happens.. |
444 | */ | 444 | */ |
@@ -446,7 +446,7 @@ nmi_watchdog_tick(struct pt_regs *regs, unsigned reason) | |||
446 | regs, panic_on_timeout); | 446 | regs, panic_on_timeout); |
447 | } else { | 447 | } else { |
448 | __get_cpu_var(last_irq_sum) = sum; | 448 | __get_cpu_var(last_irq_sum) = sum; |
449 | local_set(&__get_cpu_var(alert_counter), 0); | 449 | __this_cpu_write(per_cpu_var(alert_counter), 0); |
450 | } | 450 | } |
451 | 451 | ||
452 | /* see if the nmi watchdog went off */ | 452 | /* see if the nmi watchdog went off */ |