diff options
author | Denis ChengRq <crquan@gmail.com> | 2008-12-01 17:34:56 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-31 18:07:43 -0500 |
commit | c2acf7b90821785fe812cc0aa05148e5a1f84204 (patch) | |
tree | b1fd2a481778c5432237125580b6fc2d2e5d9510 | |
parent | 6badd79bd002788aaec27b50a74ab69ef65ab8ee (diff) |
fs/block_dev.c: __read_mostly improvement and sb_is_blkdev_sb utilization
- iget5_locked in bdget really needs blockdev_superblock, instead of
bd_mnt, so bd_mnt could be just a local variable;
- blockdev_superblock really needs __read_mostly, while local var bd_mnt
not;
- make use of sb_is_blkdev_sb in bd_forget, instead of direct reference
to blockdev_superblock.
Signed-off-by: Denis ChengRq <crquan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | fs/block_dev.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c index 99e0ae1a4c78..349a26c10001 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -326,12 +326,13 @@ static struct file_system_type bd_type = { | |||
326 | .kill_sb = kill_anon_super, | 326 | .kill_sb = kill_anon_super, |
327 | }; | 327 | }; |
328 | 328 | ||
329 | static struct vfsmount *bd_mnt __read_mostly; | 329 | struct super_block *blockdev_superblock __read_mostly; |
330 | struct super_block *blockdev_superblock; | ||
331 | 330 | ||
332 | void __init bdev_cache_init(void) | 331 | void __init bdev_cache_init(void) |
333 | { | 332 | { |
334 | int err; | 333 | int err; |
334 | struct vfsmount *bd_mnt; | ||
335 | |||
335 | bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode), | 336 | bdev_cachep = kmem_cache_create("bdev_cache", sizeof(struct bdev_inode), |
336 | 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| | 337 | 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| |
337 | SLAB_MEM_SPREAD|SLAB_PANIC), | 338 | SLAB_MEM_SPREAD|SLAB_PANIC), |
@@ -373,7 +374,7 @@ struct block_device *bdget(dev_t dev) | |||
373 | struct block_device *bdev; | 374 | struct block_device *bdev; |
374 | struct inode *inode; | 375 | struct inode *inode; |
375 | 376 | ||
376 | inode = iget5_locked(bd_mnt->mnt_sb, hash(dev), | 377 | inode = iget5_locked(blockdev_superblock, hash(dev), |
377 | bdev_test, bdev_set, &dev); | 378 | bdev_test, bdev_set, &dev); |
378 | 379 | ||
379 | if (!inode) | 380 | if (!inode) |
@@ -463,7 +464,7 @@ void bd_forget(struct inode *inode) | |||
463 | 464 | ||
464 | spin_lock(&bdev_lock); | 465 | spin_lock(&bdev_lock); |
465 | if (inode->i_bdev) { | 466 | if (inode->i_bdev) { |
466 | if (inode->i_sb != blockdev_superblock) | 467 | if (!sb_is_blkdev_sb(inode->i_sb)) |
467 | bdev = inode->i_bdev; | 468 | bdev = inode->i_bdev; |
468 | __bd_forget(inode); | 469 | __bd_forget(inode); |
469 | } | 470 | } |