kconfig: lxdialog is now sparse clean

Replacing a gcc idiom with malloc and deleting an unused global
variable made lxdialog sparse clean.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

2 files changed, 3 insertions, 4 deletions

diff --git a/scripts/lxdialog/menubox.c b/scripts/lxdialog/menubox.c
index 260cc4dd5dab..ff3a6179833d 100644
--- a/scripts/lxdialog/menubox.c
+++ b/scripts/lxdialog/menubox.c
@@ -67,7 +67,7 @@ static void print_item(WINDOW * win, const char *item, int choice,
                        int selected, int hotkey)
 {
         int j;
-        char menu_item[menu_width + 1];
+        char *menu_item = malloc(menu_width + 1);
 
         strncpy(menu_item, item, menu_width);
         menu_item[menu_width] = 0;
@@ -95,6 +95,7 @@ static void print_item(WINDOW * win, const char *item, int choice,
                 wmove(win, choice, item_x + 1);
                 wrefresh(win);
         }
+        free(menu_item);
 }
 
 /*
@@ -221,7 +222,7 @@ int dialog_menu(const char *title, const char *prompt, int height, int width,
 
         /*
          * Find length of longest item in order to center menu.
-         * Set 'choice' to default item. 
+         * Set 'choice' to default item.
          */
         item_x = 0;
         for (i = 0; i < item_no; i++) {
diff --git a/scripts/lxdialog/util.c b/scripts/lxdialog/util.c
index 1f84809773f0..ce411474d729 100644
--- a/scripts/lxdialog/util.c
+++ b/scripts/lxdialog/util.c
@@ -26,8 +26,6 @@ bool use_colors = 1;
 
 const char *backtitle = NULL;
 
-const char *dialog_result;
-
 /*
  * Attribute values, default is for mono display
  */