diff options
author | Jesper Juhl <jj@chaosbits.net> | 2012-04-09 16:51:36 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2012-04-30 07:25:43 -0400 |
commit | 90449e5dee4800721a352af11ae4d65d4a56ba93 (patch) | |
tree | 654ef6050865cd4da1eee6ecc842873f14a631a9 | |
parent | 3cc6e78777ae6f577b67e26c76577ef357ac9009 (diff) |
qla1280: Remove redundant NULL check before release_firmware() call
release_firmware() checks for NULL pointers internally so checking
before calling the function is redundant.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r-- | drivers/scsi/qla1280.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 6c6486f626ee..538230be5cca 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c | |||
@@ -4473,17 +4473,14 @@ qla1280_exit(void) | |||
4473 | pci_unregister_driver(&qla1280_pci_driver); | 4473 | pci_unregister_driver(&qla1280_pci_driver); |
4474 | /* release any allocated firmware images */ | 4474 | /* release any allocated firmware images */ |
4475 | for (i = 0; i < QL_NUM_FW_IMAGES; i++) { | 4475 | for (i = 0; i < QL_NUM_FW_IMAGES; i++) { |
4476 | if (qla1280_fw_tbl[i].fw) { | 4476 | release_firmware(qla1280_fw_tbl[i].fw); |
4477 | release_firmware(qla1280_fw_tbl[i].fw); | 4477 | qla1280_fw_tbl[i].fw = NULL; |
4478 | qla1280_fw_tbl[i].fw = NULL; | ||
4479 | } | ||
4480 | } | 4478 | } |
4481 | } | 4479 | } |
4482 | 4480 | ||
4483 | module_init(qla1280_init); | 4481 | module_init(qla1280_init); |
4484 | module_exit(qla1280_exit); | 4482 | module_exit(qla1280_exit); |
4485 | 4483 | ||
4486 | |||
4487 | MODULE_AUTHOR("Qlogic & Jes Sorensen"); | 4484 | MODULE_AUTHOR("Qlogic & Jes Sorensen"); |
4488 | MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); | 4485 | MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); |
4489 | MODULE_LICENSE("GPL"); | 4486 | MODULE_LICENSE("GPL"); |