diff options
author | Matt Carlson <mcarlson@broadcom.com> | 2010-04-05 06:19:23 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-04-06 06:58:00 -0400 |
commit | 5129c3a3faf8c5f4e6dd6ca581e1c4b06f8e837f (patch) | |
tree | e876d6fe2061df003f235e1e80350477cf9aa2f3 | |
parent | ab96b241fd82ec8d546684ab6e29b6530976780a (diff) |
tg3: Fix message 80 char violations
Commit 05dbe005386e7521153dce6c5ad95c98b73b80c7, "Use (pr|netdev)_<level>
macro helpers" extended some of the message lines longer than 80 chars.
This patch reels the line lengths back in.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Reviewed-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/tg3.c | 60 |
1 files changed, 38 insertions, 22 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index c7134c37936e..973c8f51f4e8 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -4335,8 +4335,11 @@ static void tg3_tx_recover(struct tg3 *tp) | |||
4335 | BUG_ON((tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER) || | 4335 | BUG_ON((tp->tg3_flags & TG3_FLAG_MBOX_WRITE_REORDER) || |
4336 | tp->write32_tx_mbox == tg3_write_indirect_mbox); | 4336 | tp->write32_tx_mbox == tg3_write_indirect_mbox); |
4337 | 4337 | ||
4338 | netdev_warn(tp->dev, "The system may be re-ordering memory-mapped I/O cycles to the network device, attempting to recover\n" | 4338 | netdev_warn(tp->dev, |
4339 | "Please report the problem to the driver maintainer and include system chipset information.\n"); | 4339 | "The system may be re-ordering memory-mapped I/O " |
4340 | "cycles to the network device, attempting to recover. " | ||
4341 | "Please report the problem to the driver maintainer " | ||
4342 | "and include system chipset information.\n"); | ||
4340 | 4343 | ||
4341 | spin_lock(&tp->lock); | 4344 | spin_lock(&tp->lock); |
4342 | tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING; | 4345 | tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING; |
@@ -5260,7 +5263,8 @@ static int tg3_restart_hw(struct tg3 *tp, int reset_phy) | |||
5260 | 5263 | ||
5261 | err = tg3_init_hw(tp, reset_phy); | 5264 | err = tg3_init_hw(tp, reset_phy); |
5262 | if (err) { | 5265 | if (err) { |
5263 | netdev_err(tp->dev, "Failed to re-initialize device, aborting\n"); | 5266 | netdev_err(tp->dev, |
5267 | "Failed to re-initialize device, aborting\n"); | ||
5264 | tg3_halt(tp, RESET_KIND_SHUTDOWN, 1); | 5268 | tg3_halt(tp, RESET_KIND_SHUTDOWN, 1); |
5265 | tg3_full_unlock(tp); | 5269 | tg3_full_unlock(tp); |
5266 | del_timer_sync(&tp->timer); | 5270 | del_timer_sync(&tp->timer); |
@@ -5508,7 +5512,8 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, | |||
5508 | netif_tx_stop_queue(txq); | 5512 | netif_tx_stop_queue(txq); |
5509 | 5513 | ||
5510 | /* This is a hard error, log it. */ | 5514 | /* This is a hard error, log it. */ |
5511 | netdev_err(dev, "BUG! Tx Ring full when queue awake!\n"); | 5515 | netdev_err(dev, |
5516 | "BUG! Tx Ring full when queue awake!\n"); | ||
5512 | } | 5517 | } |
5513 | return NETDEV_TX_BUSY; | 5518 | return NETDEV_TX_BUSY; |
5514 | } | 5519 | } |
@@ -5711,7 +5716,8 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb, | |||
5711 | netif_tx_stop_queue(txq); | 5716 | netif_tx_stop_queue(txq); |
5712 | 5717 | ||
5713 | /* This is a hard error, log it. */ | 5718 | /* This is a hard error, log it. */ |
5714 | netdev_err(dev, "BUG! Tx Ring full when queue awake!\n"); | 5719 | netdev_err(dev, |
5720 | "BUG! Tx Ring full when queue awake!\n"); | ||
5715 | } | 5721 | } |
5716 | return NETDEV_TX_BUSY; | 5722 | return NETDEV_TX_BUSY; |
5717 | } | 5723 | } |
@@ -6058,8 +6064,10 @@ static int tg3_rx_prodring_alloc(struct tg3 *tp, | |||
6058 | /* Now allocate fresh SKBs for each rx ring. */ | 6064 | /* Now allocate fresh SKBs for each rx ring. */ |
6059 | for (i = 0; i < tp->rx_pending; i++) { | 6065 | for (i = 0; i < tp->rx_pending; i++) { |
6060 | if (tg3_alloc_rx_skb(tp, tpr, RXD_OPAQUE_RING_STD, i) < 0) { | 6066 | if (tg3_alloc_rx_skb(tp, tpr, RXD_OPAQUE_RING_STD, i) < 0) { |
6061 | netdev_warn(tp->dev, "Using a smaller RX standard ring, only %d out of %d buffers were allocated successfully\n", | 6067 | netdev_warn(tp->dev, |
6062 | i, tp->rx_pending); | 6068 | "Using a smaller RX standard ring. Only " |
6069 | "%d out of %d buffers were allocated " | ||
6070 | "successfully\n", i, tp->rx_pending); | ||
6063 | if (i == 0) | 6071 | if (i == 0) |
6064 | goto initfail; | 6072 | goto initfail; |
6065 | tp->rx_pending = i; | 6073 | tp->rx_pending = i; |
@@ -6088,8 +6096,10 @@ static int tg3_rx_prodring_alloc(struct tg3 *tp, | |||
6088 | 6096 | ||
6089 | for (i = 0; i < tp->rx_jumbo_pending; i++) { | 6097 | for (i = 0; i < tp->rx_jumbo_pending; i++) { |
6090 | if (tg3_alloc_rx_skb(tp, tpr, RXD_OPAQUE_RING_JUMBO, i) < 0) { | 6098 | if (tg3_alloc_rx_skb(tp, tpr, RXD_OPAQUE_RING_JUMBO, i) < 0) { |
6091 | netdev_warn(tp->dev, "Using a smaller RX jumbo ring, only %d out of %d buffers were allocated successfully\n", | 6099 | netdev_warn(tp->dev, |
6092 | i, tp->rx_jumbo_pending); | 6100 | "Using a smaller RX jumbo ring. Only %d " |
6101 | "out of %d buffers were allocated " | ||
6102 | "successfully\n", i, tp->rx_jumbo_pending); | ||
6093 | if (i == 0) | 6103 | if (i == 0) |
6094 | goto initfail; | 6104 | goto initfail; |
6095 | tp->rx_jumbo_pending = i; | 6105 | tp->rx_jumbo_pending = i; |
@@ -7158,7 +7168,8 @@ static int tg3_load_firmware_cpu(struct tg3 *tp, u32 cpu_base, u32 cpu_scratch_b | |||
7158 | 7168 | ||
7159 | if (cpu_base == TX_CPU_BASE && | 7169 | if (cpu_base == TX_CPU_BASE && |
7160 | (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) { | 7170 | (tp->tg3_flags2 & TG3_FLG2_5705_PLUS)) { |
7161 | netdev_err(tp->dev, "%s: Trying to load TX cpu firmware which is 5705\n", | 7171 | netdev_err(tp->dev, |
7172 | "%s: Trying to load TX cpu firmware which is 5705\n", | ||
7162 | __func__); | 7173 | __func__); |
7163 | return -EINVAL; | 7174 | return -EINVAL; |
7164 | } | 7175 | } |
@@ -7238,7 +7249,8 @@ static int tg3_load_5701_a0_firmware_fix(struct tg3 *tp) | |||
7238 | udelay(1000); | 7249 | udelay(1000); |
7239 | } | 7250 | } |
7240 | if (i >= 5) { | 7251 | if (i >= 5) { |
7241 | netdev_err(tp->dev, "tg3_load_firmware fails to set RX CPU PC, is %08x should be %08x\n", | 7252 | netdev_err(tp->dev, "%s fails to set RX CPU PC, is %08x " |
7253 | "should be %08x\n", __func__, | ||
7242 | tr32(RX_CPU_BASE + CPU_PC), info.fw_base); | 7254 | tr32(RX_CPU_BASE + CPU_PC), info.fw_base); |
7243 | return -ENODEV; | 7255 | return -ENODEV; |
7244 | } | 7256 | } |
@@ -7302,7 +7314,8 @@ static int tg3_load_tso_firmware(struct tg3 *tp) | |||
7302 | udelay(1000); | 7314 | udelay(1000); |
7303 | } | 7315 | } |
7304 | if (i >= 5) { | 7316 | if (i >= 5) { |
7305 | netdev_err(tp->dev, "%s fails to set CPU PC, is %08x should be %08x\n", | 7317 | netdev_err(tp->dev, |
7318 | "%s fails to set CPU PC, is %08x should be %08x\n", | ||
7306 | __func__, tr32(cpu_base + CPU_PC), info.fw_base); | 7319 | __func__, tr32(cpu_base + CPU_PC), info.fw_base); |
7307 | return -ENODEV; | 7320 | return -ENODEV; |
7308 | } | 7321 | } |
@@ -8627,8 +8640,9 @@ static int tg3_test_msi(struct tg3 *tp) | |||
8627 | return err; | 8640 | return err; |
8628 | 8641 | ||
8629 | /* MSI test failed, go back to INTx mode */ | 8642 | /* MSI test failed, go back to INTx mode */ |
8630 | netdev_warn(tp->dev, "No interrupt was generated using MSI, switching to INTx mode\n" | 8643 | netdev_warn(tp->dev, "No interrupt was generated using MSI. Switching " |
8631 | "Please report this failure to the PCI maintainer and include system chipset information\n"); | 8644 | "to INTx mode. Please report this failure to the PCI " |
8645 | "maintainer and include system chipset information\n"); | ||
8632 | 8646 | ||
8633 | free_irq(tp->napi[0].irq_vec, &tp->napi[0]); | 8647 | free_irq(tp->napi[0].irq_vec, &tp->napi[0]); |
8634 | 8648 | ||
@@ -8740,7 +8754,8 @@ static void tg3_ints_init(struct tg3 *tp) | |||
8740 | /* All MSI supporting chips should support tagged | 8754 | /* All MSI supporting chips should support tagged |
8741 | * status. Assert that this is the case. | 8755 | * status. Assert that this is the case. |
8742 | */ | 8756 | */ |
8743 | netdev_warn(tp->dev, "MSI without TAGGED? Not using MSI\n"); | 8757 | netdev_warn(tp->dev, |
8758 | "MSI without TAGGED_STATUS? Not using MSI\n"); | ||
8744 | goto defcfg; | 8759 | goto defcfg; |
8745 | } | 8760 | } |
8746 | 8761 | ||
@@ -11778,7 +11793,8 @@ static void __devinit tg3_nvram_init(struct tg3 *tp) | |||
11778 | tp->tg3_flags |= TG3_FLAG_NVRAM; | 11793 | tp->tg3_flags |= TG3_FLAG_NVRAM; |
11779 | 11794 | ||
11780 | if (tg3_nvram_lock(tp)) { | 11795 | if (tg3_nvram_lock(tp)) { |
11781 | netdev_warn(tp->dev, "Cannot get nvram lock, %s failed\n", | 11796 | netdev_warn(tp->dev, |
11797 | "Cannot get nvram lock, %s failed\n", | ||
11782 | __func__); | 11798 | __func__); |
11783 | return; | 11799 | return; |
11784 | } | 11800 | } |
@@ -14130,9 +14146,8 @@ static int __devinit tg3_test_dma(struct tg3 *tp) | |||
14130 | /* Now read it back. */ | 14146 | /* Now read it back. */ |
14131 | ret = tg3_do_test_dma(tp, buf, buf_dma, TEST_BUFFER_SIZE, 0); | 14147 | ret = tg3_do_test_dma(tp, buf, buf_dma, TEST_BUFFER_SIZE, 0); |
14132 | if (ret) { | 14148 | if (ret) { |
14133 | dev_err(&tp->pdev->dev, | 14149 | dev_err(&tp->pdev->dev, "%s: Buffer read failed. " |
14134 | "%s: Buffer read failed. err = %d\n", | 14150 | "err = %d\n", __func__, ret); |
14135 | __func__, ret); | ||
14136 | break; | 14151 | break; |
14137 | } | 14152 | } |
14138 | 14153 | ||
@@ -14733,11 +14748,12 @@ static int __devinit tg3_init_one(struct pci_dev *pdev, | |||
14733 | if (tp->tg3_flags3 & TG3_FLG3_PHY_CONNECTED) { | 14748 | if (tp->tg3_flags3 & TG3_FLG3_PHY_CONNECTED) { |
14734 | struct phy_device *phydev; | 14749 | struct phy_device *phydev; |
14735 | phydev = tp->mdio_bus->phy_map[TG3_PHY_MII_ADDR]; | 14750 | phydev = tp->mdio_bus->phy_map[TG3_PHY_MII_ADDR]; |
14736 | netdev_info(dev, "attached PHY driver [%s] (mii_bus:phy_addr=%s)\n", | 14751 | netdev_info(dev, |
14752 | "attached PHY driver [%s] (mii_bus:phy_addr=%s)\n", | ||
14737 | phydev->drv->name, dev_name(&phydev->dev)); | 14753 | phydev->drv->name, dev_name(&phydev->dev)); |
14738 | } else | 14754 | } else |
14739 | netdev_info(dev, "attached PHY is %s (%s Ethernet) (WireSpeed[%d])\n", | 14755 | netdev_info(dev, "attached PHY is %s (%s Ethernet) " |
14740 | tg3_phy_string(tp), | 14756 | "(WireSpeed[%d])\n", tg3_phy_string(tp), |
14741 | ((tp->tg3_flags & TG3_FLAG_10_100_ONLY) ? "10/100Base-TX" : | 14757 | ((tp->tg3_flags & TG3_FLAG_10_100_ONLY) ? "10/100Base-TX" : |
14742 | ((tp->tg3_flags2 & TG3_FLG2_ANY_SERDES) ? "1000Base-SX" : | 14758 | ((tp->tg3_flags2 & TG3_FLG2_ANY_SERDES) ? "1000Base-SX" : |
14743 | "10/100/1000Base-T")), | 14759 | "10/100/1000Base-T")), |