aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSebastian Ott <sebott@linux.vnet.ibm.com>2011-03-23 05:16:04 -0400
committerMartin Schwidefsky <sky@mschwide.boeblingen.de.ibm.com>2011-03-23 05:15:59 -0400
commit3c190c51f55eab691e5d096747262d2653e67de1 (patch)
tree6faf9a816b3dbfb2fc78b2b7f6215b52b1fb49e8
parentd5ab5276baf9fd8b581cfbf41b10b6d4eae55960 (diff)
[S390] ccwgroup_driver: remove duplicate members
Remove the owner and name members of struct ccwgroup_driver and convert all drivers to store this data in the embedded struct device_driver. Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
-rw-r--r--arch/s390/include/asm/ccwgroup.h4
-rw-r--r--drivers/s390/cio/ccwgroup.c6
-rw-r--r--drivers/s390/net/claw.c6
-rw-r--r--drivers/s390/net/ctcm_main.c6
-rw-r--r--drivers/s390/net/lcs.c6
-rw-r--r--drivers/s390/net/qeth_core_main.c6
6 files changed, 18 insertions, 16 deletions
diff --git a/arch/s390/include/asm/ccwgroup.h b/arch/s390/include/asm/ccwgroup.h
index c79c1e787b86..f2ea2c56a7e1 100644
--- a/arch/s390/include/asm/ccwgroup.h
+++ b/arch/s390/include/asm/ccwgroup.h
@@ -29,8 +29,6 @@ struct ccwgroup_device {
29 29
30/** 30/**
31 * struct ccwgroup_driver - driver for ccw group devices 31 * struct ccwgroup_driver - driver for ccw group devices
32 * @owner: driver owner
33 * @name: driver name
34 * @max_slaves: maximum number of slave devices 32 * @max_slaves: maximum number of slave devices
35 * @driver_id: unique id 33 * @driver_id: unique id
36 * @probe: function called on probe 34 * @probe: function called on probe
@@ -46,8 +44,6 @@ struct ccwgroup_device {
46 * @driver: embedded driver structure 44 * @driver: embedded driver structure
47 */ 45 */
48struct ccwgroup_driver { 46struct ccwgroup_driver {
49 struct module *owner;
50 char *name;
51 int max_slaves; 47 int max_slaves;
52 unsigned long driver_id; 48 unsigned long driver_id;
53 49
diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index 2864581d8ecb..5c567414c4bb 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -428,7 +428,7 @@ ccwgroup_online_store (struct device *dev, struct device_attribute *attr, const
428 gdev = to_ccwgroupdev(dev); 428 gdev = to_ccwgroupdev(dev);
429 gdrv = to_ccwgroupdrv(dev->driver); 429 gdrv = to_ccwgroupdrv(dev->driver);
430 430
431 if (!try_module_get(gdrv->owner)) 431 if (!try_module_get(gdrv->driver.owner))
432 return -EINVAL; 432 return -EINVAL;
433 433
434 ret = strict_strtoul(buf, 0, &value); 434 ret = strict_strtoul(buf, 0, &value);
@@ -442,7 +442,7 @@ ccwgroup_online_store (struct device *dev, struct device_attribute *attr, const
442 else 442 else
443 ret = -EINVAL; 443 ret = -EINVAL;
444out: 444out:
445 module_put(gdrv->owner); 445 module_put(gdrv->driver.owner);
446 return (ret == 0) ? count : ret; 446 return (ret == 0) ? count : ret;
447} 447}
448 448
@@ -616,8 +616,6 @@ int ccwgroup_driver_register(struct ccwgroup_driver *cdriver)
616{ 616{
617 /* register our new driver with the core */ 617 /* register our new driver with the core */
618 cdriver->driver.bus = &ccwgroup_bus_type; 618 cdriver->driver.bus = &ccwgroup_bus_type;
619 cdriver->driver.name = cdriver->name;
620 cdriver->driver.owner = cdriver->owner;
621 619
622 return driver_register(&cdriver->driver); 620 return driver_register(&cdriver->driver);
623} 621}
diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c
index 2e2d2dfe78db..9feb62febb3d 100644
--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -264,8 +264,10 @@ static struct device *claw_root_dev;
264/* ccwgroup table */ 264/* ccwgroup table */
265 265
266static struct ccwgroup_driver claw_group_driver = { 266static struct ccwgroup_driver claw_group_driver = {
267 .owner = THIS_MODULE, 267 .driver = {
268 .name = "claw", 268 .owner = THIS_MODULE,
269 .name = "claw",
270 },
269 .max_slaves = 2, 271 .max_slaves = 2,
270 .driver_id = 0xC3D3C1E6, 272 .driver_id = 0xC3D3C1E6,
271 .probe = claw_probe, 273 .probe = claw_probe,
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index 97fd4800ab12..c189296763a4 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -1774,8 +1774,10 @@ static struct ccw_driver ctcm_ccw_driver = {
1774}; 1774};
1775 1775
1776static struct ccwgroup_driver ctcm_group_driver = { 1776static struct ccwgroup_driver ctcm_group_driver = {
1777 .owner = THIS_MODULE, 1777 .driver = {
1778 .name = CTC_DRIVER_NAME, 1778 .owner = THIS_MODULE,
1779 .name = CTC_DRIVER_NAME,
1780 },
1779 .max_slaves = 2, 1781 .max_slaves = 2,
1780 .driver_id = 0xC3E3C3D4, /* CTCM */ 1782 .driver_id = 0xC3E3C3D4, /* CTCM */
1781 .probe = ctcm_probe_device, 1783 .probe = ctcm_probe_device,
diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index f59429c3bc30..7fbc4adbb6d5 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -2409,8 +2409,10 @@ static struct ccw_driver lcs_ccw_driver = {
2409 * LCS ccwgroup driver registration 2409 * LCS ccwgroup driver registration
2410 */ 2410 */
2411static struct ccwgroup_driver lcs_group_driver = { 2411static struct ccwgroup_driver lcs_group_driver = {
2412 .owner = THIS_MODULE, 2412 .driver = {
2413 .name = "lcs", 2413 .owner = THIS_MODULE,
2414 .name = "lcs",
2415 },
2414 .max_slaves = 2, 2416 .max_slaves = 2,
2415 .driver_id = 0xD3C3E2, 2417 .driver_id = 0xD3C3E2,
2416 .probe = lcs_probe_device, 2418 .probe = lcs_probe_device,
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 150b2cd99ba8..10a3a3b4dd3e 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -4430,8 +4430,10 @@ static int qeth_core_restore(struct ccwgroup_device *gdev)
4430} 4430}
4431 4431
4432static struct ccwgroup_driver qeth_core_ccwgroup_driver = { 4432static struct ccwgroup_driver qeth_core_ccwgroup_driver = {
4433 .owner = THIS_MODULE, 4433 .driver = {
4434 .name = "qeth", 4434 .owner = THIS_MODULE,
4435 .name = "qeth",
4436 },
4435 .driver_id = 0xD8C5E3C8, 4437 .driver_id = 0xD8C5E3C8,
4436 .probe = qeth_core_probe_device, 4438 .probe = qeth_core_probe_device,
4437 .remove = qeth_core_remove_device, 4439 .remove = qeth_core_remove_device,