diff options
author | Sven Eckelmann <sven@narfation.org> | 2012-05-12 07:48:55 -0400 |
---|---|---|
committer | Antonio Quartulli <ordex@autistici.org> | 2012-06-24 12:41:41 -0400 |
commit | c0a559295eb2601602f7dc88f4240afcd666f73a (patch) | |
tree | 1936cd32135d51f0616db90ebc4ee57c34f45790 | |
parent | e5d89254bf763da35b42a3c65289c9962f7240c2 (diff) |
batman-adv: Prefix hash static inline functions with batadv_
All non-static symbols of batman-adv were prefixed with batadv_ to avoid
collisions with other symbols of the kernel. Other symbols of batman-adv
should use the same prefix to keep the naming scheme consistent.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
-rw-r--r-- | net/batman-adv/bridge_loop_avoidance.c | 13 | ||||
-rw-r--r-- | net/batman-adv/hash.h | 19 | ||||
-rw-r--r-- | net/batman-adv/originator.c | 5 | ||||
-rw-r--r-- | net/batman-adv/translation-table.c | 24 | ||||
-rw-r--r-- | net/batman-adv/vis.c | 16 |
5 files changed, 42 insertions, 35 deletions
diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c index 72ff8b90e222..7a2dfd41d5c8 100644 --- a/net/batman-adv/bridge_loop_avoidance.c +++ b/net/batman-adv/bridge_loop_avoidance.c | |||
@@ -379,8 +379,9 @@ static struct backbone_gw *bla_get_backbone_gw(struct bat_priv *bat_priv, | |||
379 | /* one for the hash, one for returning */ | 379 | /* one for the hash, one for returning */ |
380 | atomic_set(&entry->refcount, 2); | 380 | atomic_set(&entry->refcount, 2); |
381 | 381 | ||
382 | hash_added = hash_add(bat_priv->backbone_hash, compare_backbone_gw, | 382 | hash_added = batadv_hash_add(bat_priv->backbone_hash, |
383 | choose_backbone_gw, entry, &entry->hash_entry); | 383 | compare_backbone_gw, choose_backbone_gw, |
384 | entry, &entry->hash_entry); | ||
384 | 385 | ||
385 | if (unlikely(hash_added != 0)) { | 386 | if (unlikely(hash_added != 0)) { |
386 | /* hash failed, free the structure */ | 387 | /* hash failed, free the structure */ |
@@ -540,8 +541,9 @@ static void bla_add_claim(struct bat_priv *bat_priv, const uint8_t *mac, | |||
540 | bat_dbg(DBG_BLA, bat_priv, | 541 | bat_dbg(DBG_BLA, bat_priv, |
541 | "bla_add_claim(): adding new entry %pM, vid %d to hash ...\n", | 542 | "bla_add_claim(): adding new entry %pM, vid %d to hash ...\n", |
542 | mac, vid); | 543 | mac, vid); |
543 | hash_added = hash_add(bat_priv->claim_hash, compare_claim, | 544 | hash_added = batadv_hash_add(bat_priv->claim_hash, |
544 | choose_claim, claim, &claim->hash_entry); | 545 | compare_claim, choose_claim, |
546 | claim, &claim->hash_entry); | ||
545 | 547 | ||
546 | if (unlikely(hash_added != 0)) { | 548 | if (unlikely(hash_added != 0)) { |
547 | /* only local changes happened. */ | 549 | /* only local changes happened. */ |
@@ -590,7 +592,8 @@ static void bla_del_claim(struct bat_priv *bat_priv, const uint8_t *mac, | |||
590 | 592 | ||
591 | bat_dbg(DBG_BLA, bat_priv, "bla_del_claim(): %pM, vid %d\n", mac, vid); | 593 | bat_dbg(DBG_BLA, bat_priv, "bla_del_claim(): %pM, vid %d\n", mac, vid); |
592 | 594 | ||
593 | hash_remove(bat_priv->claim_hash, compare_claim, choose_claim, claim); | 595 | batadv_hash_remove(bat_priv->claim_hash, compare_claim, choose_claim, |
596 | claim); | ||
594 | claim_free_ref(claim); /* reference from the hash is gone */ | 597 | claim_free_ref(claim); /* reference from the hash is gone */ |
595 | 598 | ||
596 | claim->backbone_gw->crc ^= crc16(0, claim->addr, ETH_ALEN); | 599 | claim->backbone_gw->crc ^= crc16(0, claim->addr, ETH_ALEN); |
diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h index eba8f2a55ccc..7ec4e5b0bd41 100644 --- a/net/batman-adv/hash.h +++ b/net/batman-adv/hash.h | |||
@@ -54,8 +54,8 @@ void batadv_hash_destroy(struct hashtable_t *hash); | |||
54 | * called to remove the elements inside of the hash. if you don't remove the | 54 | * called to remove the elements inside of the hash. if you don't remove the |
55 | * elements, memory might be leaked. | 55 | * elements, memory might be leaked. |
56 | */ | 56 | */ |
57 | static inline void hash_delete(struct hashtable_t *hash, | 57 | static inline void batadv_hash_delete(struct hashtable_t *hash, |
58 | hashdata_free_cb free_cb, void *arg) | 58 | hashdata_free_cb free_cb, void *arg) |
59 | { | 59 | { |
60 | struct hlist_head *head; | 60 | struct hlist_head *head; |
61 | struct hlist_node *node, *node_tmp; | 61 | struct hlist_node *node, *node_tmp; |
@@ -89,10 +89,11 @@ static inline void hash_delete(struct hashtable_t *hash, | |||
89 | * Returns 0 on success, 1 if the element already is in the hash | 89 | * Returns 0 on success, 1 if the element already is in the hash |
90 | * and -1 on error. | 90 | * and -1 on error. |
91 | */ | 91 | */ |
92 | static inline int hash_add(struct hashtable_t *hash, | 92 | static inline int batadv_hash_add(struct hashtable_t *hash, |
93 | hashdata_compare_cb compare, | 93 | hashdata_compare_cb compare, |
94 | hashdata_choose_cb choose, | 94 | hashdata_choose_cb choose, |
95 | const void *data, struct hlist_node *data_node) | 95 | const void *data, |
96 | struct hlist_node *data_node) | ||
96 | { | 97 | { |
97 | uint32_t index; | 98 | uint32_t index; |
98 | int ret = -1; | 99 | int ret = -1; |
@@ -133,9 +134,9 @@ out: | |||
133 | * structure you use with just the key filled, we just need the key for | 134 | * structure you use with just the key filled, we just need the key for |
134 | * comparing. | 135 | * comparing. |
135 | */ | 136 | */ |
136 | static inline void *hash_remove(struct hashtable_t *hash, | 137 | static inline void *batadv_hash_remove(struct hashtable_t *hash, |
137 | hashdata_compare_cb compare, | 138 | hashdata_compare_cb compare, |
138 | hashdata_choose_cb choose, void *data) | 139 | hashdata_choose_cb choose, void *data) |
139 | { | 140 | { |
140 | uint32_t index; | 141 | uint32_t index; |
141 | struct hlist_node *node; | 142 | struct hlist_node *node; |
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 90d24fccb9cf..623c23c6ec36 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c | |||
@@ -248,8 +248,9 @@ struct orig_node *batadv_get_orig_node(struct bat_priv *bat_priv, | |||
248 | if (!orig_node->bcast_own_sum) | 248 | if (!orig_node->bcast_own_sum) |
249 | goto free_bcast_own; | 249 | goto free_bcast_own; |
250 | 250 | ||
251 | hash_added = hash_add(bat_priv->orig_hash, compare_orig, | 251 | hash_added = batadv_hash_add(bat_priv->orig_hash, compare_orig, |
252 | choose_orig, orig_node, &orig_node->hash_entry); | 252 | choose_orig, orig_node, |
253 | &orig_node->hash_entry); | ||
253 | if (hash_added != 0) | 254 | if (hash_added != 0) |
254 | goto free_bcast_own_sum; | 255 | goto free_bcast_own_sum; |
255 | 256 | ||
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index bc06af4781b3..72a8548515ae 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c | |||
@@ -234,9 +234,9 @@ void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr, | |||
234 | */ | 234 | */ |
235 | tt_local_entry->common.flags |= TT_CLIENT_NEW; | 235 | tt_local_entry->common.flags |= TT_CLIENT_NEW; |
236 | 236 | ||
237 | hash_added = hash_add(bat_priv->tt_local_hash, compare_tt, choose_orig, | 237 | hash_added = batadv_hash_add(bat_priv->tt_local_hash, compare_tt, |
238 | &tt_local_entry->common, | 238 | choose_orig, &tt_local_entry->common, |
239 | &tt_local_entry->common.hash_entry); | 239 | &tt_local_entry->common.hash_entry); |
240 | 240 | ||
241 | if (unlikely(hash_added != 0)) { | 241 | if (unlikely(hash_added != 0)) { |
242 | /* remove the reference for the hash */ | 242 | /* remove the reference for the hash */ |
@@ -618,6 +618,7 @@ int batadv_tt_global_add(struct bat_priv *bat_priv, struct orig_node *orig_node, | |||
618 | struct tt_global_entry *tt_global_entry = NULL; | 618 | struct tt_global_entry *tt_global_entry = NULL; |
619 | int ret = 0; | 619 | int ret = 0; |
620 | int hash_added; | 620 | int hash_added; |
621 | struct tt_common_entry *common; | ||
621 | 622 | ||
622 | tt_global_entry = tt_global_hash_find(bat_priv, tt_addr); | 623 | tt_global_entry = tt_global_hash_find(bat_priv, tt_addr); |
623 | 624 | ||
@@ -627,18 +628,19 @@ int batadv_tt_global_add(struct bat_priv *bat_priv, struct orig_node *orig_node, | |||
627 | if (!tt_global_entry) | 628 | if (!tt_global_entry) |
628 | goto out; | 629 | goto out; |
629 | 630 | ||
630 | memcpy(tt_global_entry->common.addr, tt_addr, ETH_ALEN); | 631 | common = &tt_global_entry->common; |
632 | memcpy(common->addr, tt_addr, ETH_ALEN); | ||
631 | 633 | ||
632 | tt_global_entry->common.flags = NO_FLAGS; | 634 | common->flags = NO_FLAGS; |
633 | tt_global_entry->roam_at = 0; | 635 | tt_global_entry->roam_at = 0; |
634 | atomic_set(&tt_global_entry->common.refcount, 2); | 636 | atomic_set(&common->refcount, 2); |
635 | 637 | ||
636 | INIT_HLIST_HEAD(&tt_global_entry->orig_list); | 638 | INIT_HLIST_HEAD(&tt_global_entry->orig_list); |
637 | spin_lock_init(&tt_global_entry->list_lock); | 639 | spin_lock_init(&tt_global_entry->list_lock); |
638 | 640 | ||
639 | hash_added = hash_add(bat_priv->tt_global_hash, compare_tt, | 641 | hash_added = batadv_hash_add(bat_priv->tt_global_hash, |
640 | choose_orig, &tt_global_entry->common, | 642 | compare_tt, choose_orig, |
641 | &tt_global_entry->common.hash_entry); | 643 | common, &common->hash_entry); |
642 | 644 | ||
643 | if (unlikely(hash_added != 0)) { | 645 | if (unlikely(hash_added != 0)) { |
644 | /* remove the reference for the hash */ | 646 | /* remove the reference for the hash */ |
@@ -816,8 +818,8 @@ static void tt_global_del_struct(struct bat_priv *bat_priv, | |||
816 | "Deleting global tt entry %pM: %s\n", | 818 | "Deleting global tt entry %pM: %s\n", |
817 | tt_global_entry->common.addr, message); | 819 | tt_global_entry->common.addr, message); |
818 | 820 | ||
819 | hash_remove(bat_priv->tt_global_hash, compare_tt, choose_orig, | 821 | batadv_hash_remove(bat_priv->tt_global_hash, compare_tt, choose_orig, |
820 | tt_global_entry->common.addr); | 822 | tt_global_entry->common.addr); |
821 | tt_global_entry_free_ref(tt_global_entry); | 823 | tt_global_entry_free_ref(tt_global_entry); |
822 | 824 | ||
823 | } | 825 | } |
diff --git a/net/batman-adv/vis.c b/net/batman-adv/vis.c index 619f0a5a8484..e0a90570d667 100644 --- a/net/batman-adv/vis.c +++ b/net/batman-adv/vis.c | |||
@@ -433,8 +433,8 @@ static struct vis_info *add_packet(struct bat_priv *bat_priv, | |||
433 | } | 433 | } |
434 | } | 434 | } |
435 | /* remove old entry */ | 435 | /* remove old entry */ |
436 | hash_remove(bat_priv->vis_hash, vis_info_cmp, vis_info_choose, | 436 | batadv_hash_remove(bat_priv->vis_hash, vis_info_cmp, |
437 | old_info); | 437 | vis_info_choose, old_info); |
438 | send_list_del(old_info); | 438 | send_list_del(old_info); |
439 | kref_put(&old_info->refcount, free_info); | 439 | kref_put(&old_info->refcount, free_info); |
440 | } | 440 | } |
@@ -474,8 +474,8 @@ static struct vis_info *add_packet(struct bat_priv *bat_priv, | |||
474 | recv_list_add(bat_priv, &info->recv_list, packet->sender_orig); | 474 | recv_list_add(bat_priv, &info->recv_list, packet->sender_orig); |
475 | 475 | ||
476 | /* try to add it */ | 476 | /* try to add it */ |
477 | hash_added = hash_add(bat_priv->vis_hash, vis_info_cmp, vis_info_choose, | 477 | hash_added = batadv_hash_add(bat_priv->vis_hash, vis_info_cmp, |
478 | info, &info->hash_entry); | 478 | vis_info_choose, info, &info->hash_entry); |
479 | if (hash_added != 0) { | 479 | if (hash_added != 0) { |
480 | /* did not work (for some reason) */ | 480 | /* did not work (for some reason) */ |
481 | kref_put(&info->refcount, free_info); | 481 | kref_put(&info->refcount, free_info); |
@@ -934,9 +934,9 @@ int batadv_vis_init(struct bat_priv *bat_priv) | |||
934 | 934 | ||
935 | INIT_LIST_HEAD(&bat_priv->vis_send_list); | 935 | INIT_LIST_HEAD(&bat_priv->vis_send_list); |
936 | 936 | ||
937 | hash_added = hash_add(bat_priv->vis_hash, vis_info_cmp, vis_info_choose, | 937 | hash_added = batadv_hash_add(bat_priv->vis_hash, vis_info_cmp, |
938 | bat_priv->my_vis_info, | 938 | vis_info_choose, bat_priv->my_vis_info, |
939 | &bat_priv->my_vis_info->hash_entry); | 939 | &bat_priv->my_vis_info->hash_entry); |
940 | if (hash_added != 0) { | 940 | if (hash_added != 0) { |
941 | pr_err("Can't add own vis packet into hash\n"); | 941 | pr_err("Can't add own vis packet into hash\n"); |
942 | /* not in hash, need to remove it manually. */ | 942 | /* not in hash, need to remove it manually. */ |
@@ -977,7 +977,7 @@ void batadv_vis_quit(struct bat_priv *bat_priv) | |||
977 | 977 | ||
978 | spin_lock_bh(&bat_priv->vis_hash_lock); | 978 | spin_lock_bh(&bat_priv->vis_hash_lock); |
979 | /* properly remove, kill timers ... */ | 979 | /* properly remove, kill timers ... */ |
980 | hash_delete(bat_priv->vis_hash, free_info_ref, NULL); | 980 | batadv_hash_delete(bat_priv->vis_hash, free_info_ref, NULL); |
981 | bat_priv->vis_hash = NULL; | 981 | bat_priv->vis_hash = NULL; |
982 | bat_priv->my_vis_info = NULL; | 982 | bat_priv->my_vis_info = NULL; |
983 | spin_unlock_bh(&bat_priv->vis_hash_lock); | 983 | spin_unlock_bh(&bat_priv->vis_hash_lock); |