aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2007-10-15 11:00:13 -0400
committerIngo Molnar <mingo@elte.hu>2007-10-15 11:00:13 -0400
commit26797a34a24cfeab9951a6f42f27432c0b2546af (patch)
tree9910b5bafd0a443e58450974c55a6106d4998106
parent3e9830dcabdeb3656855ec1b678b6bcf3b50261c (diff)
sched: break out if printing a warning in sched_domain_debug()
checkpatch.pl and Andy Whitcroft noticed the following bug: we did not break out after printing an error. Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--kernel/sched.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index 1a80ac1b6dab..7fefd8ab8b58 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5534,16 +5534,19 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu)
5534 printk("\n"); 5534 printk("\n");
5535 printk(KERN_ERR "ERROR: domain->cpu_power not " 5535 printk(KERN_ERR "ERROR: domain->cpu_power not "
5536 "set\n"); 5536 "set\n");
5537 break;
5537 } 5538 }
5538 5539
5539 if (!cpus_weight(group->cpumask)) { 5540 if (!cpus_weight(group->cpumask)) {
5540 printk("\n"); 5541 printk("\n");
5541 printk(KERN_ERR "ERROR: empty group\n"); 5542 printk(KERN_ERR "ERROR: empty group\n");
5543 break;
5542 } 5544 }
5543 5545
5544 if (cpus_intersects(groupmask, group->cpumask)) { 5546 if (cpus_intersects(groupmask, group->cpumask)) {
5545 printk("\n"); 5547 printk("\n");
5546 printk(KERN_ERR "ERROR: repeated CPUs\n"); 5548 printk(KERN_ERR "ERROR: repeated CPUs\n");
5549 break;
5547 } 5550 }
5548 5551
5549 cpus_or(groupmask, groupmask, group->cpumask); 5552 cpus_or(groupmask, groupmask, group->cpumask);