aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2008-04-14 00:50:08 -0400
committerDavid S. Miller <davem@davemloft.net>2008-04-14 00:50:08 -0400
commitac6f78192054784f02dd47f8e6d7d1c8d75ab173 (patch)
tree3d211ce8031a9cdd478c45574e44350e59732a03
parent3654ea02f2819cf8821c0acd35bc7cded5f1f2a9 (diff)
[INET]: sk_reuse is valbool
sk_reuse is declared as "unsigned char", but is set as type valbool in net/core/sock.c. There is no other place in net/ where sk->sk_reuse is set to a value > 1, so the test "sk_reuse > 1" can not be true. Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/inet_connection_sock.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index ee55678a987d..8d70cfbacb78 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -133,8 +133,6 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)
133 goto tb_not_found; 133 goto tb_not_found;
134tb_found: 134tb_found:
135 if (!hlist_empty(&tb->owners)) { 135 if (!hlist_empty(&tb->owners)) {
136 if (sk->sk_reuse > 1)
137 goto success;
138 if (tb->fastreuse > 0 && 136 if (tb->fastreuse > 0 &&
139 sk->sk_reuse && sk->sk_state != TCP_LISTEN) { 137 sk->sk_reuse && sk->sk_state != TCP_LISTEN) {
140 goto success; 138 goto success;