aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAristeu Rozanski <aris@redhat.com>2008-10-16 01:04:32 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-10-16 14:21:48 -0400
commit8360e81b5dd23c153301f08937a68fd67d9b46c0 (patch)
tree188d2cd9979ae8e6c92eb5f67984c458c46e02f0
parentc066740739c4251effc349e3beae02ead9049e5b (diff)
edac i5000: fix thermal issues
Make the Thermal messages (temperature got past Tmid) be displayed only once because: 1) it's the BIOS job to configure and handle the memory throttling 2) if the BIOS is broken or is aware about the condition, flooding the system logs won't help anything. 3) According to the specification update for Intel 5000 MCHs, all the revisions of this MCH have problems on the thermal sensors, making not automatic (a.k.a. intelligent thermal throttling) impossible. Signed-off-by: Aristeu Rozanski <aris@redhat.com> Signed-off-by: Doug Thompson <dougthompson@xmission.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/edac/i5000_edac.c17
1 files changed, 16 insertions, 1 deletions
diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 7d045ad0a1fe..f0d9b415db50 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -511,8 +511,23 @@ static void i5000_process_fatal_error_info(struct mem_ctl_info *mci,
511 "retry"; 511 "retry";
512 break; 512 break;
513 case FERR_FAT_M3ERR: 513 case FERR_FAT_M3ERR:
514 {
515 static int done;
516
517 /*
518 * This error is generated to inform that the intelligent
519 * throttling is disabled and the temperature passed the
520 * specified middle point. Since this is something the BIOS
521 * should take care of, we'll warn only once to avoid
522 * worthlessly flooding the log.
523 */
524 if (done)
525 return;
526 done++;
527
514 specific = ">Tmid Thermal event with intelligent " 528 specific = ">Tmid Thermal event with intelligent "
515 "throttling disabled"; 529 "throttling disabled";
530 }
516 break; 531 break;
517 } 532 }
518 533